-
Notifications
You must be signed in to change notification settings - Fork 92
Description
We don't roll everything into g3, because not everything functions in g3:
findPackageRootdoesn't work in the g3 test runnerpackage:json_syntax_generatorandpackage:json_schemaare not rolled in.
In order for tests to not fail in the g3 roll, the following directories are either excluded from the copy, or excluded from the test targets per package:
example/test/json_schema/test/example/test/locking/locking_test.darttest/test_test.dart(hooks)
For reference, either in unbundle_config.bzl (for copying) or the BUILD file of the package.
It would be nice if we would write a custom analyzer plugin or some script that can check this before the google3 roll fails. On idea: It would be nice if we could annotate things with @noG3, auto exclude those from the roll and targets, and lint/warn on referring to definitions annotated with @noG3 referenced in files that are not excluded.
FYI @liamappelbe Thanks for skipping the g3 test for now. Here's a breakdown of how other tests are excluded.