-
Notifications
You must be signed in to change notification settings - Fork 92
[ffi] named Arena parameter in using() function
#2767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Arena parameter in using()Arena parameter in using() function
|
Nice! Please also bump the patch version and add a changelog entry so I can hit the release button. 🚀 |
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with
API leaks
|
| Package | Leaked API symbol | Leaking sources |
|---|---|---|
| ffi | MallocAllocator | allocation.dart::malloc |
| ffi | CallocAllocator | allocation.dart::calloc |
This check can be disabled by tagging the PR with skip-leaking-check.
Breaking changes ✔️
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| ffi | None | 2.1.4 | 2.1.5-wip | 2.1.4 | ✔️ |
This check can be disabled by tagging the PR with skip-breaking-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.
|
Thanks for your feedback @dcharkes!
|
|
🙏
We try to avoid abbreviations in our code. |
|
My apologies for the slow response on such a small pr.
I renamed |
|
This PR turns the Arena parameter in the using computation function into a named parameter.
While working with the using-pattern, I wished for this tiny quality of life improvement.
I didn't update the changelog since it's such a small change - can add it if wanted.
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.