Migrate injected client to package web#2306
Closed
annagrin wants to merge 23 commits intodart-lang:mainfrom
Closed
Migrate injected client to package web#2306annagrin wants to merge 23 commits intodart-lang:mainfrom
annagrin wants to merge 23 commits intodart-lang:mainfrom
Conversation
added 6 commits
December 13, 2023 11:19
kevmoo
approved these changes
Dec 14, 2023
annagrin
commented
Dec 14, 2023
annagrin
commented
Dec 14, 2023
srujzs
reviewed
Dec 14, 2023
Member
|
looks like you need to align the pubspec w/ the changelog version |
srujzs
approved these changes
Jan 10, 2024
Contributor
srujzs
left a comment
srujzs
left a comment
There was a problem hiding this comment.
Changes look good! I have mostly nits.
elliette
reviewed
Jan 10, 2024
elliette
reviewed
Jan 10, 2024
elliette
reviewed
Jan 10, 2024
elliette
approved these changes
Jan 10, 2024
added 2 commits
January 16, 2024 10:54
Contributor
Author
|
@srujzs I addressed all the comments and made sure the code works internally and externally. Appreciate another look! |
srujzs
reviewed
Jan 24, 2024
|
|
||
| extension SdkExtension on Sdk { | ||
| JSObject get dart => (this as JSObject)['dart'] as JSObject; | ||
| JSObject get developer => (this as JSObject)['developer'] as JSObject; |
Contributor
There was a problem hiding this comment.
nit: I should've caught this when we were debugging together, but alternatively:
external JSObject get dart;
external JSObject get developer;
external JSObject get _extensions;does the same thing. :)
Contributor
|
One last nit, but LGTM! Thanks again for all your work here! |
Contributor
Author
|
@srujzs Removed all uses of unsafe js interop:) Appreciate another look! |
srujzs
approved these changes
Jan 25, 2024
Contributor
|
Woohoo, no more |
Member
|
Superseded by a5ac4ac \cc @derekxu16 for closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate injected client code to
package:web.Closes: #2338