Pass script uri for javascript expression compilation#2682
Merged
jensjoha merged 17 commits intodart-lang:mainfrom Oct 9, 2025
Merged
Pass script uri for javascript expression compilation#2682jensjoha merged 17 commits intodart-lang:mainfrom
jensjoha merged 17 commits intodart-lang:mainfrom
Conversation
jensjoha
force-pushed
the
script_url_2025
branch
2 times, most recently
from
009e734 to
6eeba23
Compare
Contributor
Author
|
I don't know if there's any process for bumping major versions and/or min dart sdk --- this does both (and as a consequence of going from language version 3.7 to 3.10 most of the changes are formatting --- would it make more sense to land a min sdk change with a formatting first? |
Collaborator
Yeah, let's land a formatting change first. I have a WIP PR that I'll pick up to do that. |
Collaborator
|
Let's wait for #2662 to land. |
Contributor
|
Please send a ping when the formatting changes are landed and this is rebased so this change is easier to review. Thanks :) |
Collaborator
|
Sorry for the delay on the formatting PR @jensjoha. We should be good to move forward with this PR now! |
…on compilation in parts.
…nthing and not release
jensjoha
force-pushed
the
script_url_2025
branch
from
6eeba23 to
b0c141b
Compare
Contributor
Author
|
@bkonyi thanks. I've rebased this PR. |
bkonyi
reviewed
Sep 26, 2025
bkonyi
reviewed
Sep 29, 2025
| } | ||
|
|
||
| await service.streamListen('Debug'); | ||
| stream = service.onEvent('Debug'); |
Collaborator
There was a problem hiding this comment.
Suggested change
| stream = service.onEvent('Debug'); | |
| stream = service.onDebugEvent; |
Collaborator
There was a problem hiding this comment.
It definitely should: https://pub.dev/documentation/vm_service/latest/vm_service/VmService/onDebugEvent.html
Contributor
Author
There was a problem hiding this comment.
service is VmServiceInterface / ChromeProxyService which does not have this getter.
bkonyi
approved these changes
Oct 9, 2025
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 13, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/59db320..a29274b): a29274b 2025-10-09 Greg Spencer Provide output logs when the process launch fails. (dart-lang/ai#293) d33ed02 2025-10-07 Greg Spencer [Feat] Add hot restart tool (dart-lang/ai#297) dartdoc (https://github.com/dart-lang/dartdoc/compare/ec2a4fe..98d03ad): 98d03ad2 2025-10-09 Sarah Zakarias Bump to 9.0.0 (dart-lang/dartdoc#4116) 45ba6ede 2025-10-07 Sam Rawlins Display constructor names in annotations (dart-lang/dartdoc#4115) ecosystem (https://github.com/dart-lang/ecosystem/compare/96ee861..f4fbac4): f4fbac4 2025-10-13 Moritz Use up to date firehose in publish (dart-lang/ecosystem#376) 1fe5686 2025-10-10 Moritz Relax assumptions on workspaces in firehose (dart-lang/ecosystem#375) shelf (https://github.com/dart-lang/shelf/compare/f30d650..710b8ce): 710b8ce 2025-10-08 Kevin Moore shelf_router_generator: update dependencies, SDK (dart-lang/shelf#484) tools (https://github.com/dart-lang/tools/compare/6866f9b..adf3fe7): adf3fe78 2025-10-13 Parker Lougheed [markdown] Preserve metadata passed to fenced code blocks (dart-lang/tools#2186) b435a46b 2025-10-10 Stephen Adams Fix `SingleMapping.spanFor` to use previous line (dart-lang/tools#2205) 4c7dae18 2025-10-10 Morgan :) Fix for skipped tests on Windows. (dart-lang/tools#2204) 50b4514e 2025-10-09 Morgan :) Use Event extension type for Windows DirectoryWatcher. (dart-lang/tools#2203) a0af8b59 2025-10-08 Morgan :) Use Event extension type for MacOS DirectoryWatcher. (dart-lang/tools#2201) 0f50f061 2025-10-08 Morgan :) Add package-private extension type Event on FileSystemEvent. (dart-lang/tools#2200) d67ab97c 2025-10-07 Moritz [bazel_worker] Upgrade `protobuf` + cleanups (dart-lang/tools#2195) webdev (https://github.com/dart-lang/webdev/compare/29ba1b1..186bfe7): 186bfe71 2025-10-09 Ben Konyi [ DWDS ] Expose `dtdUri` via `DebugConnection` (dart-lang/webdev#2694) 3ab8fca3 2025-10-09 Srujan Gaddam [DWDS] Don't send PauseInterrupted event during a hot reload (dart-lang/webdev#2695) cdc5cc3c 2025-10-09 jensjoha Pass script uri for javascript expression compilation (dart-lang/webdev#2682) Change-Id: Ie78adfec4a8887af1ea3104b50c52ea2fd3bb1d2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/454621 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass over the script uri (which when in parts is different from the library uri) when doing js expression evaluation.