Skip to content

fix dartExecutable passed through to dwds#2816

Merged
Markzipan merged 2 commits intodart-lang:dwds-27.0.2-releasefrom
schultek:patch-1
Apr 14, 2026
Merged

fix dartExecutable passed through to dwds#2816
Markzipan merged 2 commits intodart-lang:dwds-27.0.2-releasefrom
schultek:patch-1

Conversation

@schultek
Copy link
Copy Markdown

@schultek schultek commented Apr 14, 2026

@Markzipan After testing this I noticed the dartExecutable needs to be passed here to work correctly.

Resolves #2813


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

Copy link
Copy Markdown
Contributor

@Markzipan Markzipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that - LGTM

@schultek
Copy link
Copy Markdown
Author

schultek commented Apr 14, 2026

@Markzipan Is it ok that this targets the dwds-27.0.2-release branch or how do you want this to be released?

@Markzipan
Copy link
Copy Markdown
Contributor

It should be fine - I'll merge this in, pin dwds-27.0.3, then merge that back into main with restored history.

@Markzipan Markzipan merged commit 2650bab into dart-lang:dwds-27.0.2-release Apr 14, 2026
46 of 47 checks passed
@schultek schultek deleted the patch-1 branch April 15, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants