fix dartExecutable passed through to dwds#2816
Merged
Markzipan merged 2 commits intodart-lang:dwds-27.0.2-releasefrom Apr 14, 2026
Merged
fix dartExecutable passed through to dwds#2816Markzipan merged 2 commits intodart-lang:dwds-27.0.2-releasefrom
Markzipan merged 2 commits intodart-lang:dwds-27.0.2-releasefrom
Conversation
Markzipan
approved these changes
Apr 14, 2026
Contributor
Markzipan
left a comment
There was a problem hiding this comment.
Thanks for catching that - LGTM
Author
|
@Markzipan Is it ok that this targets the dwds-27.0.2-release branch or how do you want this to be released? |
Contributor
|
It should be fine - I'll merge this in, pin |
2650bab
into
dart-lang:dwds-27.0.2-release
46 of 47 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Markzipan After testing this I noticed the
dartExecutableneeds to be passed here to work correctly.Resolves #2813
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.