Skip to content

fix: replace hardcoded -march=core2 with architecture detection for ARM builds #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darvid merged 1 commit into from
Aug 6, 2025
Merged

fix: replace hardcoded -march=core2 with architecture detection for ARM builds #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,19 @@ if(HS_BUILD_REQUIRED)
endif()
else()
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}")
set(HS_CMAKE_COMMON_FLAGS "-march=core2 -fPIC")

# Architecture-specific compiler flags
if(CMAKE_SYSTEM_PROCESSOR MATCHES "^(arm|aarch64|arm64)")
# ARM architecture - use conservative flags with SIMDE_BACKEND
set(HS_CMAKE_COMMON_FLAGS "-fPIC")
elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "^(x86|X86|amd64|AMD64|x86_64|i[3-6]86)")
# x86/x86_64 architecture - use compatible x86-64 baseline
set(HS_CMAKE_COMMON_FLAGS "-march=x86-64 -fPIC")
else()
# Other architectures - rely on SIMDE_BACKEND for portability
set(HS_CMAKE_COMMON_FLAGS "-fPIC")
endif()

set(HS_CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${HS_CMAKE_COMMON_FLAGS}")
set(HS_CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${HS_CMAKE_COMMON_FLAGS} -D_GLIBCXX_USE_CXX11_ABI=1")
set(HS_CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}")
Expand Down
Loading