Skip to content

Missed num of skip #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
howareyou wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Missed num of skip #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b705ec
Missed num of skip
howareyou Jan 2, 2017
9541d43
add the trailing comma back
howareyou Jan 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions HTMLTestRunner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,7 @@ def _generate_report(self, result):
desc = desc,
count = np+ns+nf+ne,
Pass = np,
skip = ns,
fail = nf,
error = ne,
Copy link

@eestrada eestrada Jan 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@howareyou The trailing comma is syntactically correct in Python. It is useful for adding lines later without raising a syntax error when someone forgets that a comma was actually needed in the preceding.

Other than your personal preference, is there some reason for removing it? If not, then it complicates the git history without adding value. I suggest removing it from the commit.

Copy link

@eestrada eestrada Jan 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the rest of the commit, it looks fine to me.

As to a test case, I am slammed with work and am working a lot of overtime. I am not sure I can carve out much time right now. I am happy to review whatever is submitted, but I can't make promises as to actually generating any code myself.

cid = 'c%s' % (cid+1),
Expand Down