This repository was archived by the owner on Jan 12, 2022. It is now read-only.
[EV-1263] nullHash bug temporary work around#37
Merged
Merged
Conversation
Cofresi
changed the title
|
FYI, dashpay/dash#2699 finally fixes this actual issue. |
Contributor
|
@codablock Nice one! Thank you! I guess we still keep this one for some time for the evo image. We just need not to forgot about remove this temporary fix when the change gets merged to the evo image |
Contributor
Author
created a task in JIRA that reminds us of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fix for dashcore bug that errors when using null hash
0000000000000000000000000000000000000000000000000000000000000000as the baseHash for theprotx diffrpc command (as described in the DIP 4 specification).Until the core bug is fixed this PR proposes to use the genesis hash in a network agnostic way instead of the null hash: If a masternode list diff is requested for the first time then we fill the baseHash with the genesis hash of the network which the requested dapi node is a member of.
This PR also addresses a concern that the valid masternode list could be overwritten with an empty list and now throws an error instead of continuing.