fix: invalid amount in identity create broke screen

[pauldelucia]

If a user entered an invalid amount in the Identity Create screen, it would break and the only way out was to exit the screen and reopen it

Summary by CodeRabbit

• New Features

  • Added validation to ensure the funding amount is a positive number when creating a new identity.

• Bug Fixes

  • Prevented QR code generation and further UI actions if the funding amount is invalid or non-positive.

• Refactor

  • Simplified identity and masternode information by removing unused fields and obsolete options.
  • Removed deprecated funding method options and related balance checking logic.
  • Improved UI responsiveness by resetting funding amount and step when changing funding methods.

• Style

  • Cleaned up comments and improved code readability without affecting functionality.

[coderabbitai]

Walkthrough

The changes simplify identity management UI code by removing unused or redundant fields, structs, and enum variants related to masternode and wallet operations. Funding method options are streamlined, balance polling logic is removed, and input validation is improved. Several methods are renamed for internal use, and inline comments are cleaned up for clarity.

Changes

Files/Groups	Change Summary
src/ui/identities/add_existing_identity_screen.rs	Removed collateral and operator fields from MasternodeInfo and HPMasternodeInfo; deleted OperatorInfo and NodeKeyInfo structs; simplified KeyInfo; removed IdentityLoadMethod enum; renamed two methods to be private by convention.
src/ui/identities/add_new_identity_screen/by_wallet_qr_code.rs	Moved funding amount parsing closer to QR code rendering; added check for positive funding amount before proceeding; improved input validation.
src/ui/identities/add_new_identity_screen/mod.rs	Removed AttachedCoreWallet from FundingMethod enum and related code; removed balance polling logic; improved funding amount input validation; reset funding amount and step on funding method change.
src/ui/identities/top_up_identity_screen/mod.rs	Removed inline comments about locking; deleted match arm for removed funding method; made minor whitespace adjustments.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant QRCodeRenderer

    User->>UI: Select funding method
    UI->>UI: Reset funding amount and step
    User->>UI: Enter funding amount
    UI->>UI: Validate funding amount (> 0)
    alt Invalid amount
        UI-->>User: Show "Invalid amount" message
    else Valid amount
        UI->>QRCodeRenderer: Render QR code with funding amount
        QRCodeRenderer-->>UI: QR code displayed
    end

Loading

Poem

A hop, a skip, some code we prune,
Old keys and wallets leave the room.
Funding flows with checks anew,
QR codes shine with value true.
The rabbit cheers, the UI’s clean—
Simpler screens, a sleeker scene!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 562d6ce and ff07f66.

📒 Files selected for processing (4)

• src/ui/identities/add_existing_identity_screen.rs (2 hunks)
• src/ui/identities/add_new_identity_screen/by_wallet_qr_code.rs (1 hunks)
• src/ui/identities/add_new_identity_screen/mod.rs (8 hunks)
• src/ui/identities/top_up_identity_screen/mod.rs (5 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/ui/identities/top_up_identity_screen/mod.rs (2)

src/ui/wallets/wallets_screen/mod.rs (1)

• wallet (328-380)

src/context_provider.rs (1)

• clone (139-146)

🔇 Additional comments (14)

src/ui/identities/add_new_identity_screen/by_wallet_qr_code.rs (1)

139-145: Good validation improvement for funding amount

The added validation ensures the funding amount is parsed successfully and is positive before proceeding to render the QR code, preventing the screen from breaking when invalid amounts are entered.

src/ui/identities/top_up_identity_screen/mod.rs (4)

127-127: Code cleanup looks good

Removing unnecessary comments about locking operations while keeping the actual locking logic intact.

---

156-157: Clean formatting improvement

Adding a blank line after the conditional block improves code readability.

---

167-174: Simplified code looks good

Removing redundant comments while maintaining the locking logic improves code readability.

---

186-188: Code cleanup looks good

Clean removal of redundant comments while preserving the functional code.

src/ui/identities/add_existing_identity_screen.rs (3)

261-261: Good naming convention for internal method

Renaming the method with a leading underscore clarifies that this is intended for internal use only.

---

312-312: Good naming convention for internal method

Prefixing with underscore indicates this method is for internal use only.

---

317-317: Consistently updated method call

Properly updated the method call to use the renamed method with underscore prefix.

src/ui/identities/add_new_identity_screen/mod.rs (6)

30-32: Good import cleanup

Simplified imports by removing unnecessary ones and organizing the remaining ones more clearly.

---

374-385: Good state reset on funding method change

The code now appropriately resets the funding amount and updates the step state when changing funding methods, preventing state inconsistencies.

---

404-405: Good default amount reset

Resetting the funding amount to the default value of "0.5" when switching to the unused asset lock funding method ensures consistent user experience.

---

435-436: Good state management

Resetting the funding amount when switching to the QR code funding method ensures a consistent initial state.

---

659-663: Excellent validation for funding amount

This is the key fix that addresses the PR issue. Adding validation to show an error message when the funding amount is invalid or non-positive prevents the screen from breaking, improving user experience.

---

1064-1065: Good UI properties

Setting the popup window to non-collapsible and non-resizable improves the UI consistency.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lklimek]

@coderabbitai review

[lklimek]

Why underscore? If it is unused, maybe just delete it?

[pauldelucia]

Maybe, but Sam wrote it with the intention of using it later, and it has some logic in there I don't want to have to figure out again :)

[lklimek]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.