refactor: create FundingWidget to top up identity and add funds with QR code on wallet page by lklimek · Pull Request #416 · dashpay/dash-evo-tool

lklimek · 2025-07-23T15:47:59Z

NOTE: Requires #419 to be merged first.

New component introduced, FundingWidget, that is used everywhere where we have funding (top up identity, create identity, wallet addresses list)
Added button to generate new address if the user wants more privacy (based on community feedback)
On list of addresses, added button to top up selected core address that is showing dialog with QR code
Create new identity flow changed - now it waits for funding first

Known bugs

Bugs that are also present on v1.0-dev, to be handled separately:

Funding with existing asset locks doesn't work for me
When topping up with QR code, I enter 0.5 DASH, then I send 1 DASH. As a result, identity is topped up with 1 DASH, expected: 0.5 DASH.

Copilot's summary

This pull request introduces significant changes to the wallet and UI components, primarily focusing on simplifying the codebase by removing unused features and improving modularity. Key changes include the addition of a new method for calculating wallet balances, removal of multiple UI screens related to funding methods, and enhancements to the WalletFundedScreenStep enum.

Wallet Enhancements:

Added a max_balance method to the Wallet model to calculate the total balance by summing all UTXOs (src/model/wallet/mod.rs).

UI Simplification:

Removed unused UI screens for funding methods, including:
- by_using_unused_asset_lock.rs
- by_using_unused_balance.rs
- by_wallet_qr_code.rs
- by_using_unused_asset_lock.rs under top_up_identity_screen.
Added a new funding_widget module to the UI components (src/ui/components/mod.rs).

Codebase Improvements:

Enhanced the WalletFundedScreenStep enum by:
- Adding an is_processing method to check if the wallet is in a processing state.
- Implementing the Display trait for better string representation (src/ui/identities/funding_common.rs).
Changed funding_common to a public module for broader accessibility (src/ui/identities/mod.rs).

These changes collectively streamline the codebase, reduce redundancy, and improve the maintainability of wallet-related functionalities.

coderabbitai · 2025-07-23T15:48:06Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/wallet-address-top-up

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Copilot

Pull Request Overview

This PR introduces a centralized FundingWidget component to streamline funding operations across the application, replacing multiple scattered funding implementations with a single, reusable component. The refactor consolidates wallet funding, asset lock usage, and QR code generation into one cohesive interface.

Key changes include:

Created a new FundingWidget component that handles all funding scenarios (wallet balance, asset locks, QR codes)
Replaced separate funding screens with the unified widget in identity creation and top-up flows
Added wallet address top-up functionality with QR code support in the wallets screen

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`src/ui/components/funding_widget.rs`	New centralized funding component with comprehensive funding method support
`src/ui/wallets/wallets_screen/mod.rs`	Added funding widget integration and top-up modal for wallet addresses
`src/ui/identities/top_up_identity_screen/mod.rs`	Refactored to use the new funding widget instead of custom implementations
`src/ui/identities/add_new_identity_screen/mod.rs`	Simplified identity creation flow using the funding widget
Multiple `by_*.rs` files	Removed redundant funding method implementations

Copilot · 2025-07-28T17:15:35Z

+            .show(ui, |ui| {
+                ui.vertical(|ui| {
+                    // Render the widget and get response
+                    let funding_widget = self.funding_widget.as_mut().expect("Checked above");


[nitpick] Using expect with a custom message is good, but consider using a more descriptive message that explains the actual condition being checked (e.g., "FundingWidget should be Some when funding_widget.is_some() returns true").

Suggested change

let funding_widget = self.funding_widget.as_mut().expect("Checked above");

let funding_widget = self.funding_widget.as_mut().expect("FundingWidget should be Some because self.funding_widget.is_none() was checked above");

Copilot · 2025-07-28T17:15:35Z

+    /// Track existing UTXOs at the time the address was set up
+    /// This is used when ignore_existing_utxos is true to filter out pre-existing UTXOs


The existing_utxos_snapshot field needs documentation explaining its purpose in filtering pre-existing UTXOs when ignore_existing_utxos is enabled.

Suggested change

/// Track existing UTXOs at the time the address was set up

/// This is used when ignore_existing_utxos is true to filter out pre-existing UTXOs

/// A snapshot of existing UTXOs (Unspent Transaction Outputs) at the time the funding address was set up.

/// This field is used in conjunction with the `ignore_existing_utxos` flag. When `ignore_existing_utxos` is set to true,

/// the `existing_utxos_snapshot` is used to filter out UTXOs that existed prior to the funding process, ensuring that

/// only newly created UTXOs are considered for funding. This helps prevent double-counting or unintended reuse of

/// pre-existing funds.

…let-address-top-up

…ss-top-up

lklimek added 12 commits July 23, 2025 17:49

feat: add button to top up address on wallet screen

faa495f

chore: identity top up using funding widget

675943d

chore: asset locks

03dc7a7

refactor: use FundingWidget in identity create

0d651e8

feat: top up new address button

fb018a3

feat: identity create done

d488c1f

chore: top up

0bd971f

chore: remove unused steps

2db8037

feat: show/hide validation

6a13346

chore: wallet screen top up autoclose

8eee4a6

fix: top up of existing address fails when there is already a utxo

f81d268

chore: top up automatically

2302750

lklimek force-pushed the feat/wallet-address-top-up branch from c3ca58a to 2302750 Compare July 23, 2025 15:49

lklimek requested review from QuantumExplorer, Copilot and pauldelucia and removed request for QuantumExplorer and pauldelucia July 23, 2025 16:13

This comment was marked as outdated.

Sign in to view

lklimek added 8 commits July 24, 2025 08:51

chore: copilot review

b6b6058

chore: copilot feedback

d408a25

chore: clippy

0cc6bbd

feat: amount input, first building version

d34ca91

test(amount): fixed tests

dc665be

chore: I think final

0478847

chore: my_tokens display correct amount

589cfb5

chore: transfer tokens update

1585a93

lklimek added 4 commits July 28, 2025 16:34

chore: amount improvements

ed47168

chore: copilot review

4bdf017

chore: amount improvements

5bc61f3

Merge branch 'refactor/amount-input' into feat/wallet-address-top-up

e597182

lklimek mentioned this pull request Jul 28, 2025

feat: implement asset lock creation and detail screens #418

Merged

lklimek added this to Platform team Jul 28, 2025

lklimek moved this to In review / testing in Platform team Jul 28, 2025

lklimek changed the base branch from v1.0-dev to refactor/amount-input July 28, 2025 17:13

lklimek requested a review from Copilot July 28, 2025 17:14

Copilot AI reviewed Jul 28, 2025

View reviewed changes

lklimek added 9 commits July 29, 2025 14:30

backport: amount component from

51cd7a2

chore: fix imports

3636d41

chore: refactor

e89ad0b

chore: futher refactor

c074249

chore: further refactor based on feedback

8710d44

doc: simplified component design pattern description

73c46b3

chore: peer review

463e82c

doc: update docs

d02c637

chore: amount input

a172f03

Base automatically changed from refactor/amount-input to v1.0-dev July 31, 2025 07:07

lklimek added 6 commits August 4, 2025 12:10

Merge commit 'a172f031067aed35f07a25df29b239745d9c1144' into feat/wal…

5aae125

…let-address-top-up

Merge remote-tracking branch 'origin/v1.0-dev' into feat/wallet-addre…

710ecd8

…ss-top-up

chore: fixes after merge

054542a

chore: remove unused impl Widget

d6c82c8

fix: unblock UI on error

863c979

chore: various fixes

8876772

lklimek marked this pull request as draft August 6, 2025 07:07

lklimek closed this Jan 20, 2026

github-project-automation Bot moved this from In review / testing to Done in Platform team Jan 20, 2026

lklimek deleted the feat/wallet-address-top-up branch February 26, 2026 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: create FundingWidget to top up identity and add funds with QR code on wallet page#416

refactor: create FundingWidget to top up identity and add funds with QR code on wallet page#416
lklimek wants to merge 54 commits into
v1.0-devfrom
feat/wallet-address-top-up

lklimek commented Jul 23, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 23, 2025 •

edited

Loading

Other AI code review bot(s) detected

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jul 28, 2025

Uh oh!

Uh oh!

Copilot AI Jul 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	let funding_widget = self.funding_widget.as_mut().expect("Checked above");
	let funding_widget = self.funding_widget.as_mut().expect("FundingWidget should be Some because self.funding_widget.is_none() was checked above");

		/// Track existing UTXOs at the time the address was set up
		/// This is used when ignore_existing_utxos is true to filter out pre-existing UTXOs

-    /// Track existing UTXOs at the time the address was set up
-    /// This is used when ignore_existing_utxos is true to filter out pre-existing UTXOs
+    /// A snapshot of existing UTXOs (Unspent Transaction Outputs) at the time the funding address was set up.
+    /// This field is used in conjunction with the `ignore_existing_utxos` flag. When `ignore_existing_utxos` is set to true,
+    /// the `existing_utxos_snapshot` is used to filter out UTXOs that existed prior to the funding process, ensuring that
+    /// only newly created UTXOs are considered for funding. This helps prevent double-counting or unintended reuse of
+    /// pre-existing funds.

Conversation

lklimek commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Known bugs

Copilot's summary

Wallet Enhancements:

UI Simplification:

Codebase Improvements:

Uh oh!

coderabbitai Bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lklimek commented Jul 23, 2025 •

edited

Loading

coderabbitai Bot commented Jul 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)