Refactor token creator helpers#518
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThese changes extend the TokenNameLanguage type with three new public methods for language metadata (ISO codes, UI labels, and selection ordering) and refactor the token creator form to use helper functions for wallet unlocking, language selection UI, state reset, and input parsing—centralizing repeated logic while preserving existing behavior. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PastaPastaPasta
force-pushed
the
codex/tokens-ui-simplify
branch
from
3ba309c to
51fd43e
Compare
Member
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@src/ui/tokens/tokens_screen/mod.rs`:
- Around line 945-999: The iso_code() mapping contains a duplicate ("zh") for
TokenNameLanguage::Chinese and TokenNameLanguage::Mandarin and lacks unit tests;
update the mapping to eliminate collisions (e.g., change the enum variant name
or return value for Mandari n/Chinese so each TokenNameLanguage variant returns
a unique ISO string) and add inline #[test]s that exercise
TokenNameLanguage::iso_code() to assert expected codes and detect duplicates
(create tests that iterate all TokenNameLanguage variants, assert their
iso_code() values against expected map, and assert uniqueness of returned
codes). Ensure you update the TokenNameLanguage enum reference (e.g.,
TokenNameLanguage::Chinese, TokenNameLanguage::Mandarin) and add tests alongside
iso_code() in the same module to satisfy the repository’s Rust test guidelines.
In `@src/ui/tokens/tokens_screen/token_creator.rs`:
- Around line 1004-1037: ensure_wallet_unlocked currently records errors from
try_open_wallet_no_password and allows selected_wallet == None to continue;
change it to short‑circuit and surface errors immediately: inside
ensure_wallet_unlocked, if self.selected_wallet is None set
self.token_creator_error_message to a clear message and return false; if
try_open_wallet_no_password(wallet) returns Err, set
self.token_creator_error_message to that error and return false (do not proceed
to wallet_needs_unlock); keep the existing UI flow for
wallet_needs_unlock/wallet_unlock_popup.open when the wallet exists and no open
error occurred. Use the function and field names ensure_wallet_unlocked,
try_open_wallet_no_password, wallet_needs_unlock, selected_wallet,
token_creator_error_message, and wallet_unlock_popup to locate and update the
logic.
- Around line 1212-1312: The duplicate-language error prints the plural string
(name_with_language.1) instead of the language; in parse_token_names replace the
incorrect format argument in the duplicate check (format!("Duplicate token name
language: {:?}", name_with_language.1)) with the language identifier (e.g.,
name_with_language.2 or name_with_language.2.iso_code()) so the message reports
the actual language; keep the rest of the seen_languages logic intact.
🧹 Nitpick comments (2)
src/ui/tokens/tokens_screen/mod.rs (1)
944-1114: Add tests for the new language metadata helpersThese helpers are now public and drive parsing/UI order; a small inline test will lock the mappings and ordering.
As per coding guidelines: `**/*.rs`: Write unit tests inline in source files using `#[test]` attribute.✅ Example test
#[test] fn token_name_language_metadata_is_stable() { assert_eq!(TokenNameLanguage::English.iso_code(), "en"); assert_eq!(TokenNameLanguage::English.ui_label(), "English"); assert_eq!( TokenNameLanguage::selection_order().first(), Some(&TokenNameLanguage::English) ); }src/ui/tokens/tokens_screen/token_creator.rs (1)
1042-1072: Scope egui style mutations and useui_label()for selected text
ui.style_mut()changes persist for the rest of theUi, affecting downstream widgets unintentionally. Scope the style changes usingui.scope()and align the selected text withui_label()to display friendly language names instead of debug format.♻️ Scoped styling example
fn render_token_name_language_selector( ui: &mut Ui, current_language: &mut TokenNameLanguage, allow_all_languages: bool, id_salt: &str, ) { - ui.style_mut().spacing.combo_height = 10.0; - ui.style_mut().spacing.button_padding = egui::vec2(3.0, 0.0); - ui.style_mut().visuals.widgets.inactive.fg_stroke.width = 1.0; - ui.style_mut() - .text_styles - .get_mut(&egui::TextStyle::Body) - .unwrap() - .size = 12.0; - - ComboBox::from_id_salt(id_salt) - .selected_text(format!("{}", current_language)) - .width(100.0) - .show_ui(ui, |ui| { - ui.style_mut() - .text_styles - .get_mut(&egui::TextStyle::Body) - .unwrap() - .size = 12.0; - for &language in TokenNameLanguage::selection_order() { - if !allow_all_languages && language != TokenNameLanguage::English { - continue; - } - ui.selectable_value(current_language, language, language.ui_label()); - } - }); + ui.scope(|ui| { + ui.style_mut().spacing.combo_height = 10.0; + ui.style_mut().spacing.button_padding = egui::vec2(3.0, 0.0); + ui.style_mut().visuals.widgets.inactive.fg_stroke.width = 1.0; + ui.style_mut() + .text_styles + .get_mut(&egui::TextStyle::Body) + .unwrap() + .size = 12.0; + + ComboBox::from_id_salt(id_salt) + .selected_text(current_language.ui_label()) + .width(100.0) + .show_ui(ui, |ui| { + ui.style_mut() + .text_styles + .get_mut(&egui::TextStyle::Body) + .unwrap() + .size = 12.0; + for &language in TokenNameLanguage::selection_order() { + if !allow_all_languages && language != TokenNameLanguage::English { + continue; + } + ui.selectable_value(current_language, language, language.ui_label()); + } + }); + }); }
Comment on lines
+945
to
+999
| pub fn iso_code(self) -> &'static str { | ||
| match self { | ||
| TokenNameLanguage::English => "en", | ||
| TokenNameLanguage::Arabic => "ar", | ||
| TokenNameLanguage::Bengali => "bn", | ||
| TokenNameLanguage::Burmese => "my", | ||
| TokenNameLanguage::Chinese => "zh", | ||
| TokenNameLanguage::Czech => "cs", | ||
| TokenNameLanguage::Dutch => "nl", | ||
| TokenNameLanguage::Farsi => "fa", | ||
| TokenNameLanguage::Filipino => "fil", | ||
| TokenNameLanguage::French => "fr", | ||
| TokenNameLanguage::German => "de", | ||
| TokenNameLanguage::Greek => "el", | ||
| TokenNameLanguage::Gujarati => "gu", | ||
| TokenNameLanguage::Hausa => "ha", | ||
| TokenNameLanguage::Hebrew => "he", | ||
| TokenNameLanguage::Hindi => "hi", | ||
| TokenNameLanguage::Hungarian => "hu", | ||
| TokenNameLanguage::Igbo => "ig", | ||
| TokenNameLanguage::Indonesian => "id", | ||
| TokenNameLanguage::Italian => "it", | ||
| TokenNameLanguage::Japanese => "ja", | ||
| TokenNameLanguage::Javanese => "jv", | ||
| TokenNameLanguage::Kannada => "kn", | ||
| TokenNameLanguage::Khmer => "km", | ||
| TokenNameLanguage::Korean => "ko", | ||
| TokenNameLanguage::Malay => "ms", | ||
| TokenNameLanguage::Malayalam => "ml", | ||
| TokenNameLanguage::Mandarin => "zh", | ||
| TokenNameLanguage::Marathi => "mr", | ||
| TokenNameLanguage::Nepali => "ne", | ||
| TokenNameLanguage::Oriya => "or", | ||
| TokenNameLanguage::Pashto => "ps", | ||
| TokenNameLanguage::Polish => "pl", | ||
| TokenNameLanguage::Portuguese => "pt", | ||
| TokenNameLanguage::Punjabi => "pa", | ||
| TokenNameLanguage::Romanian => "ro", | ||
| TokenNameLanguage::Russian => "ru", | ||
| TokenNameLanguage::Serbian => "sr", | ||
| TokenNameLanguage::Sindhi => "sd", | ||
| TokenNameLanguage::Sinhala => "si", | ||
| TokenNameLanguage::Somali => "so", | ||
| TokenNameLanguage::Spanish => "es", | ||
| TokenNameLanguage::Swahili => "sw", | ||
| TokenNameLanguage::Swedish => "sv", | ||
| TokenNameLanguage::Tamil => "ta", | ||
| TokenNameLanguage::Telugu => "te", | ||
| TokenNameLanguage::Thai => "th", | ||
| TokenNameLanguage::Turkish => "tr", | ||
| TokenNameLanguage::Ukrainian => "uk", | ||
| TokenNameLanguage::Urdu => "ur", | ||
| TokenNameLanguage::Vietnamese => "vi", | ||
| TokenNameLanguage::Yoruba => "yo", | ||
| } |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's find the TokenNameLanguage enum definition and understand the full context
cat -n src/ui/tokens/tokens_screen/mod.rs | head -100Repository: dashpay/dash-evo-tool
Length of output: 6083
🏁 Script executed:
# Search for the TokenNameLanguage enum definition
rg "enum TokenNameLanguage" -A 60Repository: dashpay/dash-evo-tool
Length of output: 3048
🏁 Script executed:
# Look for usages of iso_code() method
rg "iso_code\(\)" -B 3 -A 3Repository: dashpay/dash-evo-tool
Length of output: 613
🏁 Script executed:
# Check for existing tests in the file
rg "#\[test\]" src/ui/tokens/tokens_screen/mod.rs -A 10Repository: dashpay/dash-evo-tool
Length of output: 2006
🏁 Script executed:
# Verify file size and look at the full structure around lines 945-999
wc -l src/ui/tokens/tokens_screen/mod.rsRepository: dashpay/dash-evo-tool
Length of output: 104
🏁 Script executed:
# Get the iso_code() implementation and surrounding context
sed -n '920,1020p' src/ui/tokens/tokens_screen/mod.rsRepository: dashpay/dash-evo-tool
Length of output: 3975
🏁 Script executed:
# Search for tests specifically for iso_code
rg "iso_code" -B 5 -A 5Repository: dashpay/dash-evo-tool
Length of output: 1626
🏁 Script executed:
# Look at token_creator.rs to see how iso_code is used
cat -n src/ui/tokens/tokens_screen/token_creator.rs | grep -A 20 -B 20 "iso_code"Repository: dashpay/dash-evo-tool
Length of output: 1735
🏁 Script executed:
# Check if there's any validation or duplicate handling
rg "duplicate|collision|unique.*code|Chinese|Mandarin" src/ui/tokens/tokens_screen/Repository: dashpay/dash-evo-tool
Length of output: 1116
🏁 Script executed:
# Check DPP contract structure to understand if language codes are used as map keys
rg "token_names|language.*code" src/ui/tokens/tokens_screen/token_creator.rs -B 3 -A 3Repository: dashpay/dash-evo-tool
Length of output: 9028
🏁 Script executed:
# Verify if there's any contract serialization that might use codes as keys
rg "token_names" -B 5 -A 5 | head -50Repository: dashpay/dash-evo-tool
Length of output: 4620
Add unit tests for iso_code() and fix language code collisions
The iso_code() method has two issues:
-
Duplicate ISO codes: Both
ChineseandMandarinmap to"zh". The UI prevents duplicate enum variants from being selected, but a user can add bothChineseandMandarinto the same token, resulting in duplicate language codes sent to the contract. If the DPP contract keys token localizations by language code, this will cause data loss or rejection. -
Missing unit tests: Per coding guidelines (
**/*.rsrequires#[test]inline tests), theiso_code()method has no test coverage. Add tests to verify code mappings and detect duplicate codes.
Resolution options:
- Rename one variant (e.g.,
Chinese→StandardChinese,Mandarin→MandarinChinese) with distinct codes - Document that duplicate codes are intentional and validate this in the contract layer
- Remove one of the two variants if they're redundant for your use case
🤖 Prompt for AI Agents
In `@src/ui/tokens/tokens_screen/mod.rs` around lines 945 - 999, The iso_code()
mapping contains a duplicate ("zh") for TokenNameLanguage::Chinese and
TokenNameLanguage::Mandarin and lacks unit tests; update the mapping to
eliminate collisions (e.g., change the enum variant name or return value for
Mandari n/Chinese so each TokenNameLanguage variant returns a unique ISO string)
and add inline #[test]s that exercise TokenNameLanguage::iso_code() to assert
expected codes and detect duplicates (create tests that iterate all
TokenNameLanguage variants, assert their iso_code() values against expected map,
and assert uniqueness of returned codes). Ensure you update the
TokenNameLanguage enum reference (e.g., TokenNameLanguage::Chinese,
TokenNameLanguage::Mandarin) and add tests alongside iso_code() in the same
module to satisfy the repository’s Rust test guidelines.
Comment on lines
+1004
to
+1037
| fn update_selected_wallet(&mut self) { | ||
| if let (Some(qid), Some(key)) = (&self.selected_identity, &self.selected_key) { | ||
| self.selected_wallet = crate::ui::identities::get_selected_wallet( | ||
| qid, | ||
| None, | ||
| Some(key), | ||
| &mut self.token_creator_error_message, | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| fn ensure_wallet_unlocked(&mut self, ui: &mut Ui) -> bool { | ||
| if let Some(wallet) = &self.selected_wallet { | ||
| use crate::ui::components::wallet_unlock_popup::{ | ||
| try_open_wallet_no_password, wallet_needs_unlock, | ||
| }; | ||
|
|
||
| if let Err(e) = try_open_wallet_no_password(wallet) { | ||
| self.token_creator_error_message = Some(e); | ||
| } | ||
|
|
||
| if wallet_needs_unlock(wallet) { | ||
| ui.add_space(10.0); | ||
| ui.colored_label( | ||
| egui::Color32::from_rgb(200, 150, 50), | ||
| "Wallet is locked. Please unlock to continue.", | ||
| ); | ||
| ui.add_space(8.0); | ||
| if ui.button("Unlock Wallet").clicked() { | ||
| self.wallet_unlock_popup.open(); | ||
| } | ||
| return false; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Stop the flow when wallet access fails or is missing
ensure_wallet_unlocked currently records try_open_wallet_no_password errors but continues, and it silently allows selected_wallet == None. If signing requires wallet access, this will fail later. Consider short‑circuiting and surfacing the error immediately.
🛡️ Suggested guardrails
fn ensure_wallet_unlocked(&mut self, ui: &mut Ui) -> bool {
- if let Some(wallet) = &self.selected_wallet {
+ if let Some(wallet) = &self.selected_wallet {
use crate::ui::components::wallet_unlock_popup::{
try_open_wallet_no_password, wallet_needs_unlock,
};
if let Err(e) = try_open_wallet_no_password(wallet) {
self.token_creator_error_message = Some(e);
+ return false;
}
if wallet_needs_unlock(wallet) {
ui.add_space(10.0);
ui.colored_label(
egui::Color32::from_rgb(200, 150, 50),
"Wallet is locked. Please unlock to continue.",
);
ui.add_space(8.0);
if ui.button("Unlock Wallet").clicked() {
self.wallet_unlock_popup.open();
}
return false;
}
- }
+ } else {
+ self.token_creator_error_message =
+ Some("No wallet found for the selected identity/key".to_string());
+ return false;
+ }
true
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| fn update_selected_wallet(&mut self) { | |
| if let (Some(qid), Some(key)) = (&self.selected_identity, &self.selected_key) { | |
| self.selected_wallet = crate::ui::identities::get_selected_wallet( | |
| qid, | |
| None, | |
| Some(key), | |
| &mut self.token_creator_error_message, | |
| ); | |
| } | |
| } | |
| fn ensure_wallet_unlocked(&mut self, ui: &mut Ui) -> bool { | |
| if let Some(wallet) = &self.selected_wallet { | |
| use crate::ui::components::wallet_unlock_popup::{ | |
| try_open_wallet_no_password, wallet_needs_unlock, | |
| }; | |
| if let Err(e) = try_open_wallet_no_password(wallet) { | |
| self.token_creator_error_message = Some(e); | |
| } | |
| if wallet_needs_unlock(wallet) { | |
| ui.add_space(10.0); | |
| ui.colored_label( | |
| egui::Color32::from_rgb(200, 150, 50), | |
| "Wallet is locked. Please unlock to continue.", | |
| ); | |
| ui.add_space(8.0); | |
| if ui.button("Unlock Wallet").clicked() { | |
| self.wallet_unlock_popup.open(); | |
| } | |
| return false; | |
| } | |
| } | |
| fn ensure_wallet_unlocked(&mut self, ui: &mut Ui) -> bool { | |
| if let Some(wallet) = &self.selected_wallet { | |
| use crate::ui::components::wallet_unlock_popup::{ | |
| try_open_wallet_no_password, wallet_needs_unlock, | |
| }; | |
| if let Err(e) = try_open_wallet_no_password(wallet) { | |
| self.token_creator_error_message = Some(e); | |
| return false; | |
| } | |
| if wallet_needs_unlock(wallet) { | |
| ui.add_space(10.0); | |
| ui.colored_label( | |
| egui::Color32::from_rgb(200, 150, 50), | |
| "Wallet is locked. Please unlock to continue.", | |
| ); | |
| ui.add_space(8.0); | |
| if ui.button("Unlock Wallet").clicked() { | |
| self.wallet_unlock_popup.open(); | |
| } | |
| return false; | |
| } | |
| } else { | |
| self.token_creator_error_message = | |
| Some("No wallet found for the selected identity/key".to_string()); | |
| return false; | |
| } | |
| true | |
| } |
🤖 Prompt for AI Agents
In `@src/ui/tokens/tokens_screen/token_creator.rs` around lines 1004 - 1037,
ensure_wallet_unlocked currently records errors from try_open_wallet_no_password
and allows selected_wallet == None to continue; change it to short‑circuit and
surface errors immediately: inside ensure_wallet_unlocked, if
self.selected_wallet is None set self.token_creator_error_message to a clear
message and return false; if try_open_wallet_no_password(wallet) returns Err,
set self.token_creator_error_message to that error and return false (do not
proceed to wallet_needs_unlock); keep the existing UI flow for
wallet_needs_unlock/wallet_unlock_popup.open when the wallet exists and no open
error occurred. Use the function and field names ensure_wallet_unlocked,
try_open_wallet_no_password, wallet_needs_unlock, selected_wallet,
token_creator_error_message, and wallet_unlock_popup to locate and update the
logic.
Comment on lines
+1212
to
+1312
| fn parse_contract_keywords(&self) -> Result<Vec<String>, String> { | ||
| if self.contract_keywords_input.trim().is_empty() { | ||
| return Ok(Vec::new()); | ||
| } | ||
|
|
||
| self.contract_keywords_input | ||
| .split(',') | ||
| .map(|s| { | ||
| let trimmed = s.trim().to_string(); | ||
| if trimmed.len() < 3 || trimmed.len() > 50 { | ||
| Err(format!( | ||
| "Invalid contract keyword {}, keyword must be between 3 and 50 characters", | ||
| trimmed | ||
| )) | ||
| } else { | ||
| Ok(trimmed) | ||
| } | ||
| }) | ||
| .collect::<Result<Vec<String>, String>>() | ||
| } | ||
|
|
||
| fn parse_token_names( | ||
| &self, | ||
| contract_keywords: &mut Vec<String>, | ||
| ) -> Result<Vec<(String, String, String)>, String> { | ||
| if self.token_names_input.is_empty() { | ||
| return Err("Please enter a token name".to_string()); | ||
| } | ||
|
|
||
| let mut seen_languages = HashSet::new(); | ||
| for name_with_language in &self.token_names_input { | ||
| if seen_languages.contains(&name_with_language.2) { | ||
| return Err(format!( | ||
| "Duplicate token name language: {:?}", | ||
| name_with_language.1 | ||
| )); | ||
| } | ||
| seen_languages.insert(name_with_language.2); | ||
| } | ||
|
|
||
| let mut token_names = Vec::with_capacity(self.token_names_input.len()); | ||
| for name_with_language in &self.token_names_input { | ||
| if name_with_language.0.len() < 3 || name_with_language.0.len() > 50 { | ||
| return Err(format!( | ||
| "The name in {:?} must be between 3 and 50 characters", | ||
| name_with_language.2 | ||
| )); | ||
| } | ||
|
|
||
| if name_with_language.1.len() < 3 || name_with_language.1.len() > 50 { | ||
| return Err(format!( | ||
| "The plural form in {:?} must be between 3 and 50 characters", | ||
| name_with_language.2 | ||
| )); | ||
| } | ||
|
|
||
| token_names.push(( | ||
| name_with_language.0.clone(), | ||
| name_with_language.1.clone(), | ||
| name_with_language.2.iso_code().to_owned(), | ||
| )); | ||
|
|
||
| // are we searchable? | ||
| if name_with_language.3 { | ||
| contract_keywords.push(name_with_language.0.clone()); | ||
| } | ||
| } | ||
|
|
||
| Ok(token_names) | ||
| } | ||
|
|
||
| fn parse_decimals(&self) -> Result<u8, String> { | ||
| self.decimals_input | ||
| .parse::<u8>() | ||
| .map_err(|_| "Invalid decimal places amount".to_string()) | ||
| } | ||
|
|
||
| fn parse_base_supply(&self) -> Result<u64, String> { | ||
| self.base_supply_amount | ||
| .as_ref() | ||
| .map(|amount| amount.value()) | ||
| .ok_or_else(|| "Please enter a valid base supply amount".to_string()) | ||
| } | ||
|
|
||
| fn parse_max_supply(&self) -> Option<u64> { | ||
| self.max_supply_amount.as_ref().and_then(|amount| { | ||
| let value = amount.value(); | ||
| if value > 0 { Some(value) } else { None } | ||
| }) | ||
| } | ||
|
|
||
| fn parse_main_control_group(&self) -> Result<Option<u16>, String> { | ||
| if self.main_control_group_input.is_empty() { | ||
| return Ok(None); | ||
| } | ||
|
|
||
| self.main_control_group_input | ||
| .parse::<u16>() | ||
| .map(Some) | ||
| .map_err(|_| "Invalid main control group".to_string()) | ||
| } |
Contributor
There was a problem hiding this comment.
Fix duplicate-language error message to report the language
The error currently prints the plural string, which makes debugging confusing.
✏️ Suggested fix
- return Err(format!(
- "Duplicate token name language: {:?}",
- name_with_language.1
- ));
+ return Err(format!(
+ "Duplicate token name language: {}",
+ name_with_language.2.ui_label()
+ ));📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| fn parse_contract_keywords(&self) -> Result<Vec<String>, String> { | |
| if self.contract_keywords_input.trim().is_empty() { | |
| return Ok(Vec::new()); | |
| } | |
| self.contract_keywords_input | |
| .split(',') | |
| .map(|s| { | |
| let trimmed = s.trim().to_string(); | |
| if trimmed.len() < 3 || trimmed.len() > 50 { | |
| Err(format!( | |
| "Invalid contract keyword {}, keyword must be between 3 and 50 characters", | |
| trimmed | |
| )) | |
| } else { | |
| Ok(trimmed) | |
| } | |
| }) | |
| .collect::<Result<Vec<String>, String>>() | |
| } | |
| fn parse_token_names( | |
| &self, | |
| contract_keywords: &mut Vec<String>, | |
| ) -> Result<Vec<(String, String, String)>, String> { | |
| if self.token_names_input.is_empty() { | |
| return Err("Please enter a token name".to_string()); | |
| } | |
| let mut seen_languages = HashSet::new(); | |
| for name_with_language in &self.token_names_input { | |
| if seen_languages.contains(&name_with_language.2) { | |
| return Err(format!( | |
| "Duplicate token name language: {:?}", | |
| name_with_language.1 | |
| )); | |
| } | |
| seen_languages.insert(name_with_language.2); | |
| } | |
| let mut token_names = Vec::with_capacity(self.token_names_input.len()); | |
| for name_with_language in &self.token_names_input { | |
| if name_with_language.0.len() < 3 || name_with_language.0.len() > 50 { | |
| return Err(format!( | |
| "The name in {:?} must be between 3 and 50 characters", | |
| name_with_language.2 | |
| )); | |
| } | |
| if name_with_language.1.len() < 3 || name_with_language.1.len() > 50 { | |
| return Err(format!( | |
| "The plural form in {:?} must be between 3 and 50 characters", | |
| name_with_language.2 | |
| )); | |
| } | |
| token_names.push(( | |
| name_with_language.0.clone(), | |
| name_with_language.1.clone(), | |
| name_with_language.2.iso_code().to_owned(), | |
| )); | |
| // are we searchable? | |
| if name_with_language.3 { | |
| contract_keywords.push(name_with_language.0.clone()); | |
| } | |
| } | |
| Ok(token_names) | |
| } | |
| fn parse_decimals(&self) -> Result<u8, String> { | |
| self.decimals_input | |
| .parse::<u8>() | |
| .map_err(|_| "Invalid decimal places amount".to_string()) | |
| } | |
| fn parse_base_supply(&self) -> Result<u64, String> { | |
| self.base_supply_amount | |
| .as_ref() | |
| .map(|amount| amount.value()) | |
| .ok_or_else(|| "Please enter a valid base supply amount".to_string()) | |
| } | |
| fn parse_max_supply(&self) -> Option<u64> { | |
| self.max_supply_amount.as_ref().and_then(|amount| { | |
| let value = amount.value(); | |
| if value > 0 { Some(value) } else { None } | |
| }) | |
| } | |
| fn parse_main_control_group(&self) -> Result<Option<u16>, String> { | |
| if self.main_control_group_input.is_empty() { | |
| return Ok(None); | |
| } | |
| self.main_control_group_input | |
| .parse::<u16>() | |
| .map(Some) | |
| .map_err(|_| "Invalid main control group".to_string()) | |
| } | |
| fn parse_contract_keywords(&self) -> Result<Vec<String>, String> { | |
| if self.contract_keywords_input.trim().is_empty() { | |
| return Ok(Vec::new()); | |
| } | |
| self.contract_keywords_input | |
| .split(',') | |
| .map(|s| { | |
| let trimmed = s.trim().to_string(); | |
| if trimmed.len() < 3 || trimmed.len() > 50 { | |
| Err(format!( | |
| "Invalid contract keyword {}, keyword must be between 3 and 50 characters", | |
| trimmed | |
| )) | |
| } else { | |
| Ok(trimmed) | |
| } | |
| }) | |
| .collect::<Result<Vec<String>, String>>() | |
| } | |
| fn parse_token_names( | |
| &self, | |
| contract_keywords: &mut Vec<String>, | |
| ) -> Result<Vec<(String, String, String)>, String> { | |
| if self.token_names_input.is_empty() { | |
| return Err("Please enter a token name".to_string()); | |
| } | |
| let mut seen_languages = HashSet::new(); | |
| for name_with_language in &self.token_names_input { | |
| if seen_languages.contains(&name_with_language.2) { | |
| return Err(format!( | |
| "Duplicate token name language: {}", | |
| name_with_language.2.ui_label() | |
| )); | |
| } | |
| seen_languages.insert(name_with_language.2); | |
| } | |
| let mut token_names = Vec::with_capacity(self.token_names_input.len()); | |
| for name_with_language in &self.token_names_input { | |
| if name_with_language.0.len() < 3 || name_with_language.0.len() > 50 { | |
| return Err(format!( | |
| "The name in {:?} must be between 3 and 50 characters", | |
| name_with_language.2 | |
| )); | |
| } | |
| if name_with_language.1.len() < 3 || name_with_language.1.len() > 50 { | |
| return Err(format!( | |
| "The plural form in {:?} must be between 3 and 50 characters", | |
| name_with_language.2 | |
| )); | |
| } | |
| token_names.push(( | |
| name_with_language.0.clone(), | |
| name_with_language.1.clone(), | |
| name_with_language.2.iso_code().to_owned(), | |
| )); | |
| // are we searchable? | |
| if name_with_language.3 { | |
| contract_keywords.push(name_with_language.0.clone()); | |
| } | |
| } | |
| Ok(token_names) | |
| } | |
| fn parse_decimals(&self) -> Result<u8, String> { | |
| self.decimals_input | |
| .parse::<u8>() | |
| .map_err(|_| "Invalid decimal places amount".to_string()) | |
| } | |
| fn parse_base_supply(&self) -> Result<u64, String> { | |
| self.base_supply_amount | |
| .as_ref() | |
| .map(|amount| amount.value()) | |
| .ok_or_else(|| "Please enter a valid base supply amount".to_string()) | |
| } | |
| fn parse_max_supply(&self) -> Option<u64> { | |
| self.max_supply_amount.as_ref().and_then(|amount| { | |
| let value = amount.value(); | |
| if value > 0 { Some(value) } else { None } | |
| }) | |
| } | |
| fn parse_main_control_group(&self) -> Result<Option<u16>, String> { | |
| if self.main_control_group_input.is_empty() { | |
| return Ok(None); | |
| } | |
| self.main_control_group_input | |
| .parse::<u16>() | |
| .map(Some) | |
| .map_err(|_| "Invalid main control group".to_string()) | |
| } |
🤖 Prompt for AI Agents
In `@src/ui/tokens/tokens_screen/token_creator.rs` around lines 1212 - 1312, The
duplicate-language error prints the plural string (name_with_language.1) instead
of the language; in parse_token_names replace the incorrect format argument in
the duplicate check (format!("Duplicate token name language: {:?}",
name_with_language.1)) with the language identifier (e.g., name_with_language.2
or name_with_language.2.iso_code()) so the message reports the actual language;
keep the rest of the seen_languages logic intact.
pauldelucia
approved these changes
Feb 5, 2026
Member
|
See CodeRabbit comments |
Member
Author
I don't seem to agree with any of them |
lklimek
added a commit
that referenced
this pull request
Feb 11, 2026
* feat: wallet unlock on wallet screen (#415) * refactor: Amount type and AmountInput component (#417) * feat: amount input, first building version * test(amount): fixed tests * chore: I think final * chore: my_tokens display correct amount * chore: transfer tokens update * chore: hide unit on rewards estimate column * chore: two new helper methods * chore: I think finals * cargo fmt * feat: component trait * impl Component for AmountInput * chore: updated component trait * chore: update for egui enabled state mgmt * doc: component design pattern doc * chore: component design pattern continued * chore: amount improvements * chore: copilot review * chore: amount improvements * backport: amount component from * chore: fix imports * chore: refactor * chore: futher refactor * chore: further refactor based on feedback * doc: simplified component design pattern description * chore: peer review * doc: update docs * chore: amount input * test: run tests using github actions and fix failing tests (#422) * fix: failing tests * gha: run tests * fix: tests fail due to lack of .env file * fix: incorrect decimals handling on token create, mint and burn screens (#419) * feat: amount input, first building version * test(amount): fixed tests * chore: I think final * chore: my_tokens display correct amount * chore: transfer tokens update * chore: hide unit on rewards estimate column * chore: two new helper methods * chore: I think finals * cargo fmt * feat: component trait * impl Component for AmountInput * chore: updated component trait * chore: update for egui enabled state mgmt * doc: component design pattern doc * chore: component design pattern continued * chore: amount improvements * chore: copilot review * chore: amount improvements * refactor: mint and burn token screens use AmountInput * chore: use AmountInput on token creator screen * fix: burn error handling * feat: errors displayed in the AmountInput component * fix: vertical align of amount input * backport: amount component from * chore: fix imports * chore: refactor * chore: futher refactor * chore: further refactor based on feedback * doc: simplified component design pattern description * chore: peer review * doc: update docs * chore: amount input * chore: fixes after merge * chore: self-review * feat: amout set decimal places + rename label => with_label * refactor: amount input init on token screen * chore: fix token creator layout * chore: format base amount with leading zeros in confirmation * chore: base supply 0 by default * feat: add network field to identity structures (#423) * feat: add network field to identity structures * fix * feat: add display for private key in both WIF and Hex formats (#424) * feat: add display for private key in both WIF and Hex formats * fix: display private keys as normal text and depend on color theme --------- Co-authored-by: pauldelucia <pauldelucia2@gmail.com> * feat: allow setting zmq uri in .env (#425) * feat: allow setting ZMQ URI * chore: rename zmq_endpoint to core_zmq_endpoint * fix: failing test in token screen needed update * fix: update CI to use rust version 1.88 to match rust-toolchain * feat: better display in key selector (#429) * refactor: unified confirmation dialog (#413) * refactor: unified alert window * chore: update CLAUDE to create reusable components whenever appropriate * feat: correct confirm dialog on set token price screen * chore: remove callbacks which are overkill * chore: cargo fmt * chore: doctest fix * chore: impl Component for ConfirmationDialog * chore: use WidgetText * feat: Add Escape key handling for confirmation dialog * chore: button inactive when in progress * chore: fixes after merge * chore: some theme improvements * fmt and visual appeal --------- Co-authored-by: pauldelucia <pauldelucia2@gmail.com> * feat: nicer contract chooser panel (#426) * feat: nicer contract chooser panel * fmt * clippy * fix: token purchasability was not refreshing unless app restart (#432) * fix: token action buttons alignment * feat: nicer expanding tabs in token creator (#431) * feat: nicer expanding tabs in token creator * fix * feat: implement new ConfirmationDialog component throughout app (#430) * feat: implement new ConfirmationDialog component throughout app * fix: remove backup files * fix: confirmation dialog on withdrawal screen always showing "loading" * feat: Dash Masternode List and Quorum Viewer (#428) * a lot of work on DML viewer * more work * more work * more work * more work * more work * more work * more work * more work * ui improvements * ui improvements * optimizations * fast start * more work * more work * more work * fmt * much more work * fixes * updates * fix * fmt * revert * update for dashcore 40 * params for testnet * added testnet diff * fixes * clippy * more clippy * fixes * clean UI * use backend tasks * backend messages * coderabbit suggestions to add timeouts and prevent infinite loops * transient and fatal errors * update dash core configs for testnet * fmt * fix timeout * fix h-3 error * clear state when switching networks --------- Co-authored-by: pauldelucia <pauldelucia2@gmail.com> * chore: bump version to 1.0.0-dev (#439) The 1.0-dev branch builds were still reporting as 0.9.0 * feat: add left panel button labels and create contract subscreen chooser panel (#441) * feat: add left panel button labels and create contract subscreen chooser panel * fmt * feat: clarify identity index description for identity creation * fix: screen button labels display hard to see in dark mode * feat: left panel scroll (#443) * feat: left panel scroll * clippy * feat: add existing identity by wallet + identity index (#444) * feat: add existing identity by wallet + identity index * fmt * remove logging * update derivation index label * add robustness * fix: screen button labels display hard to see in dark mode * feat: left panel scroll (#443) * feat: left panel scroll * clippy * feat: load all identities up to an index * clippy * fix * feat: remove wallet (#445) * feat: remove wallet * clippy * Clarify wallet removal warning message Updated warning message for wallet removal to clarify that keys will no longer work unless the wallet is re-imported. * fix: identity creation and top-up via QR code handling (#447) * fix: identity creation handling * cleanup * cleanup * fix identity topup too * remove note * fix: keyword search required new platform version plus error handling and UI updates (#449) * fix: keyword search not displaying errors * update platform version and keyword search cleanup * fix * fix: handle decimals and fix schedules on price and purchase screens (#412) * fix: inactive button on set price group action * chore: apply review feedback * refactor: use token amount input * chore: update AmountInput * chore: tiered pricing * chore: direct purchase * chore: remove total agreed price * chore: max amount input defaults to max_credits * fmt * fix * clippy --------- Co-authored-by: pauldelucia <pauldelucia2@gmail.com> Co-authored-by: Claude <noreply@anthropic.com> * fix: showing used asset locks as unused (#448) * chore: remove unused task sender * chore: update to Platform V10 * feat: GroveSTARK ZK proofs (#450) * works * works * fix * ok * ok * ok * ok * ok * fix verification message showing in generation screen * remove advanced settings. set default 16 grinding bits and 128 bit security * ok * lock * ok * clippy * fmt * clippy and fmt * pin grovestark dep * fix * ok * clippy * rename file * remove ProofData * cleanup * fix * rename GroveStark to GroveSTARK * rename zk_proofs_screen to grovestark_screen * rename ZKProofs tool subscreen to GroveSTARK * move grovestark prover to model * rename ContractsDashpayComingSoon to ContractsDashpay * rename ContractsDashpay to Dashpay * rename dashpay stuff * fixes * ok * update grovestark rev * update * chore: update grovestark rev * chore: update platform to v2.1.2 * feat: derive keys from loaded wallets when loading identity by ID (#446) * feat: derive keys from loaded wallets when loading identity * clippy * chore: update platform version * ok * cleanup ui * cleanup ui * set max index search to 30 * set max const * k * fix: wallet screen not updating wallets after network change (#451) * fix: wallet screen not updating wallets after network change * ui improvement * clippy * fix: some document actions were showing error when it was success (#452) * fix: some document actions were showing error when it was success * add space at bottom * feat: wallet unlock button (#459) * fix: scrollable unused asset locks on identity creation (#460) * fix: no error display when trying to import a wallet twice on different networks (#466) * fix: no error display when trying to import a wallet twice on different networks * feat: add waiting for valid seed phrase message * fix * fix: logging should interpret RUST_LOG env variable (#467) * feat: signed dmg for mac (#437) * feat: signed mac binaries and dmg * fix * fix * extra check * app bundle * fix * fix icon * feat: simplify icon padding to 3% for correct sizing * ok * ok * fmt * fix: split dmgs into arm64 and x86 instead of universal * cleanup * fmt * fix naming * ok * fix * disk space fix * fix * fix * fix attempt * fix: enhance disk space cleanup for macOS DMG creation - Add more aggressive cleanup of Xcode caches and derived data - Remove additional Cargo build artifacts (.rlib, .d files) - Clean system-level caches to free maximum space - Add cleanup step for both ARM64 and x86_64 macOS builds - Remove temporary icon files after app bundle creation This should resolve the "No space left on device" error during DMG creation on GitHub Actions runners. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * macos-latest * latest for arm too * revert * re-revert * clear cache * fix * cleanup * try large * omg * apply suggestion * cleanup * fix * fix * fix --------- Co-authored-by: Claude <noreply@anthropic.com> * feat: HD wallet system, DashPay integration, SPV support, and more (#464) * feat: dashpay * ok * ok * remove doc * ok * ok * database * ok * fix: use proper BackendTaskSuccessResults rather than Message * fmt and clippy * remove dashpay dip file * logo and cleanup * fix top panel spacing * ui stuff * fmt * dip 14 * image fetching * some fixes * cleaning up * todos * feat: SPV phase 1 (#440) * feat: spv in det * ui * progress bars * working progress updates * fmt * fast sync * add back progress monitoring * back to git dep * newer dashcore version * deduplication * spv context provider * fixes * small fix * clippy fixes * fixes --------- Co-authored-by: Quantum Explorer <quantum@dash.org> * feat: spv progress bars and sync from genesis when wallets are loaded (#454) * feat: spv progress bars * feat: start from 0 if syncing with wallets * clippy * fmt * update * fixes * fix: add sdk features * feat: add accounts and transactions to wallet screen * clippy * fmt * fix: dashpay database table initialization was hanging on new db (#463) * fix: display stuff * add accounts and much progress * feat: transaction history in wallet * clippy * ok * feat: hd wallet * send tx via wallet and wallet lock/unlock * update to PeerNetworkManager * ok * ok * ok * fmt * clippy * clippy * feat: clear SPV data button * fix: switch from dash core rpc to spv mode * feat: switch to DashSpvClientInterface * clean spv button fix * feat: send from wallet screen * feat: platform addresses * feat: platform address transitions * feat: platform address transitions * feat: move dashpay screen to top level * platform addresses sdk * remove async context provider fn * lock * update for new sdk with addresses and handle sdk result data * chore: update grovestark dependency * chore: update dash-sdk rev * fmt * remove elliptic curves patch * clippy * feat: use BackendTaskSuccessResult variants instead of Message(String) * fmt * clippy * update DIP18 implementation, fixes and some features around wallets and PAs * fix * wallet unlock on wallet screen * info popup component * small fixes * wallet unlock component * fix startup panic * welcome screen and dashpay stuff * cargo fix * cargo fmt * chore: update deps to use most recent dash-sdk * simplify welcome screen and move spv storage clear to advanced settings * default connect to peers via SPV DNS seeds * fix: exit app without waiting * fix error message and reverse quorum hash on lookup * fmt * settings to turn off spv auto sync * clippy * work on getting started flow * AddressProvider stuff * address sync stuff * many fixes all in one * fix * many fixes * fixes * amount input stuff * alignment in identity create screen for adding keys * more fixes * many improvements * simple token creator, word count selection for wallet seed phrases, more * fix: platform address info storage * feat: generate platform addresses and address sync post-checkpoint * many things * chore: update to recent changes in platform * docs: added few lines about .env file * fix: banned addresses and failure during address sync * fix: updates for new platform and fee estimation * fix: only take PA credits after checkpoint * feat: fee estimation and display * feat: fee estimation follow-up * more on fee displays * fix: proof logs in data contract create * fix: white on white text for fee estimation display * fix: always start as closed for advanced settings dropdown in settings screen * fix: hard to see data contracts in the register contract screen * fix: document create screen scroll * fix: fee estimations accuracy * fmt * clippy auto fixes * clippy manual fixes and pin dash-sdk dep * fix failing tests * fmt * fix: update rust toolchain to 1.92 * refactor: hide SPV behind dev mode * feat: warning about SPV being experimental * cleanup based on claude review * fmt * cleanup based on another claude review * fix: kittest failing * fix: remove fee result display in success screens and clean up dashpay avatar display * dashpay fixes and platform address fixes * refactor: move some AppContext functions to backend_task module * clippy * clippy * fix: refresh mode alignment in wallet screen and fmt * fix: failing test due to test_db issue * fix: dashpay avatar loading slow * fix: add rocksdb deps to ci workflow * fix: free up disk space in ci workflow * fix: display warning when partial wallet refresh success occurs * fix: propogate error for terminal balance sync * feat: more aggressive disk cleanup in ci workflow --------- Co-authored-by: Quantum Explorer <quantum@dash.org> Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com> Co-authored-by: Ivan Shumkov <ivanshumkov@gmail.com> * feat: comprehensive test coverage implementation (#481) * feat: comprehensive test suite * fmt * fix: cannot create identity from address due to wrong identity id (#470) * feat: dashpay * ok * ok * remove doc * ok * ok * database * ok * fix: use proper BackendTaskSuccessResults rather than Message * fmt and clippy * remove dashpay dip file * logo and cleanup * fix top panel spacing * ui stuff * fmt * dip 14 * image fetching * some fixes * cleaning up * todos * feat: SPV phase 1 (#440) * feat: spv in det * ui * progress bars * working progress updates * fmt * fast sync * add back progress monitoring * back to git dep * newer dashcore version * deduplication * spv context provider * fixes * small fix * clippy fixes * fixes --------- Co-authored-by: Quantum Explorer <quantum@dash.org> * feat: spv progress bars and sync from genesis when wallets are loaded (#454) * feat: spv progress bars * feat: start from 0 if syncing with wallets * clippy * fmt * update * fixes * fix: add sdk features * feat: add accounts and transactions to wallet screen * clippy * fmt * fix: dashpay database table initialization was hanging on new db (#463) * fix: display stuff * add accounts and much progress * feat: transaction history in wallet * clippy * ok * feat: hd wallet * send tx via wallet and wallet lock/unlock * update to PeerNetworkManager * ok * ok * ok * fmt * clippy * clippy * feat: clear SPV data button * fix: switch from dash core rpc to spv mode * feat: switch to DashSpvClientInterface * clean spv button fix * feat: send from wallet screen * feat: platform addresses * feat: platform address transitions * feat: platform address transitions * feat: move dashpay screen to top level * platform addresses sdk * remove async context provider fn * lock * update for new sdk with addresses and handle sdk result data * chore: update grovestark dependency * chore: update dash-sdk rev * fmt * remove elliptic curves patch * clippy * feat: use BackendTaskSuccessResult variants instead of Message(String) * fmt * clippy * update DIP18 implementation, fixes and some features around wallets and PAs * fix * wallet unlock on wallet screen * info popup component * small fixes * wallet unlock component * fix startup panic * welcome screen and dashpay stuff * cargo fix * cargo fmt * chore: update deps to use most recent dash-sdk * simplify welcome screen and move spv storage clear to advanced settings * default connect to peers via SPV DNS seeds * fix: exit app without waiting * fix error message and reverse quorum hash on lookup * fmt * settings to turn off spv auto sync * clippy * work on getting started flow * AddressProvider stuff * address sync stuff * many fixes all in one * fix * many fixes * fixes * amount input stuff * alignment in identity create screen for adding keys * more fixes * many improvements * simple token creator, word count selection for wallet seed phrases, more * fix: platform address info storage * feat: generate platform addresses and address sync post-checkpoint * many things * fix: cannot create identity from address * chore: update to recent changes in platform * docs: added few lines about .env file * fix: banned addresses and failure during address sync * fix: updates for new platform and fee estimation * fix: only take PA credits after checkpoint * feat: fee estimation and display * feat: fee estimation follow-up * chore: fix build * chore: correct platform revision * refactor: don't query for nonce when creating identity * more on fee displays * fix: proof logs in data contract create * fix: white on white text for fee estimation display * fix: always start as closed for advanced settings dropdown in settings screen * fix: hard to see data contracts in the register contract screen * fix: document create screen scroll * fix: fee estimations accuracy * fmt * clippy auto fixes * clippy manual fixes and pin dash-sdk dep * fix failing tests * fmt * fix: update rust toolchain to 1.92 * refactor: hide SPV behind dev mode * feat: warning about SPV being experimental * fix: platform nonces not updated in sync * chore: cargo fmt * deps: update platform repo * chore: clippy and rabbit * chore: rabbit review * chore: enforce address networ with require_network() * cleanup based on claude review * fmt * cleanup based on another claude review * fix: kittest failing * fix: remove fee result display in success screens and clean up dashpay avatar display * dashpay fixes and platform address fixes * deps: update platform repo * chore: fixes after merge * refactor: move some AppContext functions to backend_task module * clippy * clippy * fix: refresh mode alignment in wallet screen and fmt * chore: fmt * fmt --------- Co-authored-by: pauldelucia <pauldelucia2@gmail.com> Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com> Co-authored-by: Quantum Explorer <quantum@dash.org> Co-authored-by: Ivan Shumkov <ivanshumkov@gmail.com> * docs: add CLAUDE.md for Claude Code guidance (#484) Adds documentation to help Claude Code (claude.ai/code) work effectively with this codebase, including build commands, testing instructions, architecture overview, and UI component patterns. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * build: update dash-sdk to use rust-dashcore v0.42-dev (#483) * build: update dash-sdk to use rust-dashcore v0.41.0 Updates dash-sdk dependency to rev 7b2669c0b250504a4cded9e2b9e78551583e6744 which includes rust-dashcore v0.41.0. Breaking changes addressed: - WalletBalance: confirmed field renamed to spendable(), fields now methods - WalletManager::new() now requires Network argument - import_wallet_from_extended_priv_key() no longer takes network argument - current_height() no longer takes network argument - RequestSettings: removed max_decoding_message_size field - sync_to_tip() removed - initial sync now handled by monitor_network() Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: apply cargo fmt Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * clippy --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: pauldelucia <pauldelucia2@gmail.com> * feat: hint text next to withdrawal destination input in dev mode with advanced options and owner key * feat: implement asset lock creation and detail screens (#418) * feat: implement asset lock creation and detail screens * clippy fix * some fixes * fix: ui cleanup and backend fixes * fix: clippy * feat: tests * fix: remove identity index selector for top ups * fmt * refactor: use `AmountInput` component * fixes * fix: clippy --------- Co-authored-by: pauldelucia <pauldelucia2@gmail.com> * fix: dev mode wouldnt toggle in left panel when unchecked in settings if config load failed (#488) * fix: force Core RPC mode on app start if not in dev mode (#489) * fix: display WIF format for manually added private keys (#496) * fix: display WIF format for manually added private keys Externally loaded identities with manually added private keys now show both WIF and hex formats, matching the display for wallet-derived keys. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * clippy * fmt --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: pauldelucia <pauldelucia2@gmail.com> * fix: security level validation for add key screen (#494) * fix: auto-set security level based on key purpose in add key screen When selecting a key purpose, automatically set the appropriate security level and restrict available options: ENCRYPTION/DECRYPTION only allow MEDIUM, TRANSFER only allows CRITICAL, and AUTHENTICATION allows CRITICAL/HIGH/MEDIUM. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: disable security level dropdown when only one option is valid Visually indicate to the user that the security level is fixed by the protocol for certain key purposes (ENCRYPTION, DECRYPTION, TRANSFER). Adds a hover tooltip explaining why the dropdown is disabled. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: remove redundant `contract_bounds_enabled` check for `has_multiple_security_levels` bool * fmt --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: pauldelucia <pauldelucia2@gmail.com> * fix: identity registration default key was using wrong `ContractBounds` (#487) * fix: identity registration default key was using wrong ContractBounds * feat: add tests * fmt * doc: update key descriptions * feat: add coderabbit configuration file * fix: document actions were auto selecting master keys but shouldnt (#493) * fix: top up with QR was validating against wallet max balance (#492) * fix: view platform address popup showing wrong address format (#500) * fix: view platform address popup showing wrong address format * fix: use helper * feat: update sdk v3.0.1 hotfix.1 (#503) * chore: update dash-sdk to v3.0.1-hotfix.1 Updates dash-sdk to v3.0.1-hotfix.1 to match testnet. Breaking API changes addressed: - WalletBalance.unconfirmed and .total are now fields instead of methods - RequestSettings now requires max_decoding_message_size field Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fmt --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: ensure dev mode is off and spv sync off for new users (#504) * fix: ensure dev mode is off and spv sync off for new users * fix tests * fix * fix: update platform address prefix from dashevo to evo (#505) * fix: update platform address prefix from dashevo to evo Update address detection and UI hints to use the new shorter platform address prefixes (evo1/tevo1) instead of the old format (dashevo1/tdashevo1) to match SDK v3.0.1 changes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: validate platform address network matches app network Add network validation when parsing Bech32m Platform addresses to ensure the address network prefix matches the app's configured network, showing a descriptive error on mismatch. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fmt --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: platform address balance doubling after transfer and refresh (#502) * fix: platform address balance doubling after transfer and refresh * fix * feat: add fee multiplier caching and use it across all UI screens (#506) * feat: add fee multiplier caching and use it across all UI screens - Add fee_multiplier_permille support to PlatformFeeEstimator - Add fee multiplier caching in AppContext with getter/setter - Add fee_estimator() helper method on AppContext - Cache the fee multiplier when epoch info is fetched - Display note when fee multiplier cache is updated - Update all UI screens to use app_context.fee_estimator() Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fmt * fix: apply fee multiplier to all estimation functions Update all estimate_* functions to apply the fee multiplier to the combined total (storage + processing/registration) rather than to individual components, ensuring consistent fee calculation across all state transition types per the Dash Platform spec. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: reuse fee_estimator instance in token screens Avoid duplicate construction and keep consistent multiplier snapshot within the frame by reusing the existing fee_estimator variable. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: use DEFAULT_FEE_MULTIPLIER_PERMILLE constant in AppContext Keep the AppContext default in sync with the estimator's canonical value instead of hardcoding 1000. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: take from multiple platform addresses in simple send flow (#501) * fix: take from multiple platform addresses in simple send flow * address selection algorithm * fix * fix: fee payer index lookup * cleanup * fix: use PlatformFeeEstimator for address transfer fees - Replace custom fee calculation with PlatformFeeEstimator - Simplify allocation logic by calculating fee upfront - Use 20% safety buffer on fee estimates - Remove complex iterative allocation loop Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fmt * Add fee deficit check in platform address allocation The fee payer must have enough remaining balance after their contribution to cover the transaction fee. This change calculates the fee deficit (if fee payer's remaining balance < estimated fee) and adds it to the shortfall, preventing impossible sends from being attempted. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Use actual input count for fee estimation in error messages Changed estimate_platform_fee calls to use addresses_available (the actual number of available inputs) instead of MAX_PLATFORM_INPUTS. This provides more accurate fee estimates and max sendable amounts in the error messages when transactions exceed available balance. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Filter destination address from preview allocation The preview allocation now parses the destination platform address and passes it to allocate_platform_addresses, ensuring the destination is never shown as an input source. This matches the behavior of the actual send logic. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fmt * Filter destination from max calculation and improve warning message The max amount calculation now excludes the destination address, matching the allocation logic. This prevents showing an inflated max when the destination is one of your own addresses. Also improved the warning message to distinguish between exceeding the address limit vs insufficient balance (including fees). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fmt * feat: use cached fee multiplier in send_screen Update estimate_platform_fee and allocate_platform_addresses to accept a PlatformFeeEstimator parameter, allowing the send screen to use the cached network fee multiplier from app_context.fee_estimator(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address review comments in send_screen - Add early return for empty sorted_addresses in allocate_platform_addresses - Use safe string slicing in render_platform_source_breakdown to avoid panic - Remove duplicate doc comment Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: prevent platform address balance doubling after internal updates (#507) * fix: prevent platform address balance doubling after internal updates Adds last_full_sync_balance column to track the balance checkpoint for terminal sync pre-population, separate from the current balance. Key changes: - Add DB migration (v26) for last_full_sync_balance column - Sync operations update last_full_sync_balance for next sync baseline - Internal updates (after transfers) preserve last_full_sync_balance - Terminal sync pre-populates with last_full_sync_balance, applies AddToCredits correctly without double-counting This fixes the scenario where: 1. Transfer completes, balance updated internally 2. App restarts, refresh triggers terminal sync 3. Same AddToCredits was being re-applied because the pre-population baseline wasn't distinguishing between sync and internal updates Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: fix docblocks for is_sync_operation and last_full_sync_balance - Remove duplicate/obsolete is_full_sync wording from set_platform_address_info - Update last_full_sync_balance field doc to accurately describe when it's updated (during syncs) vs preserved (during internal updates) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: preserve last_full_sync_balance when removing duplicate address entries Search for last_full_sync_balance from any canonical-equivalent entry BEFORE removing duplicates, so the value isn't lost when the existing entry has a different Address representation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: fetch fresh nonces from platform for identity creation (#509) When creating an identity with Platform Address funding, the cached nonce could be stale (terminal-only sync only updates balance, not nonce). This caused "Invalid address nonce" errors. Now fetches fresh nonces from platform using AddressInfo::fetch_many() before identity creation. Note: The SDK's put_with_address_funding requires caller-provided nonces, unlike transfer_address_funds which handles nonces internally. This inconsistency should be addressed in the SDK. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: don't auto-generate platform address when opening receive dialog (#508) Use platform_addresses() which checks watched_addresses for derived Platform addresses, instead of only checking platform_address_info which only contains synced addresses with balances. A new address is now only generated if there are truly no Platform addresses derived for the wallet, not just because they haven't been synced yet. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: show N/A for UTXOs and Total Received columns on Platform addresses (#510) Platform addresses don't have UTXOs (they have credits on Platform layer) and we don't track historical received amounts for them. Showing 0 was misleading - N/A is more accurate. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: reserve fees when using max button for platform address identity funding (#511) * fix: reserve fees when using max button for platform address identity funding When clicking the max button to fund identity creation or top-up from a platform address, the full balance was used without reserving room for transaction fees, causing "Insufficient combined address balances" errors. Changes: - Subtract estimated fee from max amount in identity creation screen - Subtract estimated fee from max amount in identity top-up screen - Fix fee estimation to use identity_create_asset_lock_cost (200M credits) instead of address_funding_asset_lock_cost (50M credits) - Add storage-based fees to identity creation/top-up fee estimates - Add new estimate_identity_topup_from_addresses() for platform address top-ups - Add 20% safety buffer to account for fee variability - Show hint explaining fee reservation when max is used Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: fix docstrings to correctly state 20% safety buffer The docstrings incorrectly stated 10% safety buffer while the code applies 20% via total / 5. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * Release SPV storage lock on shutdown (#517) * Fix dark mode text colors (#515) * Fix dark mode text and borders * style: apply cargo fmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: invalid min amount when transferring funds (#523) * fix: invalid min amount when transferring funds * chore: rabbit's feedback * chore: update bincode to 2.0.1, dash-sdk to v3.1-dev, and grovestark (#526) * chore: update bincode to 2.0.1, dash-sdk to v3.1-dev, and grovestark - Update bincode from 2.0.0-rc.3 to 2.0.1 - Update dash-sdk to latest v3.1-dev (98a0ebec) - Update grovestark to a70bdb1a - Fix Decode/BorrowDecode implementations for bincode 2.0.1 API changes Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: migrate to using dashpay/grovestark --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: pasta <pasta@dashboost.org> * feat: use DAPI instead of Core RPC for historical asset lock transaction info (#528) Replace core_client.get_raw_transaction_info() calls with a new get_transaction_info_via_dapi() function that queries transaction status via DAPI gRPC. This removes the dependency on a local Core RPC node for checking whether asset lock transactions have been chainlocked, which is needed for identity registration, top-up, and platform address funding from asset locks. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: not enough balance to pay a fee in platform to core transfers (#513) * fix: fee estimation for AddressCreditWithdrawalTransition * chore: max button * refactor: remove redundant code * chore: better hint in platform-to-core * Refactor token creator helpers (#518) * refactor(tokens): simplify token creator helpers * style: cargo fmt * Simplify wallets UI helpers and send flow (#519) * Simplify wallets UI helpers and send flow * Fix wallets screen helper placement * Fix refresh_on_arrival borrow * Stabilize token UI tests config * Simplify wallet send address type helper * fix: handle RegisteredTokenContract result to clear token creation spinner (#529) The backend task returned RegisteredTokenContract on success but the tokens screen had no handler for it, causing the spinner to spin forever. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: build fails for windows target (#527) * fix: build fails for windows target * build: only create a release when tag is set * chore: remove redundant settings from release.yml * doc: windows requirements * fix: windows icon * build: change grovestark revision * chore: fmt * fix: don't open console window on windows * build: grovestark recent commit * fix: critical wallet bugs (GH#522, GH#476, GH#478, GH#85) (#534) * fix: auto-refresh wallet UTXOs on app startup (GH#522) On startup, bootstrap_loaded_wallets now spawns background tasks to refresh UTXOs from Core RPC for all HD and single-key wallets. This ensures balances are current without requiring the user to manually click Refresh. Only applies in RPC mode; SPV handles UTXOs via reconciliation. Task: 1.1a * fix: respect fee_deduct_from_output flag in platform address funding (GH#476) When the user selects "deduct from input", use an explicit output amount for the destination and a separate change address for the fee remainder, so the destination receives the exact requested amount. Task: 1.1b * fix: reserve estimated fees in wallet balance top-up max button (GH#478) Task: 1.1c * fix: prevent funding address reuse across identities (GH#85) Task: 1.1d * fix: add 5-minute timeout to asset lock proof wait loop (wallet-008) Task: 1.1e * fix: use wallet-controlled change address and epoch-aware fee estimator Use a fresh wallet receive address for platform funding change output instead of an ephemeral key-derived address, so surplus credits remain spendable. Also switch to epoch-aware fee estimator for accurate fee estimation when the network fee multiplier is above 1x. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address critical review issues in wallet funding - Use try_lock() in tokio::select! timeout arm to avoid blocking the async runtime when another thread holds the mutex - Use change_address() (BIP44 internal path) instead of receive_address() for deriving change addresses, ensuring proper path separation - Replace .unwrap_or(0) with .ok_or() on BTreeMap index lookup to surface errors instead of silently targeting the wrong output Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: auto-refresh wallet UTXOs on asset lock proof timeout (RPC mode) When the 5-minute timeout fires, the asset lock tx has already been broadcast and UTXOs removed locally. Trigger a background wallet refresh in RPC mode so spent inputs are reconciled against chain state. SPV mode handles its own reconciliation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * style: fix rustfmt formatting in fee estimator chain Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: replace saturating_mul with checked_mul for duffs-to-credits conversion Overflow now returns an explicit error with diagnostic info instead of silently clamping to u64::MAX. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * fix(tokens): restore token reorder assignment and distribution field checks (#535) * Extract dialog rendering into wallets_screen/dialogs.rs module (#539) Moved 4 dialog rendering functions and 10+ helper methods (~1151 lines) from wallets_screen/mod.rs into a new dialogs.rs module. Includes send, receive, fund platform, and private key dialogs plus their state structs. mod.rs reduced from 3824 to 2673 lines. Task: 3.2a * build: update all dependencies (#531) * fix: build fails for windows target * build: only create a release when tag is set * chore: remove redundant settings from release.yml * doc: windows requirements * fix: windows icon * build: change grovestark revision * chore: fmt * fix: don't open console window on windows * build: grovestark recent commit * build: update dependencies * chore: clippy * chore: fmt * build: update platform to most recent v3.1-dev * feat: add key exchange protocol and state transition signing Add YAPPR key exchange flow for DashPay, QR scanner improvements, state transition signing screen, and refactor UI helpers. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: migrate SPV event handling to broadcast channels Replace orphaned SpvEvent handler with three new broadcast-based handlers (SyncEvent, WalletEvent, NetworkEvent) that subscribe to the actual event producers in dash-spv. This fixes wallet reconciliation never being triggered by SPV events. - Bump dash-sdk to fb055ec008 (picks up rust-dashcore 4d2a7018 with WalletEvent support) - Add spawn_sync_event_handler: triggers reconcile on BlockProcessed, ChainLockReceived, InstantLockReceived, SyncComplete - Add spawn_wallet_event_handler: triggers reconcile on all wallet events (TransactionReceived, BalanceUpdated) - Add spawn_network_event_handler: updates connected_peers count on PeersUpdated - Add connected_peers field to SpvManager and SpvStatusSnapshot - Fix reconcile channel race: register channel before starting SPV thread so handlers always capture a valid sender - Improve reconcile: track in-memory UTXOs, log summaries, guard against wiping transaction history Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: refresh receive dialog balances from wallet on each frame The receive dialog cached address balances at open time and never updated them, so SPV balance changes were not reflected until the dialog was closed and reopened. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: remove YAPPR key exchange and state transition signing Move these features to the feat/yappr-key-exchange branch. This branch now focuses on SPV broadcast channel migration, dependency bumps, and reconciliation fixes only. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: replace Core RPC with DAPI for asset lock operations in SPV mode Migrate transaction info queries, broadcasting, and finality detection away from direct Core RPC calls so that identity registration and top-up work in SPV-only mode. Key changes: - Add `get_transaction_info_via_dapi()` using DAPI GetTransaction - Add `broadcast_raw_transaction()` that routes via RPC or SPV - Add SPV finality listener forwarding instant/chain lock events - Make asset lock creation methods async for SPV broadcasting - Use longer proof timeouts (5min) in SPV mode vs 2min for RPC - Update address balances after asset lock UTXO consumption - Add BIP32 derivation path detection for SPV address mapping - Bump platform SDK rev to bcb41de347 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: apply cargo fmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: handle ignored Results and avoid panic on poisoned lock - Propagate update_address_balance errors via ? in create_asset_lock.rs - Replace .expect() with .map_err()? for core_client lock in broadcast_raw_transaction - Log try_send failures for finality events in SPV manager instead of silently dropping Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: clean up finality map on success and remove poisoned lock panic Remove stale entries from transactions_waiting_for_finality on the success path of asset lock proof timeout loops, preventing unbounded map growth. Applied to both top_up_identity.rs and register_identity.rs. Also replace .expect() on poisoned RwLock read of core_client with graceful error propagation via map_err. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: address PR #525 review feedback from @lklimek - Rename get_transaction_info_via_dapi to get_transaction_info - Extract wait_for_asset_lock_proof helper on AppContext (4 copies → 1) - Extract recalculate_affected_address_balances and recalculate_address_balance helpers on Wallet (7 copies → helper calls) - Fix unused height variable suppression in ChainLock handler - Document single-subscriber semantics on register_finality_channel and register_reconcile_channel - Fix pre-existing collapsible_if clippy warnings in determine_sync_stage Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Refactor masternode list diff screen state (#520) * refactor: split masternode list diff screen state * fix: avoid borrows in diff screen renders * Initial plan * refactor: split context.rs into focused submodules (#543) Extract the monolithic 1795-line context.rs into a context/ module with 5 focused submodules, each grouping related AppContext methods: - mod.rs (543 lines): struct definition, constructor, config/SDK methods - wallet_lifecycle.rs (572 lines): SPV/wallet management and reconciliation - identity_db.rs (205 lines): identity and DPNS database operations - contract_token_db.rs (198 lines): contract and token database operations - settings_db.rs (84 lines): settings cache and persistence - transaction_processing.rs (231 lines): transaction finality handling Pure extraction with no logic changes. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * refactor: extract address table, asset locks, and single-key view from wallets_screen (#542) Continue the wallets_screen/mod.rs refactoring started in #539 (dialogs extraction). Extract three more focused submodules: - address_table.rs: SortColumn/SortOrder enums, AddressData struct, sorting logic, categorize_path, and the full address table renderer - asset_locks.rs: asset lock table rendering and fund dialog triggers - single_key_view.rs: single-key wallet detail view with UTXO display Reduces mod.rs from 2662 to 1947 lines (-27%). Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * fix(startup): harden cookie parsing, config save, and logger init (#537) * fix(startup): harden cookie parsing, config save, and logger init * style(logging): apply rustfmt in logger init * fix(startup): use sync_all, fix Windows rename, and remove credential leak - Use with_file_name instead of with_extension for temp file path clarity - Replace flush() with sync_all() for crash-safe atomic config writes - Handle Windows rename semantics by removing target before rename - Remove raw cookie value from error message to prevent credential leakage Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * style: apply rustfmt Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(config): use NamedTempFile::persist() for atomic config save on Windows Replace manual remove-then-rename sequence with tempfile::NamedTempFile which uses MoveFileEx(MOVEFILE_REPLACE_EXISTING) on Windows for atomic file replacement. This fixes two issues: - Config loss if process crashes between remove_file and rename - Open file handle on tmp file preventing rename on Windows Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * fix: propagate errors from wallet balance recalculation instead of silently dropping Replace `let _ = wallet.recalculate_*()` with `?` in 5 call sites so database errors during address-balance recalculation are surfaced instead of silently swallowed. This matches the existing pattern in create_asset_lock.rs which already propagates these errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: update dash-sdk to platform rev 060515987a Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: cargo fmt * fix: connection status not clear (#532) * fix: connection status not updated * chore: rabbit feedback * chore: typo + network changes * chore: apply feedback * chore: rabbit review * chore: rabbit feedback * chore: rabbitting * chore: fmt --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: error when SPV sync height unknown instead of defaulting to 0 Passing height=0 into transaction construction when SPV hasn't synced yet can lead to incorrect locktime/maturity behavior. Return an error instead so the caller knows to wait for sync progress. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Merge pull request #548 from dashpay/chore/improve-claude-md chore: improve CLAUDE.md with architecture documentation * docs: use v1.0-dev for diffs etc agents (#551) * fix: remove dead code with guaranteed mutex deadlock (#559) * Initial plan * Remove unused insert_remote_identity_if_not_exists function with deadlock bug Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * feat: add "Claim all" checkbox and complete merge with v1.0-dev - Added claim_all boolean field to ClaimTokens task - Updated handler to call claim_all_tokens or claim_token based on flag - Added claim_all checkbox to UI (enabled by default) - Added claimed_amount field to track tokens claimed - Updated display_task_result to save and display claimed amount - Updated success screen to show amount of tokens claimed - Wire checkbox state to ClaimTokens backend task Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> --------- Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com> Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> Co-authored-by: QuantumExplorer <quantum@dash.org> Co-authored-by: pauldelucia <pauldelucia2@gmail.com> Co-authored-by: thephez <thephez@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Ivan Shumkov <ivanshumkov@gmail.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: pasta <pasta@dashboost.org> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Summary by CodeRabbit
Release Notes
New Features
Refactor