Revert non-color SPV mode check removal from PR #572#578
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Verify color changes in pull request #572
Revert non-color SPV mode check removal from PR #572
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #572 accidentally removed an SPV mode guard that prevents RPC chain lock polling in SPV mode.
Changes
ConnectionStatus::refresh()(lines 243-246 ofsrc/context/connection_status.rs)Context
The removed code:
This guard prevents unnecessary RPC calls when running in SPV mode, where chain lock polling is not supported. Without it, SPV mode would attempt RPC chain lock polling on every refresh cycle.
After this fix, PR #572 contains only color refactoring across 64 files (centralizing ~120 hardcoded
Color32values intoDashColorsconstants).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.github.com/home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/bin/cargo check --all-features --all-targets(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.