Skip to content

Revert non-color SPV mode check removal from PR #572#578

Closed
Copilot wants to merge 2 commits into
refactor/centralize-dash-colorsfrom
copilot/verify-color-changes
Closed

Revert non-color SPV mode check removal from PR #572#578
Copilot wants to merge 2 commits into
refactor/centralize-dash-colorsfrom
copilot/verify-color-changes

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 15, 2026

PR #572 accidentally removed an SPV mode guard that prevents RPC chain lock polling in SPV mode.

Changes

  • Restored SPV mode check in ConnectionStatus::refresh() (lines 243-246 of src/context/connection_status.rs)

Context

The removed code:

// SPV mode does not use RPC chain lock polling.
if self.backend_mode() == CoreBackendMode::Spv {
    return AppAction::None;
}

This guard prevents unnecessary RPC calls when running in SPV mode, where chain lock polling is not supported. Without it, SPV mode would attempt RPC chain lock polling on every refresh cycle.

After this fix, PR #572 contains only color refactoring across 64 files (centralizing ~120 hardcoded Color32 values into DashColors constants).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.github.com
    • Triggering command: /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/bin/cargo check --all-features --all-targets (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Pull request: https://github.com/dashpay/dash-evo-tool/pull/572/files should only contain color changes. Verify this.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Copilot AI changed the title [WIP] Verify color changes in pull request #572 Revert non-color SPV mode check removal from PR #572 Feb 15, 2026
Copilot AI requested a review from lklimek February 15, 2026 16:32
@lklimek lklimek closed this Feb 16, 2026
@lklimek lklimek deleted the copilot/verify-color-changes branch February 16, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants