fix: address Lukasz review comments from PR #563#584
Merged
PastaPastaPasta merged 1 commit intoFeb 17, 2026
Merged
Conversation
- Replace guard-then-unwrap with match/let-else in all 8 token screens - Move identity UI removal after successful DB deletion - Add backend security level validation for identity key purposes - Show user-facing error message on identity deletion failure
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
111ff0e
into
dashpay:fix/identity-token-screen-safety
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all review comments from @lklimek on PR #563.
Changes
1. [MEDIUM] Replace guard-then-unwrap with match/let-else (all 8 token screens)
Replaced fragile
.is_none()guard + later.unwrap()with idiomaticmatchdestructuring in: mint, claim, destroy, freeze, pause, resume, transfer, unfreeze. Follows the pattern already used intoken_creator.rs:1487-1496.2. [LOW] Move identity removal after successful DB deletion
shift_remove()now only runs afterdelete_local_qualified_identity()succeeds. On failure, shows a user-facing error message instead of silently diverging UI/DB state.3. [MEDIUM] Add backend security level validation
Added
validate_identity_key_security_levels()inbackend_task/identity/mod.rsthat enforces MEDIUM for ENCRYPTION/DECRYPTION and CRITICAL for TRANSFER keys. Defense-in-depth beyond UI-only enforcement.