refactor: renamed amd64 to x86_64 in release#61
Conversation
WalkthroughThe pull request modifies the workflow configuration for the "Release Dash Evo Tool" by standardizing architecture identifiers from "amd64" to "x86_64" across various job definitions for Linux and macOS. This includes updates to job matrix entries and platform specifications, ensuring consistency without altering the overall structure or functionality of the workflow. The job definitions for building and releasing the tool remain unchanged, and the Windows job continues to target "x86_64-pc-windows-gnu." Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/release.yml (1)
Line range hint
150-180: Critical: Update artifact names in the release job to match the new x86_64 naming.The release job is still trying to download and publish artifacts with the old "amd64" naming, but the build job is now uploading them with "x86_64" naming. This mismatch will cause the release job to fail.
Apply this diff to fix the artifact names:
- name: Download Linux AMD64 Artifact uses: actions/download-artifact@v4 with: - name: dash-evo-tool-amd64-linux.zip + name: dash-evo-tool-x86_64-linux.zip - name: Download MacOS AMD64 Artifact uses: actions/download-artifact@v4 with: - name: dash-evo-tool-amd64-mac.zip + name: dash-evo-tool-x86_64-mac.zip - name: Publish release uses: softprops/action-gh-release@v1 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: tag_name: ${{ github.event.inputs.tag }} files: | - ./dash-evo-tool-amd64-linux.zip + ./dash-evo-tool-x86_64-linux.zip ./dash-evo-tool-arm64-linux.zip - ./dash-evo-tool-amd64-mac.zip + ./dash-evo-tool-x86_64-mac.zip ./dash-evo-tool-arm64-mac.zip ./dash-evo-tool-windows.zip
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/release.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/release.yml (1)
28-31: LGTM! Architecture naming standardization looks good.
The renaming from "amd64" to "x86_64" in the matrix configuration follows industry standards while maintaining compatibility with the build system.
Also applies to: 36-40
Addressed issue: #57
Summary by CodeRabbit