Skip to content

build: update dash-sdk dependency and remove rust-dashcore patches#615

Merged
lklimek merged 1 commit into
v1.0-devfrom
claude/cherry-pick-flatpak-arch-Li4pr
Feb 23, 2026
Merged

build: update dash-sdk dependency and remove rust-dashcore patches#615
lklimek merged 1 commit into
v1.0-devfrom
claude/cherry-pick-flatpak-arch-Li4pr

Conversation

@lklimek
Copy link
Copy Markdown
Contributor

@lklimek lklimek commented Feb 21, 2026

Summary

This PR updates the dash-sdk dependency to a newer revision and removes the patch section for rust-dashcore dependencies, indicating that these dependencies are now properly resolved through the updated dash-sdk.

Key Changes

  • Updated dash-sdk git revision from d6f4eb9ac9feafaa914f06e1b78eb66beceef3b7 to b445b6f0e0bd486357f86100ba8b7fddab283bd7
  • Removed the [patch."https://github.com/dashpay/rust-dashcore"] section that was patching 10 dashcore-related dependencies:
    • dash-network
    • dash-spv
    • dashcore
    • dashcore-private
    • dashcore-rpc
    • dashcore-rpc-json
    • dashcore_hashes
    • key-wallet
    • key-wallet-manager

Implementation Details

The removal of the patch section suggests that the newer dash-sdk revision now properly manages its transitive dependencies on rust-dashcore, eliminating the need for manual patches. This simplifies the dependency management and reduces maintenance overhead.

https://claude.ai/code/session_01PBXkJ5WWNGH29EabTq5zkW

Summary by CodeRabbit

  • Chores
    • Updated dependencies to the latest versions
    • Simplified dependency management by removing explicit version overrides

Update dashpay/platform dependency from d6f4eb9a to b445b6f0e0bd4863
(3.0.1 → 3.1.0-dev.1). Remove the [patch] section that pinned
rust-dashcore crates to a separate rev, as the new platform commit
resolves them correctly on its own.

https://claude.ai/code/session_015AD2pCWoJdV2VDydcqFHPG
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 21, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This pull request updates the dash-sdk dependency to a new revision and removes the git patch overrides for dash-related crates in the Cargo.toml configuration file, simplifying dependency management.

Changes

Cohort / File(s) Summary
Dependency Configuration
Cargo.toml
Updated dash-sdk dependency revision and removed git patch block for dash-network, dash-spv, dashcore, dashcore-private, dashcore-rpc, dashcore-rpc-json, dashcore_hashes, key-wallet, and key-wallet-manager crates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 The patches are gone, the SDK's been renewed,
Dependencies streamlined, the way they should be,
One hop, one skip, and the Cargo's reviewed,
Simpler, cleaner—as smooth as can be! 🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: updating dash-sdk dependency and removing rust-dashcore patches, which are the two primary modifications in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/cherry-pick-flatpak-arch-Li4pr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lklimek lklimek enabled auto-merge (squash) February 21, 2026 23:52
@lklimek lklimek disabled auto-merge February 21, 2026 23:52
@lklimek lklimek changed the title Update dash-sdk dependency and remove rust-dashcore patches build: update dash-sdk dependency and remove rust-dashcore patches Feb 21, 2026
@lklimek lklimek enabled auto-merge (squash) February 21, 2026 23:52
@lklimek lklimek requested a review from shumkov February 23, 2026 07:45
@lklimek lklimek disabled auto-merge February 23, 2026 13:03
@lklimek lklimek merged commit f579c11 into v1.0-dev Feb 23, 2026
6 checks passed
@lklimek lklimek deleted the claude/cherry-pick-flatpak-arch-Li4pr branch February 23, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants