build: update dash-sdk dependency and remove rust-dashcore patches#615
Conversation
Update dashpay/platform dependency from d6f4eb9a to b445b6f0e0bd4863 (3.0.1 → 3.1.0-dev.1). Remove the [patch] section that pinned rust-dashcore crates to a separate rev, as the new platform commit resolves them correctly on its own. https://claude.ai/code/session_015AD2pCWoJdV2VDydcqFHPG
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThis pull request updates the dash-sdk dependency to a new revision and removes the git patch overrides for dash-related crates in the Cargo.toml configuration file, simplifying dependency management. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This PR updates the dash-sdk dependency to a newer revision and removes the patch section for rust-dashcore dependencies, indicating that these dependencies are now properly resolved through the updated dash-sdk.
Key Changes
dash-sdkgit revision fromd6f4eb9ac9feafaa914f06e1b78eb66beceef3b7tob445b6f0e0bd486357f86100ba8b7fddab283bd7[patch."https://github.com/dashpay/rust-dashcore"]section that was patching 10 dashcore-related dependencies:Implementation Details
The removal of the patch section suggests that the newer dash-sdk revision now properly manages its transitive dependencies on rust-dashcore, eliminating the need for manual patches. This simplifies the dependency management and reduces maintenance overhead.
https://claude.ai/code/session_01PBXkJ5WWNGH29EabTq5zkW
Summary by CodeRabbit