fix(ui): fix message banner icons, dismiss button, text wrapping, and duplicate errors by lklimek · Pull Request #654 · dashpay/dash-evo-tool

lklimek · 2026-02-24T23:51:35Z

Summary

Changed error icon from ❌ to ⛔ to avoid confusion with the dismiss button
Repurposed ❌ as a styled dismiss button (clickable label with pointer cursor) replacing the unstyled small_button("x")
Fixed success (✅) and info (💬) icons to render correctly in Noto Sans font
Long banner text now wraps at word boundaries instead of overflowing outside the window
Removed duplicate error display in AddNewIdentityScreen — errors now only show via the global MessageBanner

Test plan

Trigger an error (e.g., load non-existent identity) — verify single ⛔ banner with ❌ dismiss, no duplicate
Trigger a success message — verify ✅ icon renders correctly
Trigger an info message — verify 💬 icon renders correctly
Resize window to be narrow — verify long error text wraps instead of overflowing
Verify dismiss button shows pointer cursor on hover and dismisses the banner on click
Try to register an identity with invalid input — verify validation error shows via global banner (no local duplicate)

🤖 Generated with Claude Code

_{🤖 Co-authored by Claudius the Magnificent AI Agent}

Summary by CodeRabbit

Style
- Redesigned message banner layout for improved wrapping and visibility.
- Updated message-type icons to new emoji symbols and replaced the dismiss button with an emoji glyph plus hover cursor.
Refactor
- Centralized error reporting to a global message banner instead of per-component error blocks.
Tests
- Updated UI tests to expect the new emoji icons and dismiss glyph.

… duplicate errors - Change error icon from ❌ to ⛔ to avoid confusion with dismiss button - Use ❌ as styled dismiss button (clickable label, pointer cursor on hover) - Fix success icon (✅) and info icon (💬) to render correctly in Noto Sans - Wrap long banner text at word boundaries instead of overflowing window - Left-align text within the wrapping area - Remove duplicate error display in AddNewIdentityScreen — delegate to global MessageBanner - Route local validation errors through MessageBanner::set_global for consistent styling Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai · 2026-02-24T23:52:08Z

📝 Walkthrough

Walkthrough

Refactors the message banner layout to use emoji icons and a clickable emoji dismiss control with dynamic text wrapping; integrates a global banner for error display by pushing errors from the Add New Identity screen; test expectations and Cargo.toml adjusted accordingly.

Changes

Cohort / File(s)	Summary
Message Banner UI Refactoring `src/ui/components/message_banner.rs`	Reworked layout to first row: icon, wrapped message text (calculated width), and right-aligned area for annotation + dismiss. Replaced button with clickable dismiss emoji (U+274C). Updated icon mapping to emoji: Error (U+26D4), Warning (⚠), Success (U+2705), Info (U+1F4AC).
Global Error Handling Integration `src/ui/identities/add_new_identity_screen/mod.rs`	Adds `last_global_error: Option<String>` field and switches error display to push messages to the global MessageBanner via `set_global`, avoiding repeated pushes each frame; preserves `display_message` signature while changing internal behavior.
Tests and Config `tests/kittest/message_banner.rs`, `Cargo.toml`	Updated tests to expect new emoji dismiss glyph (U+274C) and revised icons for message types. `Cargo.toml` lines changed (dependencies/metadata adjustments).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 I hopped in to render a banner bright,
With emoji icons and a tidy right,
A cross to dismiss, text wrapped just so,
Errors sent upstream where all can know,
Thump-thump, cheers — onward we go!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: message banner icons fixed, dismiss button improved, text wrapping added, and duplicate errors removed.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/message-banner-icons-and-duplicates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/ui/components/message_banner.rs`:
- Around line 511-517: The fixed 100.0 minimum for text_width can cause the row
to overflow in very narrow windows; update the calculation used before
ui.add_sized so text_width never forces overflow by clamping it to the available
space: compute text_width from (available_width - dismiss_width - 30.0) and
clamp to a non-negative maximum (e.g. .clamp(0.0, available_width -
dismiss_width) or use .max(0.0) instead of .max(100.0)), then pass that
text_width to egui::vec2 in the ui.add_sized call (referencing text_width,
available_width, dismiss_width, ui.add_sized, egui::vec2).

In `@src/ui/identities/add_new_identity_screen/mod.rs`:
- Around line 24-25: The PR fails CI due to formatting; run rustfmt (cargo fmt
--all) to reformat src/ui/identities/add_new_identity_screen/mod.rs so the
imports and surrounding code (references: MessageBanner, MessageType,
ScreenLike) comply with rustfmt rules; after formatting, re-run cargo fmt --all
-- --check to verify and commit the updated file.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a13ded and f69860d.

📒 Files selected for processing (2)

src/ui/components/message_banner.rs
src/ui/identities/add_new_identity_screen/mod.rs

Prevents row overflow in very narrow windows by allowing text_width to shrink to zero rather than forcing a 100px floor. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Account for annotation width (e.g. "(5s)" countdown) when calculating text_width so it doesn't overlap long messages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update kittest assertions to match new dismiss button (❌ emoji label instead of "x" small_button) and new icon mappings (⛔ error, ✅ success, 💬 info). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

This PR improves the global MessageBanner UX in the egui UI by adjusting icons, making the dismiss control a styled clickable label, ensuring banner text wraps cleanly, and removing duplicate/local error rendering in the “Add New Identity” flow.

Changes:

Update banner icons (Error/Success/Info) and switch dismiss control to a clickable ❌ label.
Improve banner layout so long text wraps at word boundaries instead of overflowing.
Route AddNewIdentityScreen errors through the global MessageBanner to avoid duplicate displays.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
tests/kittest/message_banner.rs	Updates UI tests to assert the new iconography and the ❌ dismiss label.
src/ui/identities/add_new_identity_screen/mod.rs	Removes local banner-like UI and forwards validation errors into the global banner system.
src/ui/components/message_banner.rs	Reworks banner rendering layout for wrapping text, updates icons, and implements the new dismiss interaction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Fix comment: icon is not actually "fixed width" (#2850192960) - Measure annotation width dynamically instead of hard-coded 52px (#2850192972) - Prevent validation errors from re-pushing to global banner each frame by tracking last-sent message (#2850192953) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Lower per-character width multiplier from 0.55 to 0.4 to match actual rendered width of digit/paren annotation strings like "(5s)". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/ui/identities/add_new_identity_screen/mod.rs`:
- Around line 1106-1116: When error_message != last_global_error, always clear
the previous global banner before setting a new one: in the block guarded by the
equality check, if let Some(old) = self.last_global_error.as_ref() call
MessageBanner::clear_global_message(ui.ctx(), old) first, then if let Some(new)
= self.error_message.as_ref() call MessageBanner::set_global(ui.ctx(), new,
MessageType::Error); finally update self.last_global_error =
self.error_message.clone(); this ensures orphaned banners are removed when
switching from Some("A") to Some("B") while using the existing symbols
error_message, last_global_error, MessageBanner::clear_global_message and
MessageBanner::set_global.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f69860d and b9a14c7.

📒 Files selected for processing (3)

src/ui/components/message_banner.rs
src/ui/identities/add_new_identity_screen/mod.rs
tests/kittest/message_banner.rs

When error_message transitions from Some("A") to Some("B"), the old banner was never cleared because the clear branch was in an else-if. This caused orphaned error banners to stack up in the global banner list. Fix: always clear the old banner before setting a new one, using two independent if-blocks instead of if/else-if. Found by CodeRabbit review on dashpay#654.

lklimek requested a review from PastaPastaPasta as a code owner February 24, 2026 23:51

fix(ui): left-align banner text and sort imports

e9c18b4

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai Bot reviewed Feb 24, 2026

View reviewed changes

Comment thread src/ui/components/message_banner.rs Outdated

Comment thread src/ui/identities/add_new_identity_screen/mod.rs Outdated

lklimek and others added 3 commits February 25, 2026 00:59

fix(ui): clamp banner text width to zero instead of 100px minimum

3cd5d00

Prevents row overflow in very narrow windows by allowing text_width to shrink to zero rather than forcing a 100px floor. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix(ui): reserve space for countdown annotation in banner text width

e387190

Account for annotation width (e.g. "(5s)" countdown) when calculating text_width so it doesn't overlap long messages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

test(ui): update banner tests for new icons and dismiss button

8d0ba48

Update kittest assertions to match new dismiss button (❌ emoji label instead of "x" small_button) and new icon mappings (⛔ error, ✅ success, 💬 info). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

lklimek requested a review from Copilot February 25, 2026 00:22

Copilot started reviewing on behalf of lklimek February 25, 2026 00:23 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

Comment thread src/ui/identities/add_new_identity_screen/mod.rs Outdated

Comment thread src/ui/components/message_banner.rs

Comment thread src/ui/components/message_banner.rs Outdated

lklimek and others added 2 commits February 25, 2026 01:36

fix(ui): reduce annotation width estimate for banner layout

b9a14c7

Lower per-character width multiplier from 0.55 to 0.4 to match actual rendered width of digit/paren annotation strings like "(5s)". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

lklimek requested a review from Copilot February 25, 2026 00:38

Copilot started reviewing on behalf of lklimek February 25, 2026 00:38 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

coderabbitai Bot reviewed Feb 25, 2026

View reviewed changes

Comment thread src/ui/identities/add_new_identity_screen/mod.rs

lklimek merged commit 967a520 into v1.0-dev Feb 25, 2026
10 checks passed

lklimek deleted the fix/message-banner-icons-and-duplicates branch February 25, 2026 00:47

lklimek mentioned this pull request Feb 25, 2026

Warning message does not fit the screen #482

Closed

lklimek mentioned this pull request Feb 25, 2026

backport: merge v1.0-dev (including extracted non-ZK fixes) back into zk #644

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): fix message banner icons, dismiss button, text wrapping, and duplicate errors#654

fix(ui): fix message banner icons, dismiss button, text wrapping, and duplicate errors#654
lklimek merged 7 commits into
v1.0-devfrom
fix/message-banner-icons-and-duplicates

lklimek commented Feb 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Feb 24, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lklimek commented Feb 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lklimek commented Feb 24, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Feb 24, 2026 •

edited

Loading