Skip to content

fix: dpns names for proof error passed 100 results#68

Merged
QuantumExplorer merged 3 commits into
v0.3-devfrom
fix/dpnsnames
Nov 17, 2024
Merged

fix: dpns names for proof error passed 100 results#68
QuantumExplorer merged 3 commits into
v0.3-devfrom
fix/dpnsnames

Conversation

@QuantumExplorer
Copy link
Copy Markdown
Member

@QuantumExplorer QuantumExplorer commented Nov 17, 2024

There was an issue with proofs because we were asking for an unlimited amount of names, but we were only getting back 100. This is fixed.

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a new ProofLogScreen for visualizing proof logs with sorting and filtering capabilities.
    • Added a ToolsSubscreen chooser for selecting between different tools subscreens.
    • Enhanced the DPNSContestedNamesScreen with improved display logic for contested names.
  • Improvements

    • Updated error handling and control flow in various database methods.
    • Enhanced UI components for better user experience and navigation.
  • Bug Fixes

    • Adjusted button functionality to ensure correct screen navigation.
  • Documentation

    • Expanded module structure for better organization and accessibility of components.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 17, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes across multiple files, primarily focusing on dependency updates, enhancements to the user interface, and improvements in error handling within the application. Key modifications include updating the dash-sdk dependency in Cargo.toml, adding a new ProofLogScreen and related UI components, and implementing robust error handling in database operations. The overall structure of the application remains intact while enhancing functionality and user experience.

Changes

File Path Change Summary
Cargo.toml Updated dash-sdk dependency from commit 994f762... to c49af536...; added new dependency regex = "1.11".
src/app.rs Added ProofLogScreen to AppState; renamed RootScreenTransitionVisualizerScreen to RootScreenToolsTransitionVisualizerScreen.
src/backend_task/contested_names/query_dpns_contested_resources.rs Enhanced query_dpns_contested_resources method with dynamic querying and improved error handling for proof verification.
src/database/contested_names.rs Improved error handling in update_ending_time method to gracefully handle cases with no rows returned.
src/database/initialization.rs Updated database initialization logic for versioning; added methods for migration and database recreation; renamed backup_and_recreate_db to backup_db.
src/database/mod.rs Added new module proof_log.
src/database/proof_log.rs Introduced methods for managing proof_log table, including creation, insertion, and retrieval of proof log items.
src/database/settings.rs Added update_database_version method to update the database version in the settings table.
src/model/mod.rs Added new module proof_log_item.
src/model/proof_log_item.rs Introduced RequestType enum and ProofLogItem struct with associated trait implementations for handling request types.
src/ui/components/left_panel.rs Updated button functionality to link to RootScreenToolsTransitionVisualizerScreen.
src/ui/components/mod.rs Added new module tools_subscreen_chooser_panel.
src/ui/components/tools_subscreen_chooser_panel.rs Created UI component for selecting tools subscreens, including ProofLog and TransactionViewer.
src/ui/dpns_contested_names_screen.rs Enhanced display logic in render_table_active_contests and render_table_past_contests methods to improve clarity of contested names.
src/ui/mod.rs Added ProofLogScreen and updated RootScreenType enum with new screen types.
src/ui/tool_screens/mod.rs Introduced proof_log_screen and transition_visualizer_screen modules.
src/ui/tool_screens/proof_log_screen.rs Implemented ProofLogScreen struct with methods for displaying and managing proof log items.
src/ui/tool_screens/transition_visualizer_screen.rs Updated TransitionVisualizerScreen to integrate new UI components and adjust screen type references.

Possibly related PRs

  • feat: log proof log errors to db #64: The changes in this PR involve modifications to the Cargo.toml file, specifically updating the dash-sdk dependency, which is directly related to the changes made in the main PR that also updated the dash-sdk dependency from a specific commit hash to a new one.

Poem

🐇 In the meadow where code does play,
New screens and tools come out to sway.
With logs of proof and names to contest,
Our app now shines, it's simply the best!
So hop along, let the features bloom,
In this garden of code, there's always room! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@QuantumExplorer QuantumExplorer changed the base branch from master to v0.3-dev November 17, 2024 03:57
@QuantumExplorer QuantumExplorer changed the title fix: dpns names fix: dpns names for proof error passed 100 results Nov 17, 2024
@QuantumExplorer QuantumExplorer merged commit b0dcedd into v0.3-dev Nov 17, 2024
@QuantumExplorer QuantumExplorer deleted the fix/dpnsnames branch November 17, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant