ci: fix model config and add MemCan to review workflow#765
Conversation
Move model selection from invalid `claude_model` input to `ANTHROPIC_MODEL` env var. Add `memcan_url` and `memcan_api_key` inputs for persistent memory support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MEMCAN_URL is not sensitive — use vars instead of secrets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughGitHub Actions workflow updated to modify review job configuration. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
There was a problem hiding this comment.
Pull request overview
Updates the Claudius code review GitHub Actions workflow to correctly configure the Anthropic model selection and to enable persistent memory support via MemCan.
Changes:
- Replace the workflow’s (invalid)
claude_modelaction input with a job-levelANTHROPIC_MODELenvironment variable. - Add MemCan configuration inputs (
memcan_url,memcan_api_key) to the review action invocation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/claude-code-review.yml (1)
34-35: Consider adding validation for MemCan credentials if they are required.The PR description lists
MEMCAN_URLandMEMCAN_API_KEYunder "Required setup." If the workflow depends on MemCan being available, consider adding an early validation step that fails explicitly when these are not configured.If MemCan is optional (nice-to-have but not required), this can be ignored.
🛡️ Proposed validation step (if MemCan is required)
steps: + - name: Validate MemCan configuration + if: ${{ vars.MEMCAN_URL == '' || secrets.MEMCAN_API_KEY == '' }} + run: | + echo "::error::MemCan is not configured. Set MEMCAN_URL (variable) and MEMCAN_API_KEY (secret) in repository settings." + exit 1 - name: Claudius Review uses: lklimek/claudius-review-action@mainBased on learnings: "In GitHub Actions workflow files, prefer failing a job explicitly when a required secret or token is missing, instead of silently skipping steps."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/claude-code-review.yml around lines 34 - 35, Add an early validation step in the GitHub Actions workflow (.github/workflows/claude-code-review.yml) that checks the required MemCan inputs MEMCAN_URL and MEMCAN_API_KEY and fails the job explicitly if either is missing; implement this by adding a job step (e.g., "Validate MemCan credentials") that runs a shell check referencing ${{ vars.MEMCAN_URL }} and ${{ secrets.MEMCAN_API_KEY }} and exits non‑zero with a clear error message when they are empty, or gate subsequent MemCan-using steps with an explicit conditional using those same symbols if you prefer conditional skipping.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/claude-code-review.yml:
- Around line 34-35: Add an early validation step in the GitHub Actions workflow
(.github/workflows/claude-code-review.yml) that checks the required MemCan
inputs MEMCAN_URL and MEMCAN_API_KEY and fails the job explicitly if either is
missing; implement this by adding a job step (e.g., "Validate MemCan
credentials") that runs a shell check referencing ${{ vars.MEMCAN_URL }} and ${{
secrets.MEMCAN_API_KEY }} and exits non‑zero with a clear error message when
they are empty, or gate subsequent MemCan-using steps with an explicit
conditional using those same symbols if you prefer conditional skipping.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0a954875-9cdb-44c0-97b5-86fcc98e1f94
📒 Files selected for processing (1)
.github/workflows/claude-code-review.yml
Summary
claude_modelinput (doesn't exist in claudius-review-action) withANTHROPIC_MODELenv var — the correct way to control the modelmemcan_url(repo variable) andmemcan_api_key(secret) so the review agent has persistent memory across reviewsSetup required
MEMCAN_URLhttp://host:8190)MEMCAN_API_KEYTest plan
MEMCAN_URLvariable andMEMCAN_API_KEYsecret are configured in repo settingsclaudius-reviewand confirm the review workflow runs successfully🤖 Co-authored by Claudius the Magnificent AI Agent
Summary by CodeRabbit