fix(ui): wallet screen identity, state management, and input validation (#797)

[lklimek]

Summary

Fixes all 7 items from #797.

Changes

1. ScreenType::eq — shielded screens now compare WalletSeedHash instead of using wildcards
2. ShieldedTabView::update_seed_hash — resets all 8 transient fields (was missing initializing, syncing, pending_task, address_count)
3. Typed SPV payment errors — 3 new TaskError variants replace string-based WalletPaymentFailed
4. Halo2 warmup guard — #[cfg(not(feature = "testing"))] skips ~30s proving key build in tests
5. is_platform_address — delegates to is_platform_address_string for consistent case-insensitive validation
6. Address hints — rewritten as full i18n-extractable sentences
7. RPC error sanitization — strips OS error codes and transport wrappers from connection status display

Closes #797

Test plan

• Open shield screen for Wallet A, switch to Wallet B, open same screen — verify different screen instance
• Switch wallets — verify shielded tab resets (no stale syncing/initializing state)
• Trigger SPV payment errors — verify typed error messages (no raw string details)
• Run tests with --features testing — verify no 30s Halo2 warmup delay
• Enter uppercase platform address — verify accepted (case-insensitive)
• Check Networks page RPC errors — verify no raw OS error codes

_{🤖 Co-authored by Claudius the Magnificent AI Agent}

Summary by CodeRabbit

Release Notes

• New Features

  • Tab-based account navigation (Dash Core, Platform, Shielded) with instant switching
  • Developer mode System tab showing internal wallet categories
  • Collapsible transaction history section with persistent state
  • Collapsible balance breakdown and address sections
  • Network password field auto-updates when switching networks
  • Address input now excludes change addresses when appropriate
  • Shielded addresses table displaying all diversified addresses

• Bug Fixes

  • Fixed RPC error messages to display sanitized, user-friendly text
  • Connection status recovery after transient RPC outages
  • Resolved shielded note deduplication to prevent double-counting
  • Improved Core address vs. Identity detection accuracy
  • Consistent SPV transaction ownership marking across wallets

• Improvements

  • Enhanced error handling for wallet operations
  • Refined account category labeling and visibility logic
  • Better address validation and display formatting

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR introduces wallet management and shielded transaction handling improvements, including tab-based account navigation, enhanced error handling with new TaskError variants, shielded wallet initialization and note synchronization pipelines, improved address input validation and truncation, state management refactoring in shielded screens, and SPV transaction classification logic updates. Documentation adds four new wallet UI user stories.

Changes

Cohort / File(s)	Summary
Documentation & Testing Setup docs/user-stories.md, src/app.rs, tests/backend-e2e/main.rs	Added wallet management user stories (WAL-021 to WAL-024) covering tab navigation, system tabs, transaction history, and balance breakdown. Skipped Halo2 proving key warmup in test builds. Added tx_is_ours test module.
Error Handling & Task Framework src/backend_task/error.rs, src/backend_task/core/mod.rs	Added four new TaskError variants (WalletInfoUnavailable, MissingBip44Account, ChangeAddressDerivation, ShieldedNonceMismatch) to replace generic error strings. Implemented RPC error sanitization and detection of nonce-mismatch consensus errors. Updated active-network chain-lock failure messaging.
Shielded State & Synchronization src/backend_task/shielded/sync.rs, src/context/shielded.rs, src/context/wallet_lifecycle.rs	Added in-memory deduplication for decrypted shielded notes to prevent double-counting. Exposed shielded helper methods (initialize_shielded_wallet, sync_shielded_notes, check_nullifiers_task). Introduced queue_shielded_init_and_sync pipeline with post-init sync. Modified SPV transaction is_ours to force true with conditional logging.
Database Optimization src/database/mod.rs	Scoped SQLite connection mutex lock to transaction block, releasing immediately after commit before optional commitment-tree clearing.
Address Validation & Display Utilities src/model/address.rs, src/ui/helpers.rs	Added is_platform_address_string and truncate_address helpers to model layer. Updated AddressKind::detect with improved Core-vs-Identity disambiguation using prefix inspection and parse ordering. Removed local implementation from ui/helpers and re-exported from model. Updated PLATFORM_ADDRESS_HINT/EXAMPLES constants.
Address Input Components src/ui/components/address_input.rs	Added is_change field to AddressEntry for BIP44 change address tagging. Introduced exclude_change builder flag to filter change addresses from autocomplete. Switched Core address iteration from address_balances to known_addresses with system-category exclusion. Updated validation messages and Orchard network enforcement. Broadened autocomplete filtering to include address_kind labels.
Screen State & Address Input Invalidation src/ui/identities/transfer_screen.rs, src/ui/tools/address_balance_screen.rs, src/ui/wallets/send_screen.rs, src/ui/wallets/unshield_credits_screen.rs, src/ui/wallets/shielded_send_screen.rs	Added or updated invalidate_address_input methods across multiple screens to clear inputs and reset validation state. Updated send_screen and unshield_credits_screen to also clear validated_destination. Enhanced shielded_send_screen to update balance display after note sync.
Core Account & Tab Management src/ui/wallets/account_summary.rs, src/ui/wallets/wallets_screen/mod.rs, src/ui/wallets/wallets_screen/address_table.rs	Replaced WalletViewTab with AccountTab model (Category + Shielded + System tabs). Updated AccountCategory with tab_label, is_visible_in_default_mode, is_system_category methods. Changed label display ("Dash Core" for Bip44/0, "Platform" for PlatformPayment). Removed label field from AccountSummary. Updated address_table to accept explicit account_filter parameter.
Shielded Tab State Refactoring src/ui/wallets/shielded_tab.rs	Removed wallet unlock popup and manual address diversification UI logic. Added tick() method and refresh_from_backend_state() to reflect backend initialization/sync state. Changed address display from single payment card to collapsible diversified addresses table with copy controls and "+" button. Updated notes rendering to collapsible section. Replaced lock().unwrap() with lock().ok() for error resilience.
Network & UI State Management src/ui/mod.rs, src/ui/network_chooser_screen.rs	Fixed ScreenType::eq to compare inner WalletSeedHash for shielded variants instead of wildcard matching. Added address-input invalidation in Screen::change_context for TransferScreen, AddressBalanceScreen, and ShieldedSendScreen. Updated network chooser to auto-populate password field from config on network switch.
E2E Testing tests/backend-e2e/tx_is_ours.rs	Added test_spv_transactions_is_ours_flag that verifies sender and receiver wallets both set is_ours=true with correct net_amount signs across SPV transaction reconciliation.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related issues

• fix(shielded): fee and transfer calculation correctness issues #795 — This PR adds TaskError::ShieldedNonceMismatch variant and maps ConsensusError::StateError(StateError::AddressInvalidNonceError(_)) to it, directly addressing shielded broadcast nonce/confirmation concerns.

Poem

🐰 Tabs now sparkle where dropdowns once dwelt,
Shielded notes dedupe with care that is felt,
Addresses truncate with elegance bright,
State resets cleanly from wallet to wallet—
A rabbit's refactor, done just right! 🌙✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly describes the main changes: wallet screen identity fixes (ScreenType equality), state management improvements (ShieldedTabView reset), and input validation enhancements, all of which are central to the changeset.
Linked Issues check	✅ Passed	The PR addresses all acceptance criteria from issue #797: ScreenType equality now compares WalletSeedHash, update_seed_hash resets all transient fields, SPV payment errors use typed TaskError variants, Halo2 warmup is guarded for testing builds, platform address validation is case-insensitive, and address hints are full sentences.
Out of Scope Changes check	✅ Passed	All changes directly support the stated objectives. Additional improvements like address input enhancements, transaction filtering (is_ours), shielded tab refactoring, and database mutex safety are closely related supporting changes addressing the same code areas identified in issue #797.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/wallet-ui-issues-797

⚔️ Resolve merge conflicts

• Resolve merge conflict in branch fix/wallet-ui-issues-797

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Fixes several wallet UI/state and validation issues called out in #797, spanning screen identity, shielded tab lifecycle, typed SPV payment errors, and improved RPC error presentation.

Changes:

• Make shielded ScreenType equality wallet-specific (compare WalletSeedHash) to prevent cross-wallet screen reuse.
• Reset all shielded tab transient state on wallet switch and standardize Platform address prefix detection/hints.
• Introduce typed SPV payment TaskError variants, add RPC error sanitization for Networks status, and skip Halo2 proving key warmup in testing builds.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/ui/wallets/shielded_tab.rs	Resets additional transient shielded-tab fields when seed_hash changes.
src/ui/mod.rs	Fixes ScreenType equality for shielded screens to compare by WalletSeedHash.
src/ui/helpers.rs	Delegates Platform address detection to the canonical case-insensitive helper; updates user-facing hint/example strings.
src/backend_task/error.rs	Adds typed TaskError variants for common SPV payment failure cases.
src/backend_task/core/mod.rs	Uses new typed errors in SPV tx building/signing path; sanitizes RPC error strings for connection status display.
src/app.rs	Guards Halo2 proving key warmup thread so it doesn’t run under the testing feature.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[lklimek]

Our regular user will not understand it. Check persona and adjust message accordingly.

[lklimek]

Fixed in 3c8466a — rewritten for everyday user persona: "Your wallet needs to be refreshed before sending. Please refresh and try again."

_{🤖 Claudius the Magnificent}