test: add backend E2E tests for masternode identity features (TC-084 to TC-090)

[lklimek]

Summary

• Add 7 backend E2E tests covering masternode/evonode identity operations (TC-084 → TC-090).
• New framework/mn_helpers.rs module for credential loading from env vars.
• Tests are gated on E2E_MN_* env vars and skip gracefully when credentials unavailable.
• Each test is fully independent — no shared fixtures, no ordering dependencies.
• Includes a production fix (commit d17cfae8, filed standalone as #835) surfaced while developing TC-090 — see the "Production fix" section below.

Test Catalog

TC	Name	Description
TC-084	Load Masternode identity	Load by ProTx hash with all 3 keys (voting, owner, payout)
TC-085	Load Evonode identity	Same ProTx loaded as Evonode type (tests type label propagation)
TC-086	Load MN voting key only	Partial key load — only voting key, no owner/payout
TC-087	Refresh MN identity	Load then refresh round-trip, verify ID and type preserved
TC-088	Invalid ProTx (error)	All-zeros ProTx — always runs, no env vars needed
TC-089	Wrong voting key (error)	Valid ProTx + random key — expects identity-not-found error
TC-090	Vote with MN voter	Registers contested DPNS name, votes Lock with MN voter identity

Environment Variables

Variable	Required for	Description
E2E_MN_PROTX_HASH	All MN tests	Hex ProRegTx hash of a registered testnet masternode/evonode
E2E_MN_VOTING_KEY	Voting tests	WIF private key for the MN's voting address
E2E_MN_OWNER_KEY	Owner key tests	WIF private key for the MN's owner address
E2E_MN_PAYOUT_KEY	Payout tests	WIF private key for the MN's payout address

Production fix discovered during TC-090 development

TC-090 failed three consecutive times against testnet with an opaque ~70 s "unexpected error" on every masternode vote. Drive-abci server logs (correlated by block height across runs at 318950 / 319048 / 319073) revealed the real cause: VotePollNotFoundError at PrepareProposal.

Root cause: src/backend_task/contested_names/vote_on_dpns_name.rs was building the vote poll's index_values from the raw DPNS label. Platform indexes contested polls under the homograph-safe normalized label (convert_to_homograph_safe_chars: i→1, l→1, o→0, then lowercase). Any label containing i/l/o silently mismatched the index. The tx passed CheckTx because validates_full_state_on_check_tx() for MasternodeVote was only added to Platform in December 2025 (v3.1.0-dev.1 onward); testnet v3.0.x predates it.

The fix — commit d17cfae8 on this branch — normalizes the label at the backend boundary, adds a pre-flight existence check via ContestedResource::fetch_many that short-circuits the retry chain, and introduces a typed TaskError::VotePollNotFound { name } variant with an Everyday-User-persona actionable message. After the fix, TC-090 passes in ~30 s end-to-end (previously: 3 × ~70 s failures).

That same commit is filed as #835 against v1.0-dev for cherry-pick review. On rebase of this branch after #835 merges, git will deduplicate.

Also on this branch:

• ca46282a — wraps per-vote TaskError in Arc inside BackendTaskSuccessResult::DPNSVoteResults (required because TaskError is deliberately non-Clone).
• 76339e55 — test hardening: TC-090 re-confirms the contested vote poll exists immediately before the vote dispatch via wait_for_dpns_contest, catching poll-disappearance races.

Full-suite verification

Ran the full backend-e2e suite (68 tests, --release, --ignored) against this branch tip (76339e55) in 408 s (~7 min) on testnet.

PR 827 canaries — all PASS:

Test	Status
TC-084 Load Masternode	PASS
TC-085 Load Evonode	PASS
TC-086 Load MN voting key only	PASS
TC-087 Refresh MN identity	PASS
TC-088 Invalid ProTx	PASS
TC-089 Wrong voting key	PASS
TC-090 Vote with MN voter	PASS

Other suite failures — pre-existing, not regressions:

Test	Failure shape
core_tasks::tc_003 / tc_006 / tc_009	Core-RPC ConnectionRefused — SPV-only single-key wallet tasks still call dashd without SPV fallback
wallet_tasks::tc_014 / tc_018	Asset-lock IS proof ConfirmationTimeout in SPV mode
identity_tasks::tc_020	AddKeyToIdentity → InvalidIdentityRevisionError (stale revision)
dashpay_tasks::tc_037 / tc_043	Cross-run DashPay contact pollution — Platform inboxes persist between runs
z_broadcast_st_tasks::tc_066	Broadcast success but key missing on read-after-write

None of these failures touch code modified by this PR. They live in test modules introduced in #818 (the framework PR) and fail against v1.0-dev directly. Filing them as follow-ups is out of scope for #827.

Test plan

• cargo clippy --all-features --all-targets -- -D warnings passes
• cargo +nightly fmt --all -- --check passes
• TC-088 (invalid ProTx) runs without env vars — always exercises error path
• TC-084–TC-090 skip gracefully when E2E_MN_PROTX_HASH is unset
• TC-090 passes against testnet with the normalization fix (30.11 s, isolated run)
• Full backend-e2e suite: all 7 PR 827 canaries PASS (408 s, release mode)

_{🤖 Co-authored by Claudius the Magnificent AI Agent}

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1a824005-6304-4562-a00b-bd7bbcebf132

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/mn-identity-e2e

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}