refactor(ui): migrate Panel to show_inside(ui, …) and remove all egui 0.34 deprecation suppressions

[lklimek]

Summary

Follow-up to #857 (egui 0.33.3 → 0.34.2 upgrade). Removes the 27 #[allow(deprecated)] suppressions left by the upgrade PR's containment strategy by performing the structural migration deferred there:

• Flips the ScreenLike::ui trait signature from &Context to &mut egui::Ui (60+ screens, mechanical)
• Migrates the 9 panel helpers (island_central_panel, add_top_panel, add_left_panel, add_left_wallet_panel, plus the 5 chooser panels) from Panel::show(ctx, …) to Panel::show_inside(ui, …)
• Migrates the 17 direct egui::CentralPanel::default().show(ctx, …) sites in screens to show_inside(ui, …)
• Renames axis-non-agnostic Panel methods to their axis-agnostic forms (default_width → default_size, min_width/max_width → min_size/max_size)
• Removes the TODO(egui-0.35) breadcrumb planted by the upgrade PR
• Updates CLAUDE.md "Screen Pattern" section to document the new &mut Ui signature

After this PR, zero egui-related #[allow(deprecated)] suppressions remain anywhere in the codebase. The 6 AES-ECB / DIP-0015 suppressions in src/model/wallet/ and src/backend_task/dashpay/ are intentional cryptographic protocol choices (unrelated to egui) and remain untouched.

Why "Option A" wasn't viable

The upgrade PR's optimistic plan was to leave the trait alone and only flip panel helpers to take &mut Ui. That doesn't work: panel helpers are invoked from inside Screen::ui(ctx) bodies (not from App::ui directly), so the only &Context available at the helper boundary is the screen's own. Wrapping each screen in a synthetic CentralPanel::show(ctx, …) adapter to obtain a Ui would re-introduce the same deprecated call we're trying to remove. The trait flip is the only clean path.

Commit decomposition (4 refactor + 1 doc)

1. refactor(ui): rename Panel axis-agnostic methods (default/min/max_size) — trait-stable, removes one class of deprecation
2. refactor(ui): flip ScreenLike::ui to &mut Ui and migrate panel helpers to show_inside — semantically one refactor (squashed because the trait flip leaves the standalone commit with unused Context imports that the helper signature flip cleans up)
3. refactor(ui): migrate screen central panels to show_inside(ui, …) — last 17 deprecation sites
4. refactor(ui): drop egui-0.35 TODO breadcrumb after panel migration
5. docs: update ScreenLike::ui signature in CLAUDE.md after trait flip

Every commit compiles cleanly and passes cargo clippy --all-features --all-targets -- -D warnings.

Stack

This PR targets chore/upgrade-egui-0.34 (#857). It should be reviewed and merged after #857 lands; GitHub will auto-rebase the base.

User-visible impact

None. Pure internal refactor — no UX changes, no functional changes, no string changes (no i18n surface touched).

Test plan

• cargo build --all-features clean
• cargo +nightly fmt --all -- --check clean
• cargo clippy --all-features --all-targets -- -D warnings clean — at every commit (verified by checking out each intermediate SHA, not just HEAD)
• cargo test --all-features --workspace — 553 tests pass (468 unit + 10 e2e + 72 kittest + 3 doctests; ignored: 2 unit + 14 doctests + 59 backend-e2e)
• cargo test --test kittest --all-features — 72/72 pass (matches PR chore(deps): upgrade egui to 0.34.2 #857 baseline)
• Manual smoke (out-of-band, before merge): launch cargo run, navigate the seven root screens (Identities, DPNS, Wallets, Tools, Contracts, Tokens, Settings), open at least one info popup per dashpay subscreen. Watch for unexpected double-frames, vanished margins, or banner placement drift. The migration is layout-equivalent in egui's own model, but verify visually.

Notes for reviewers

• Trait change is internal: ScreenLike::ui(&mut self, ui: &mut Ui) is an internal API. No external callers.
• ctx.global_style() not ui.style(): where helpers needed global theme (e.g. outer-frame coloring), the substitution is ui.ctx().global_style() — preserving global semantics. ui.style() (local cumulative style) was deliberately not used in those positions; see PR chore(deps): upgrade egui to 0.34.2 #857 QA-002.
• Context::style() itself deprecated: in egui 0.34 — Bilby substituted ui.ctx().global_style() rather than ui.ctx().style() to avoid re-introducing a deprecation. Documented in commit 2.
• IDE may flag pre-existing tests/backend-e2e/ errors (unresolved wallets()/db()/sdk() accessors). These are gated by #[cfg(any(test, feature = "testing"))] in src/context/mod.rs:862; rust-analyzer doesn't enable --features testing by default. cargo build --all-features and cargo test --all-features --workspace resolve them. Configure rust-analyzer with "rust-analyzer.cargo.features": "all" if the noise bothers you.

_{🤖 Co-authored by Claudius the Magnificent AI Agent}

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9dd84b5b-29bd-4259-b49a-db4bd57b348d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/egui-show-inside-migration

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}