Dependencies build failed on MacOS

[osnwt]

Can't build Dash dependencies on MacOS 10.14.6 (latest), Xcode 10.3 (latest) due to two errors:

depends/funcs.mk must use quotes:
$(1)_config_env+=PATH="$(build_prefix)/bin:$(PATH)"
$(1)_build_env+=PATH="$(build_prefix)/bin:$(PATH)"
$(1)_stage_env+=PATH="$(build_prefix)/bin:$(PATH)"

Otherwise when PATH has components with spaces (say, VMware Fusion is installed which adds such path to the PATH), it can't start build. Example of such PATH:

/Users/os/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/VMware Fusion.app/Contents/Public:/usr/local/share/dotnet:/opt/X11/bin:~/.dotnet/tools:/Library/Frameworks/Mono.framework/Versions/Current/Commands

boost build can't find unistd.h:

Performing configuration checks

    - 32-bit                   : no  (cached)
    - 64-bit                   : yes (cached)
    - arm                      : no  (cached)
    - mips1                    : no  (cached)
    - power                    : no  (cached)
    - sparc                    : no  (cached)
    - x86                      : yes (cached)
    - symlinks supported       : yes (cached)
    - lockfree boost::atomic_flag : no  (cached)

Component configuration:

    - atomic                   : not building
    - chrono                   : building
    - container                : not building
    - context                  : not building
    - coroutine                : not building
    - coroutine2               : not building
    - date_time                : not building
    - exception                : not building
    - fiber                    : not building
    - filesystem               : building
    - graph                    : not building
    - graph_parallel           : not building
    - iostreams                : not building
    - locale                   : not building
    - log                      : not building
    - math                     : not building
    - metaparse                : not building
    - mpi                      : not building
    - program_options          : building
    - python                   : not building
    - random                   : not building
    - regex                    : not building
    - serialization            : not building
    - signals                  : not building
    - system                   : building
    - test                     : building
    - thread                   : building
    - timer                    : not building
    - type_erasure             : not building
    - wave                     : not building

...patience...
...patience...
...found 1751 targets...
...updating 79 targets...
darwin.compile.c++ bin.v2/libs/system/build/darwin-4.2.1/release/link-static/threading-multi/error_code.o

    "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++" "-mmacosx-version-min=10.8" "-stdlib=libc++" "-fvisibility=hidden"  -ftemplate-depth-128 -std=c++11 -fvisibility=hidden     -I/Users/os/Projects/Coins/Web.Dash/dash-agm/depends/x86_64-apple-darwin18.7.0/include     -O3 -Wall -pedantic -gdwarf-2 -fexceptions -Wno-long-long -Wno-inline -arch x86_64  -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_STATIC_LINK=1 -DNDEBUG  -I"." -c -o "bin.v2/libs/system/build/darwin-4.2.1/release/link-static/threading-multi/error_code.o" "libs/system/src/error_code.cpp"

In file included from libs/system/src/error_code.cpp:16:
In file included from ./boost/system/error_code.hpp:14:
In file included from ./boost/system/config.hpp:13:
In file included from ./boost/config.hpp:57:
In file included from ./boost/config/platform/macos.hpp:28:
./boost/config/posix_features.hpp:18:15: fatal error: 'unistd.h' file not found
#     include <unistd.h>
              ^~~~~~~~~~
1 error generated.

I fixed it somehow recently, but did not write how. So facing the same issue again which should be fixed or documented.

[UdjinM6]

depends/funcs.mk must use quotes:

This sounds similar to #2939 i.e. you need to fix the broken PATH first, in this case smth like export PATH=$(echo "$PATH" | sed -e 's/ /\\ /g').

boost build can't find unistd.h:

You need open /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg workaround to make it work with recent XCode.

[osnwt]

For PATH: this looks like a workaround assuming I did not put paths with spaces by hand (it was Fusion installer). So if it works on Windown/Linux as well, it should be fixed instead of requiring undocumented (or even documented) workaround, isn't it?

For headers: is it documented somewhere in Dash docs? I don't have this package, where should it be taken from?

[osnwt]

About headers: I'd recommend to add to docs that simple upgrade of Xcode and Command line tools for it may be not enough to build Dash on MacOS. For me, everything was upgraded, but this package was missing. I had to download Tools installer and install them over to get this package, then install headers. It fixes the issue, but would be nice if it was documented.

[PastaPastaPasta]

Resolved