Refactor masternode management#1611
Conversation
UdjinM6
force-pushed
the
refactorMnodeman
branch
2 times, most recently
from
37d0065 to
7a61630
Compare
codablock
left a comment
codablock
left a comment
There was a problem hiding this comment.
👍
Nice refactoring, all looks good.
There was a problem hiding this comment.
Hmm not introduced by this PR, but why is there a critical section in CMasternode if it is not locked in this case (and maybe other cases)?
EDIT: Ah, after reviewing the commits after this one I've seen that you removed all direct access to the CMasternode instances from outside of CMasternodeMan 👍
This probably means that there is no need for the critical section in CMasternode anymore?
There was a problem hiding this comment.
Hmmm... seems like critical section isn't doing much in CMasternode at all... but it doesn't break anything either, so I'd keep it for now. I have another set of changes for locks specifically (in local repo), so that probably would be a better place to change this.
There was a problem hiding this comment.
Wondering why CMasternodeMan needs to be serialized. mncache.dat?
If it's really serialized, this may result in incompatibility.
There was a problem hiding this comment.
Good point! I'll bump CMasternodeMan::SERIALIZATION_VERSION_STRING
… in CMasternodeMan
UdjinM6
force-pushed
the
refactorMnodeman
branch
from
dbf2c25 to
0b614fe
Compare
|
rebased to fix conflicts after #1615 |
This is dirty fix to support dashpay/dash#1611
2 participants
Various refactoring for
CMasternodeMan+ long postponedCTxIn vin -> COutPoint outpoint.Note: there are no changes on serialization/network level yet, so some legacy classes are still going to use
CTxIn vin-like members. Changing this will require network upgrade, I'll submit this patch as a separate PR later - this could potentially break network compatibility and it doesn't qualify for simple refactoring anyway... Or we could postpone this last bit till 12.3 to simplify 12.2 testing.Commits are atomic, can be reviewed separately, one by one.