Add forkpoint to getchaintips#2039
Merged
Merged
Conversation
1 task
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Mar 1, 2019
DashCoreAutoGuix
pushed a commit
to DashCoreAutoGuix/dash
that referenced
this pull request
Jul 28, 2025
…ockstore de8f912 test: cover read-only blockstore (Matthew Zipkin) 5c2185b ci: enable chattr +i capability inside containers (Matthew Zipkin) e573f24 unit test: add coverage for BlockManager (Matthew Zipkin) Pull request description: This PR adds unit and functional tests to cover the behavior described in dashpay#2039. In particular, that bitcoind will crash on startup if a reindex is requested but the `blk` files are read-only. Eventually this behavior can be updated with bitcoin#27039. This PR just commits the test coverage from bitcoin#27039 as suggested in bitcoin#27039 (comment) ACKs for top commit: jonatack: ACK de8f912 modulo suggestions in bitcoin#27850 (comment), tested on macOS, but not on Linux for the Linux-related change in the last push achow101: ACK de8f912 MarcoFalke: lgtm ACK de8f912 📶 Tree-SHA512: b9bd684035dcea11c901b649fc39f397a2155a9a8459f3348e67947e387e45312fddeccb52981aef486f8a31deebb5356a7901c1bb94b78f82c24192a369af73
DashCoreAutoGuix
pushed a commit
to DashCoreAutoGuix/dash
that referenced
this pull request
Aug 3, 2025
…ockstore de8f912 test: cover read-only blockstore (Matthew Zipkin) 5c2185b ci: enable chattr +i capability inside containers (Matthew Zipkin) e573f24 unit test: add coverage for BlockManager (Matthew Zipkin) Pull request description: This PR adds unit and functional tests to cover the behavior described in dashpay#2039. In particular, that bitcoind will crash on startup if a reindex is requested but the `blk` files are read-only. Eventually this behavior can be updated with bitcoin#27039. This PR just commits the test coverage from bitcoin#27039 as suggested in bitcoin#27039 (comment) ACKs for top commit: jonatack: ACK de8f912 modulo suggestions in bitcoin#27850 (comment), tested on macOS, but not on Linux for the Linux-related change in the last push achow101: ACK de8f912 MarcoFalke: lgtm ACK de8f912 📶 Tree-SHA512: b9bd684035dcea11c901b649fc39f397a2155a9a8459f3348e67947e387e45312fddeccb52981aef486f8a31deebb5356a7901c1bb94b78f82c24192a369af73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it a lot easier to figure out at what block exactly the fork actually happened.