Fix mnodeman.cs vs cs_vPendingMasternodes vs cs_main deadlock#2200
Merged
Conversation
Decouple cs_vPendingMasternodes from mnodeman.cs to fix the issue. Also drop deprecated/unused stuff in mnv preparation while at it.
| std::vector<CAddress> vAddr; | ||
|
|
||
| int nCount = 0; | ||
| { |
Member
There was a problem hiding this comment.
This brace does not appear to get closed... What am I missing?
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
Yep, I tried to keep changes minimal here.
Member
There was a problem hiding this comment.
I would think we should indent properly then. Personal preference I guess
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
May 21, 2019
…y#2200) Decouple cs_vPendingMasternodes from mnodeman.cs to fix the issue. Also drop deprecated/unused stuff in mnv preparation while at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's a circular one. Decouple
cs_vPendingMasternodesfrommnodeman.csto fix the issue. Also drop deprecated/unused stuff inmnvpreparation while at it.