Modernize Gov Methods#2326
Merged
Merged
Conversation
InhumanPerfection
left a comment
InhumanPerfection
left a comment
There was a problem hiding this comment.
Some Copy & Pasta 😜 went wrong. See inline comments.
There was a problem hiding this comment.
std::map<vote_signal_enum_t, std::string>
and name mapSignalString instead of mapSignalsString?
There was a problem hiding this comment.
Keep capitalized all returned strings? -or- Make this lowercase as well?
There was a problem hiding this comment.
std::map<std::string, vote_outcome_enum_t>
There was a problem hiding this comment.
I'm not familiar with formatting, can it handle nOutcome as %s?
Member
Author
There was a problem hiding this comment.
I wouldn't experiment with this and would simply use %d :)
Member
Author
|
🙈 🙈 🙈 |
…rtOutcomeToString" This reverts commit 41bc3d3.
PastaPastaPasta
force-pushed
the
gov-modernize
branch
from
fc39e8f to
4daa269
Compare
added 2 commits
October 7, 2018 14:20
Member
Author
|
Please re-review |
InhumanPerfection
suggested changes
Oct 8, 2018
|
|
||
| const auto& it = mapOutcomeString.find(nOutcome); | ||
| if (it == mapOutcomeString.end()) { | ||
| LogPrintf("CGovernanceVoting::%d -- ERROR: Unknown outcome %d\n", __func__, nOutcome); |
Member
Author
|
Please re-review |
|
hmmm... bd8d7ae is doing too much, I expected smth like |
Member
Author
|
My bad 🙈 |
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
May 21, 2019
* governance.* formatting and copyright bump * manual changes gov.cpp * Modernize ConvertVoteOutcome, ConvertSignalToString and ConvertOutcomeToString * move breaks * add braces instead of inlining * Revert "Modernize ConvertVoteOutcome, ConvertSignalToString and ConvertOutcomeToString" This reverts commit 41bc3d3. * Modernize ConvertVoteOutcome, ConvertSignalToString and ConvertOutcomeToString * fix bugs * make "NONE" lowercase * revert merge error * @InhumanPerfection comments fix * whoops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only need to look at 7566796, currently based on #2324, will be rebased once #2324 has been merged