Fix IsBlockPayeeValid#2577
Merged
Merged
Conversation
UdjinM6
commented
Dec 21, 2018
UdjinM6
commented
- should skip while not synced regardless of spork15 state
- add missing logprintf
- should skip while not synced regardless of spork15 state - add missing logprintf
Author
|
Author
|
Actually, no, shouldn't be reverted - we can't rely on gobject data while not yet synced. This one is still not on-chain/deterministic. |
|
Then instead of reverting, we should change it to only skip superblock verification on IBD/reindex and still do the MN payee checks. |
Author
Agree, this makes sense. |
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Jun 29, 2020
- should skip while not synced regardless of spork15 state - add missing logprintf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.