Backports 0.16 pr1-4: other by PastaPastaPasta · Pull Request #3106 · dashpay/dash

PastaPastaPasta · 2019-09-24T01:18:22Z

based on #3102, but I figured since this one is a lilttle big, it'd be nice to get it out there for you to enjoy reviewing

PastaPastaPasta · 2019-09-24T12:39:31Z

rebased on develop

PastaPastaPasta · 2019-11-19T16:34:42Z

rebased, tests passing locally

PastaPastaPasta · 2019-12-09T16:53:33Z

rebased

UdjinM6

Pls see UdjinM6@f6c8fb7, UdjinM6@593d310, UdjinM6@ff9e6bf, UdjinM6@9acbfb3 and a suggestion below

UdjinM6

Looks mostly ok IMO, just one more thing

PastaPastaPasta · 2019-12-21T23:13:09Z

backported part of 12917

UdjinM6 · 2019-12-22T00:46:21Z

Looks good and gitlab is happy too now 🎉

UdjinM6

utACK

Ooops... needs rebase now

UdjinM6 · 2019-12-31T14:36:37Z

@PastaPastaPasta pls make sure to apply fixes from 11179 to new rpc/privatesend.cpp while rebasing i.e. adding parts of 976b51e (as in rpc/masternode.cpp) and dropping okSafe in commands.

codablock

See inline comments. I prepared fixes as well:
0f46840
fbe7be5
80214e6
9b62a29
All found in my repo.

UdjinM6 · 2020-01-02T03:22:05Z

Well, this PR became pretty messy imo... It feels like we should really split it into a couple of separate ones (and squash fixes into original "merge bitcoin#xxx" commits while doing so). I would propose smth like:

trivial comments/docs/strings updates;
trivial-ish virtual, const, nullptr etc. code changes (and maybe functional tests cleanups too);
rpc changes;
other actual code changes (connman, cli etc.)

Thoughts?

PastaPastaPasta · 2020-01-02T03:46:13Z

rebased on backports-0.16-pr1-trivial

UdjinM6 · 2020-01-03T10:52:08Z

Pls see UdjinM6@442d538

8f2f1e0 wallet: Avoid second mapWallet lookup (João Barbosa) Pull request description: All calls to `mapWallet.count()` have the intent to detect if a `txid` exists and most are followed by a second lookup to retrieve the `CWalletTx`. This PR replaces all `mapWallet.count()` calls with `mapWallet.find()` to avoid the second lookup. Tree-SHA512: 96b7de7f5520ebf789a1aec1949a4e9c74e13683869cee012f717e5be8e51097d068e2347a36e89097c9a89f1ed1a1529db71760dac9b572e36a3e9ac1155f29 More of 11039

…that will not return b82c55a Add attribute [[noreturn]] (C++11) to functions that will not return (practicalswift) Pull request description: Add attribute `[[noreturn]]` (C++11) to functions that will not return. Rationale: * Reduce the number of false positives/false negatives from static analyzers with regards to things such as unused or unreachable code * Potentially enable additional compiler optimizations Tree-SHA512: 899683fe8b2fcf19bd334352271d368b46b805be9d426aac1808335fd95732d6d7078d3296951b9879196f3f6e3ec0fdb7695d0afdc3fbe4dd78a2ca70e91ff7 Signed-off-by: Pasta <pasta@dashboost.org> Fixes for bitcoin#10843 backport 10843 continued Signed-off-by: Pasta <pasta@dashboost.org>

…rks. a473eff [bench] Replace 0.00(000)1 with MICRO/MILLI #defines in validation.cpp. (Karl-Johan Alm) 5f850b0 [bench] Include ms/blk stats in Connect* benchmarks. (Karl-Johan Alm) Pull request description: Display the average per block runtime for the various benchmarked times in the block connect functions to give an overview of long(er) term time distribution statistics. Tree-SHA512: 3d6f24f6b9e3dbb448a647e2cda8e7b90ad6a16d4821f49f426a8e1ebc3ce5a0cf0a8cde82213e293affba441615702dfe50822c8c818e282af03bfe383d83e0 More of 10303

352d582 Add vConnect to CConnman::Options (Marko Bencun) Pull request description: Split the "-connect" argument parsing out of CConnman and put it into AppInitMain(). Tree-SHA512: f2d3efc4e2c5808ff98696ea20dd96df599bc472ed5afc9c3eea305d94c36a6ab50c632aa05396c7c34d1917d91b1e7ccd725656ff2631e2a36d9eac477455dc

…generic "cancelable" ee4d149 Drop upgrade-cancel callback registration for a generic "resumeable" (Matt Corallo) Pull request description: Instead of passing a StartShutdown reference all the way up from txdb, give ShowProgress a "cancelable" boolean, as StartShutdown is pretty much always what you'll want to use to cancel. Use the same boolean to allow cancel during initial block verification. Tree-SHA512: 515817aaa4b9e3e856200e00be9c2d44ecfa2d4f288fe3e02116105fe85de2650c13076ee7e45396ec1ce6ab45e53b0477cddda7cfdee5b3bd0589cb81a4c346

PastaPastaPasta · 2020-01-03T14:36:09Z

cherry-picked and squashed

UdjinM6

utACK

UdjinM6 · 2020-01-03T19:37:38Z

ping @codablock (I'd like to merge this one first before merging other PRs).

codablock

utACK

PastaPastaPasta force-pushed the backports-0.16-pr1 branch from 8836221 to 7eeaa67 Compare September 24, 2019 12:36

PastaPastaPasta force-pushed the backports-0.16-pr1 branch from 7eeaa67 to 028a254 Compare November 19, 2019 15:39

UdjinM6 reviewed Nov 19, 2019

View reviewed changes

Comment thread src/rpc/masternode.cpp Outdated

UdjinM6 requested changes Nov 21, 2019

View reviewed changes

Comment thread test/functional/mempool_persist.py Outdated

Comment thread contrib/rpm/README.md Outdated

Comment thread test/functional/test_framework/util.py Outdated

PastaPastaPasta force-pushed the backports-0.16-pr1 branch from df4bea3 to d8bc24f Compare November 21, 2019 18:23

PastaPastaPasta force-pushed the backports-0.16-pr1 branch from bdc0ffe to 7d34323 Compare December 9, 2019 16:53

UdjinM6 added this to the 16 milestone Dec 12, 2019

PastaPastaPasta requested a review from UdjinM6 December 19, 2019 17:31

UdjinM6 requested changes Dec 20, 2019

View reviewed changes

Comment thread CONTRIBUTING.md Outdated

PastaPastaPasta requested a review from UdjinM6 December 21, 2019 15:54

UdjinM6 reviewed Dec 21, 2019

View reviewed changes

Comment thread test/functional/mempool_persist.py Outdated

UdjinM6 requested a review from codablock December 21, 2019 18:36

PastaPastaPasta requested a review from UdjinM6 December 22, 2019 00:47

UdjinM6 previously approved these changes Dec 22, 2019

View reviewed changes

codablock reviewed Dec 31, 2019

View reviewed changes

UdjinM6 mentioned this pull request Jan 1, 2020

Fix params.size() check in "protx list wallet" RPC #3259

Merged

PastaPastaPasta force-pushed the backports-0.16-pr1 branch from 60e719e to 659856f Compare January 1, 2020 23:39

UdjinM6 reviewed Jan 2, 2020

View reviewed changes

Comment thread src/rpc/server.cpp Outdated

Comment thread src/rpc/server.cpp Outdated

Comment thread src/rpc/rpcevo.cpp Outdated

Comment thread src/rpc/rpcevo.cpp Outdated

PastaPastaPasta force-pushed the backports-0.16-pr1 branch from 659856f to bcc4b27 Compare January 2, 2020 03:46

PastaPastaPasta force-pushed the backports-0.16-pr1 branch 2 times, most recently from 45bbaea to d7a22c4 Compare January 2, 2020 22:16

PastaPastaPasta force-pushed the backports-0.16-pr1 branch 3 times, most recently from ba1ca29 to 15b009b Compare January 2, 2020 22:49

PastaPastaPasta changed the title ~~Backports 0.16 pr1~~ Backports 0.16 pr1 other Jan 2, 2020

PastaPastaPasta force-pushed the backports-0.16-pr1 branch from 31c8b16 to 6ac77d4 Compare January 2, 2020 22:52

PastaPastaPasta requested review from UdjinM6 and codablock January 2, 2020 22:52

PastaPastaPasta changed the title ~~Backports 0.16 pr1 other~~ Backports 0.16 pr1-4: other Jan 2, 2020

laanwj and others added 5 commits January 3, 2020 08:35

PastaPastaPasta force-pushed the backports-0.16-pr1 branch from c0b94c3 to 2aa7ca5 Compare January 3, 2020 14:36

UdjinM6 approved these changes Jan 3, 2020

View reviewed changes

codablock approved these changes Jan 4, 2020

View reviewed changes

UdjinM6 merged commit e82dfc4 into dashpay:develop Jan 4, 2020

PastaPastaPasta deleted the backports-0.16-pr1 branch January 4, 2020 16:48

Conversation

PastaPastaPasta commented Sep 24, 2019

Uh oh!

PastaPastaPasta commented Sep 24, 2019

Uh oh!

PastaPastaPasta commented Nov 19, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PastaPastaPasta commented Dec 9, 2019

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

UdjinM6 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PastaPastaPasta commented Dec 21, 2019

Uh oh!

UdjinM6 commented Dec 22, 2019

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 commented Dec 31, 2019

Uh oh!

codablock left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

UdjinM6 commented Jan 2, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PastaPastaPasta commented Jan 2, 2020

Uh oh!

UdjinM6 commented Jan 3, 2020

Uh oh!

PastaPastaPasta commented Jan 3, 2020

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 commented Jan 3, 2020

Uh oh!

codablock left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

UdjinM6 left a comment •

edited

Loading