Introduce getprivatesendinfo and deprecate getpoolinfo#3140
Merged
Conversation
codablock
reviewed
Oct 7, 2019
codablock
previously approved these changes
Oct 7, 2019
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Concept ACK, will try to review / test tonight... But that might not happen
thephez
reviewed
Oct 17, 2019
| " \"multisession\": true|false, (bool) Whether PrivateSend Multisession option is enabled\n" | ||
| " \"max_sessions\": xxx, (numeric) How many parallel mixing sessions can there be at once\n" | ||
| " \"max_rounds\": xxx, (numeric) How many rounds to mix\n" | ||
| " \"max_amount\": xxx, (numeric) How many " + CURRENCY_UNIT + " to keep anonimized\n" |
Collaborator
There was a problem hiding this comment.
@UdjinM6 Just found this one.
s/anonimized/anonymized/
Author
There was a problem hiding this comment.
🙈
smth to fix together with other trivial fixes I guess :)
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Feb 16, 2025
…rnode winner` and `getpoolinfo` 7c81d53 chore: drop deprecated CoinJoin RPC `getpoolinfo` (Kittywhiskers Van Gogh) 7cdd4f3 chore: drop deprecated `masternode` RPC verbs `winner` and `current` (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * `masternode current`, `masternode winner` were deprecated in [dash#4060](#4060), which was included in Dash Core v0.17 * `getpoolinfo` was deprecated in [dash#3140](#3140), which was included in Dash Core v0.15. ## Breaking Changes Deprecated RPCs will no longer be available. ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 7c81d53 knst: utACK 7c81d53 Tree-SHA512: 3ee21be2114ebeb139694f77fe6dfc30ee6f9404db6b0aa328a8179a9091b189bf6494e5c54b637aa1ab4f06fa7c3edc6bba26eab2a97b5f987fcd66952040b6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getpoolinfois not very useful atm (way too simplistic and wasn't updated to show correct info when mixing in parallel sessions), and also, the name is confusing. Introducinggetprivatesendinfoto fix these issues.