Skip to content

Backport "--failfast" and "--ci" for test_runner.py#3281

Merged
codablock merged 2 commits into
dashpay:developfrom
codablock:pr_backport_14630
Jan 8, 2020
Merged

Backport "--failfast" and "--ci" for test_runner.py#3281
codablock merged 2 commits into
dashpay:developfrom
codablock:pr_backport_14630

Conversation

@codablock
Copy link
Copy Markdown

This backports bitcoin#13105 and bitcoin#14630. One test is current timing out in #3277, causing Travis and Gitlab to timeout without any meaningful info. This PR will allow us to debug such cases.

@codablock codablock added this to the 16 milestone Jan 7, 2020
Comment thread test/functional/test_runner.py Outdated
Comment thread test/functional/test_runner.py Outdated
laanwj and others added 2 commits January 7, 2020 23:12
…nner

58f9a0a Use --failfast when running functional tests on Travis (James O'Beirne)
bf720c1 Add --failfast option to functional test runner (James O'Beirne)

Pull request description:

  Add the option (`--failfast`) to stop the functional test runner's execution when it encounters the first failure.

  Also cleans up run_test's arguments list ([no more mutable default for `args`](http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments)) and call site.

Tree-SHA512: e854b1b1634bf613ae8ae88e715df1460982fa68db9d785aafeb5eccf5bf324c7f20dded2ca6840ebf18a28347ecac2138d6c7592507b34939b02609ef55e1b3
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UtACK

Copy link
Copy Markdown

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock codablock merged commit e732a92 into dashpay:develop Jan 8, 2020
@codablock codablock deleted the pr_backport_14630 branch January 8, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants