Skip to content

qt: Add missing placeholders #3575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UdjinM6 merged 7 commits into from
Jul 27, 2020
Merged

qt: Add missing placeholders #3575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
951a294
qt: Add more placeholder in ReceiveCoinsDialog
xdustinface Jun 24, 2020
b46e6df
qt: Add placeholder for filter line edit in MasternodeList
xdustinface Jun 24, 2020
a007552
qt: Add more placerholder in SignVerifyMessageDialog
xdustinface Jun 24, 2020
2e1d2dd
qt: Removes a dot
xdustinface Jul 22, 2020
d7f947b
qt: Adjust placeholder phrasing in ReceiveCoinsDialog
xdustinface Jul 22, 2020
17c951d
Apply suggestions from code review
xdustinface Jul 22, 2020
742f94d
qt: Align wording of placeholders with the corresponding tooltip
xdustinface Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/qt/masternodelist.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ MasternodeList::MasternodeList(QWidget* parent) :

ui->tableWidgetMasternodesDIP3->setContextMenuPolicy(Qt::CustomContextMenu);

ui->filterLineEditDIP3->setPlaceholderText(tr("Filter by any property (e.g. address or protx hash)"));

QAction* copyProTxHashAction = new QAction(tr("Copy ProTx Hash"), this);
QAction* copyCollateralOutpointAction = new QAction(tr("Copy Collateral Outpoint"), this);
contextMenuDIP3 = new QMenu(this);
Expand Down
3 changes: 3 additions & 0 deletions src/qt/receivecoinsdialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ ReceiveCoinsDialog::ReceiveCoinsDialog(QWidget* parent) :
ui->label_2,
ui->label_3}, GUIUtil::FontWeight::Normal, 15);

ui->reqLabel->setPlaceholderText(tr("Enter a label to associate with the new receiving address"));
ui->reqMessage->setPlaceholderText(tr("Enter a message to attach to the payment request"));

// context menu actions
QAction *copyURIAction = new QAction(tr("Copy URI"), this);
QAction *copyLabelAction = new QAction(tr("Copy label"), this);
Expand Down
5 changes: 5 additions & 0 deletions src/qt/signverifymessagedialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,13 @@ SignVerifyMessageDialog::SignVerifyMessageDialog(QWidget* parent) :
pageButtons.addButton(ui->btnVerifyMessage, pageButtons.buttons().size());
connect(&pageButtons, SIGNAL(buttonClicked(int)), this, SLOT(showPage(int)));

ui->messageIn_SM->setPlaceholderText(tr("Enter a message to be signed"));
ui->signatureOut_SM->setPlaceholderText(tr("Click \"Sign Message\" to generate signature"));

ui->messageIn_VM->setPlaceholderText(tr("Enter a message to be verified"));
ui->signatureIn_VM->setPlaceholderText(tr("Enter a signature for the message to be verified"));

// These icons are needed on Mac also
ui->addressBookButton_SM->setIcon(QIcon(":/icons/address-book"));
ui->pasteButton_SM->setIcon(QIcon(":/icons/editpaste"));
ui->copySignatureButton_SM->setIcon(QIcon(":/icons/editcopy"));
Expand Down