qt: Call GUIUtil::loadFonts earlier#3593
Merged
Merged
Conversation
Before there is any usage of the font helpers.
UdjinM6
changed the title
UdjinM6
previously approved these changes
Jul 8, 2020
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Looks good and font cmd-line settings still work as expected.
Slightly tested ACK
gitlab is having some internal issues though, so we'll have to wait until it's fixed and tests are green
PastaPastaPasta
requested changes
Jul 8, 2020
Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 1, 2020
* qt: Call GUIUtil::loadFonts earlier. Before there is any usage of the font helpers. * Apply review suggestion Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 10, 2022
* qt: Call GUIUtil::loadFonts earlier. Before there is any usage of the font helpers. * Apply review suggestion Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in #3555 but i just realised
BitcoinCore::baseInitializeisn't the best place to load the fonts. Reason why i moved it to where is is with this PR:OptionsModelwhich is required because we will later have font realted settings and their defaults should be set before the call ofGUIUtil::loadFonts.GUIUtil::loadFonts.