qt: Make sure stylesheet updates of -debug-ui are activated#3623
Merged
Conversation
This reverses force logic of `GUIUtil::loadTheme` to not force by default and instead forces it explicit in appearance widgets call. Due to `fForce` beeing default the ui debug timer wasn't started properly because there was no call of `GUIUtil::loadStylesheet` without `fForce=true` which is a requirement to start the debug timer.
xdustinface
force-pushed
the
pr-ui-fix-debug-ui
branch
from
d9a35bc to
60833a4
Compare
Author
|
Ready for review! |
UdjinM6
approved these changes
Jul 26, 2020
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
I guess you could tweak this line https://github.com/dashpay/dash/blob/develop/src/qt/dash.cpp#L384 instead but unifying loadTheme and loadStyleSheet args is a nice side effect of this PR, so
ACK
Author
jup + force something should just not be the default imo :D |
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 3, 2020
…3623) This reverses force logic of `GUIUtil::loadTheme` to not force by default and instead forces it explicit in appearance widgets call. Due to `fForce` beeing default the ui debug timer wasn't started properly because there was no call of `GUIUtil::loadStylesheet` without `fForce=true` which is a requirement to start the debug timer.
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 10, 2022
…3623) This reverses force logic of `GUIUtil::loadTheme` to not force by default and instead forces it explicit in appearance widgets call. Due to `fForce` beeing default the ui debug timer wasn't started properly because there was no call of `GUIUtil::loadStylesheet` without `fForce=true` which is a requirement to start the debug timer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverses force logic of
GUIUtil::loadThemeto not force by default and instead forces it explicit in appearance widgets call.Due to
fForcebeeing default the ui debug timer wasn't started properly after #3559 because there was no call ofGUIUtil::loadStylesheetwithoutfForce=truewhich is a requirement to start the debug timer.Currently based on #3568