Fix some translation issues#3656
Merged
Merged
Conversation
|
Makes sense. Still one question: There are many places where the term "PrivateSend" is still included in a translated strings. Wouldn't it make sense then to just extract them all then if we are on it already? |
Author
|
Extracting "PrivateSend" (or say "InstantSend") from more complex strings would make it hard for translators to understand/translate them imo (and they would have to translate such strings again while here we just slightly reduce the amount of work for them instead). |
xdustinface
pushed a commit
to xdustinface/dash
that referenced
this pull request
Aug 26, 2020
* Avoid translating "PrivateSend" * Make some strings translatable
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 8, 2020
* Avoid translating "PrivateSend" * Make some strings translatable
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 8, 2022
* Avoid translating "PrivateSend" * Make some strings translatable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.