privatesend|wallet|qt: Improve calculations in CreateDenominated/MakeCollateralAmounts#3657

Merged

UdjinM6 merged 45 commits into

dashpay:developfrom

xdustinface:pr-privatesend-transaction-builder

Sep 1, 2020

Commits on Aug 29, 2020

wallet: Add m_dust_feerate to CCoinControl / Use it in CreateTransaction
xdustinface
committed
privatesend: Introduce CTransactionBuilder/CTransactionBuilderOutput
xdustinface
committed
privatesend: Improve amount/fee calculation in CreateDenominated
xdustinface
committed
privatesend: Improve amount/fee calculation in MakeCollateralAmounts
xdustinface
committed
qt: Fix decomposeTransaction's MakeCollateralAmounts detection
xdustinface
committed
Refactor GetFee

UdjinM6
authored and
xdustinface
committed
Simplify nBytesOutput calculations

UdjinM6
authored and
xdustinface
committed
Drop unused GetBytesOutput()

UdjinM6
authored and
xdustinface
committed
Make Clear(), GetBytesTotal() and GetAmountUsed() private

UdjinM6
authored and
xdustinface
committed
Drop unused GetCoinControl()

UdjinM6
authored and
xdustinface
committed
Make ToString() const

UdjinM6
authored and
xdustinface
committed
Refactor `CTransactionBuilder::Commit()`

UdjinM6
authored and
xdustinface
committed
Reorder cases in decomposeTransaction

UdjinM6
authored and
xdustinface
committed
Fix "finished" conditions in CreateDenominated

UdjinM6
authored and
xdustinface
committed
Fix typo

UdjinM6
authored and
xdustinface
committed
wallet|privatesend: Refactor CCoinControl's m_dust_feerate -> m_discard_feerate
xdustinface
committed
privatesend: Drop unused member CTransactionBuilder::dustFeeRate
xdustinface
committed
privatesend: Improve CTransactionBuilder's readability
xdustinface
committed
privatesend: Make the static CTransactionBuilder::GetAmountLeft private
xdustinface
committed
wallet: Recover previous code style
xdustinface
committed
Update src/privatesend/privatesend-util.cpp

xdustinface
and
UdjinM6
committed
Tweak CTransactionBuilder to respect potential compact size diffs

UdjinM6
authored and
xdustinface
committed
Tweak GetFee param type

UdjinM6
authored and
xdustinface
committed
Trivial log/comments tweaks

UdjinM6
authored and
xdustinface
committed
privatesend: Fix countPossibleOutputs
xdustinface
committed
privatesend: Use GetSizeOfCompactSizeDiff in CTransactionBuilder
xdustinface
committed
Apply suggestions from code review

xdustinface
and
PastaPastaPasta
committed
privatesend: Rename TryAdd to CouldAdd in CTransactionBuilder
xdustinface
committed
wallet: Reset m_discard_feerate in CCoinControl::SetNull
xdustinface
committed
Respect `-paytxfee` and `settxfee`

UdjinM6
authored and
xdustinface
committed
privatesend: Check for denominated amount only where really required
xdustinface
committed
qt: Remove obsolete IsCollateralAmount() checks
xdustinface
committed
privatesend: Don't accept negative amounts in CTransactionBuilder
xdustinface
committed
privatesend: Remove unused CConnman parameter
xdustinface
committed
use emplace_back instead of push_back

PastaPastaPasta
authored and
xdustinface
committed
fix typos

PastaPastaPasta
authored and
xdustinface
committed
make GetAmount const

PastaPastaPasta
authored and
xdustinface
committed
privatesend: Explicit capture __func__ in needMoreOutputs lambda
xdustinface
committed
privatesend: Update CTransactionBuilder::UpdateAmount
xdustinface
committed
remove const on parameter in declaration

PastaPastaPasta
authored and
xdustinface
committed
handle unsigned int -> int conversions a bit better

PastaPastaPasta
authored and
xdustinface
committed
explicitly cast to int from unsigned int.

PastaPastaPasta
authored and
xdustinface
committed

Commits on Aug 30, 2020

Make CTransactionBuilderOutput::GetScript const

xdustinface
and
UdjinM6
authored

Commits on Aug 31, 2020