Harden spork6 logic then remove spork6#3662
Merged
Merged
Conversation
Spork6 was previously activated on testnet, but we then developed an alternative fix for the issue and never activated spork6 on mainnet. At this point, Spork6 will not be activated on mainnet. As such, it makes sense to harden Spork6 and ensure that spork6 will never be activated on mainnet. So, we just change from checking Spork6 to checking if we are on testnet. If we are on testnet, use spork6 logic, else don't. Signed-off-by: pasta <pasta@dashboost.org>
Signed-off-by: pasta <pasta@dashboost.org>
UdjinM6
reviewed
Aug 21, 2020
Signed-off-by: pasta <pasta@dashboost.org>
… on next testnet reset
Member
Author
|
Added your commits |
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 8, 2020
* Harden Spork6 Spork6 was previously activated on testnet, but we then developed an alternative fix for the issue and never activated spork6 on mainnet. At this point, Spork6 will not be activated on mainnet. As such, it makes sense to harden Spork6 and ensure that spork6 will never be activated on mainnet. So, we just change from checking Spork6 to checking if we are on testnet. If we are on testnet, use spork6 logic, else don't. Signed-off-by: pasta <pasta@dashboost.org> * remove now unused SPORK_6_NEW_SIGS Signed-off-by: pasta <pasta@dashboost.org> * force fSporkSixActive to be correct, otherwise return Signed-off-by: pasta <pasta@dashboost.org> * Harden spork6 even more * Add TODO in chainparams as a reminder to drop all spork6 related code on next testnet reset Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 13, 2022
* Harden Spork6 Spork6 was previously activated on testnet, but we then developed an alternative fix for the issue and never activated spork6 on mainnet. At this point, Spork6 will not be activated on mainnet. As such, it makes sense to harden Spork6 and ensure that spork6 will never be activated on mainnet. So, we just change from checking Spork6 to checking if we are on testnet. If we are on testnet, use spork6 logic, else don't. Signed-off-by: pasta <pasta@dashboost.org> * remove now unused SPORK_6_NEW_SIGS Signed-off-by: pasta <pasta@dashboost.org> * force fSporkSixActive to be correct, otherwise return Signed-off-by: pasta <pasta@dashboost.org> * Harden spork6 even more * Add TODO in chainparams as a reminder to drop all spork6 related code on next testnet reset Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commit messages