wallet: Fix and improve CWallet::CreateTransaction#3668

Merged

UdjinM6 merged 22 commits into

dashpay:developfrom

xdustinface:pr-wallet-createtransaction

Sep 4, 2020

Commits on Sep 1, 2020

wallet: Remove unused vecTxDSInTmp in CWallet::CreateTransaction
xdustinface
committed
wallet: Calculate fees earlier and respect them in change determination
xdustinface
committed
wallet: Cleanup obsolete code in CreateTransaction
xdustinface
committed
wallet: Try to pick other inputs if the selected ones are too small
xdustinface
committed
wallet: Break the loop if the transaction is ready
xdustinface
committed
wallet: Respect additional amount from previous cycles
xdustinface
committed
wallet: Respect available in coin selection, try all coins in last round
xdustinface
committed
wallet: Avoid potential infinite loop, just in case..
xdustinface
committed
wallet: Fix signing in CreateTransaction
xdustinface
committed
wallet: Fix change calculation if "subtract fee from amount" is enabled
xdustinface
committed
wallet: Return after fee calc if no or not enough amount available
xdustinface
committed
wallet: Fix break logic if available amount is not enough
xdustinface
committed
Revert "wallet: Fix signing in CreateTransaction"

UdjinM6
authored and
xdustinface
committed
Use a vector of coins instead of a set in CreateTransaction and sort it in a BIP69 compliant way when needed

UdjinM6
authored and
xdustinface
committed
wallet: Adjust comment
xdustinface
committed
Cleaner usage of nChangePosRequest/InOut

UdjinM6
authored and
xdustinface
committed
Simplify some fail/try-again conditions (fixed)

UdjinM6
authored and
xdustinface
committed
Loop through outputs to update change output position only when outputs are sorted for BIP69

UdjinM6
authored and
xdustinface
committed
Avoid implicit conversions of int-s into bool-s

UdjinM6
authored and
xdustinface
committed
Move `nAmountLeft == nFeeRet` check higher, tweak comments

UdjinM6
authored and
xdustinface
committed
wallet: Fix some formatting
xdustinface
committed
wallet: Improve CTxIn creation in CreateTransaction
xdustinface
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wallet: Fix and improve CWallet::CreateTransaction#3668

wallet: Fix and improve CWallet::CreateTransaction#3668
UdjinM6 merged 22 commits into
dashpay:developfrom
xdustinface:pr-wallet-createtransaction

Commits on Sep 1, 2020

wallet: Remove unused vecTxDSInTmp in CWallet::CreateTransaction

wallet: Calculate fees earlier and respect them in change determination

wallet: Cleanup obsolete code in CreateTransaction

wallet: Try to pick other inputs if the selected ones are too small

wallet: Break the loop if the transaction is ready

wallet: Respect additional amount from previous cycles

wallet: Respect available in coin selection, try all coins in last round

wallet: Avoid potential infinite loop, just in case..

wallet: Fix signing in CreateTransaction

wallet: Fix change calculation if "subtract fee from amount" is enabled

wallet: Return after fee calc if no or not enough amount available

wallet: Fix break logic if available amount is not enough

Revert "wallet: Fix signing in CreateTransaction"

Use a vector of coins instead of a set in CreateTransaction and sort it in a BIP69 compliant way when needed

wallet: Adjust comment

Cleaner usage of nChangePosRequest/InOut

Simplify some fail/try-again conditions (fixed)

Loop through outputs to update change output position only when outputs are sorted for BIP69

Avoid implicit conversions of int-s into bool-s

Move `nAmountLeft == nFeeRet` check higher, tweak comments

wallet: Fix some formatting

wallet: Improve CTxIn creation in CreateTransaction