QT: add last block hash to debug ui#3672
Merged
Merged
Conversation
Trivial addition to display last block hash next to last block time
|
Linter is unhappy, see 4566bdc |
UdjinM6
reviewed
Aug 24, 2020
... and linter happy Switch QMetaObject to get last hash from pIndex instead of clientmodel
|
Linter still complains, pls apply 1532975fc3 |
UdjinM6
approved these changes
Aug 26, 2020
PastaPastaPasta
approved these changes
Aug 28, 2020
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
ACK, tested. Code looks good
Comment on lines
+160
to
+161
| if (chainActive.Tip()) | ||
| return QString::fromStdString(chainActive.Tip()->GetBlockHash().ToString()); |
Member
There was a problem hiding this comment.
Suggested change
| if (chainActive.Tip()) | |
| return QString::fromStdString(chainActive.Tip()->GetBlockHash().ToString()); | |
| if (chainActive.Tip()) return QString::fromStdString(chainActive.Tip()->GetBlockHash().ToString()); |
There was a problem hiding this comment.
IMO it's ok-ish since it's kind of a copy-paste like thing of the function above.
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 8, 2020
* [QT] Add last block hash to debug ui Trivial addition to display last block hash next to last block time * [QT] Make last block hash selectable ... and linter happy Switch QMetaObject to get last hash from pIndex instead of clientmodel * [Trivial] Fix trailing whitespaces
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Apr 14, 2021
…t block hash next to last block time Backport of Dash Core [PR#3672](dashpay/dash#3672) and [PR#3685](dashpay/dash#3685) Fixes Bitcoin-ABC#224 Test plan: `ninja check`; and try the UI (open Debug Window)
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jan 30, 2022
* [QT] Add last block hash to debug ui Trivial addition to display last block hash next to last block time * [QT] Make last block hash selectable ... and linter happy Switch QMetaObject to get last hash from pIndex instead of clientmodel * [Trivial] Fix trailing whitespaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial addition to display last block hash next to last block time