qt: Make sure the statusbar reflects internal states correct#3698
Merged
Conversation
|
Needs rebase |
xdustinface
force-pushed
the
pr-ui-25-sync-process
branch
from
210e7ba to
7563dec
Compare
Author
Done |
UdjinM6
reviewed
Sep 11, 2020
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Looks good in general and seems to be working as expected. Just a few code style related suggestions.
PastaPastaPasta
requested changes
Sep 12, 2020
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
overall looks good, just that nit
Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 13, 2020
…#3698) * qt: Increase number of spinner frames * qt: Add and use BitcoinGUI::startSpinner and BitcoinGUI::stopSpinner * qt: Handle CMasternodeSync::Reset calls * qt: Make sure the statusbar always reflects the sync state/progress * qt: Add BitcoinGUI::updateProgressBarVisibility * qt: Animate connection icon while connecting * qt: Refactor check in BitcoinGUI::updateProgressBarVisibility * qt: Rename some variables * Update src/qt/bitcoingui.cpp Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 3, 2022
…#3698) * qt: Increase number of spinner frames * qt: Add and use BitcoinGUI::startSpinner and BitcoinGUI::stopSpinner * qt: Handle CMasternodeSync::Reset calls * qt: Make sure the statusbar always reflects the sync state/progress * qt: Add BitcoinGUI::updateProgressBarVisibility * qt: Animate connection icon while connecting * qt: Refactor check in BitcoinGUI::updateProgressBarVisibility * qt: Rename some variables * Update src/qt/bitcoingui.cpp Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the statusbar label, the statusbar progressbar and the statusbar sync/connection icons do always represent the actual current networking/syncing state of the wallet. Before this PR they had literally no meaningful connection to the internals most of the time time.
The statusbar label/progressbar will always show/hide now if required and show the correct internal state.
The sync/spinner icon will now disappear if there are no connections available or if the network gets disabled by
setnetworkactiveRPC. Before it was just always there, the spinner was mostly inactive and if the wallet got a sync once, it just always showed the synced icon no matter what. As soon as the wallet gets one connection from now on the spinner will pop up start to animate to signal that the wallet is actually doing something. If its done syncing it gets the green checkmark like before. But if it gets out of sync again due to timeout ormnsyncRPC it will directly represent this unlike before where it always showed synced.Also the connection icon does animate now (show/hide the lower dot in orange with 500ms cycle) if there are no connections available to signal that the wallet is trying to connect to the network.
Click here for a preview video of the sync process (i cut some of the middle/governance sync part)
Based on #3688 + #3690