Replace sporks 2, 3, 9 and 19 with corresponding cmd-line options#3845
Closed
UdjinM6 wants to merge 6 commits into
Closed
Replace sporks 2, 3, 9 and 19 with corresponding cmd-line options#3845UdjinM6 wants to merge 6 commits into
UdjinM6 wants to merge 6 commits into
Conversation
UdjinM6
force-pushed
the
replacespork9
branch
2 times, most recently
from
eb94211 to
8fcc518
Compare
…locks` cmd-line option
…e option Add `Goverenance options` help group
Also rename isSporkActive to isEnabled
UdjinM6
force-pushed
the
replacespork9
branch
from
12c811a to
b6c557a
Compare
UdjinM6
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like we can safely drop these now. I decided to add new command line options instead of simply hardcoding defaults just in case (and it is useful for tests too).Consider this a concept for some future update for now.Based on #3853 atm