Merged
Conversation
|
That would be very odd but nothing is impossible I guess :) |
|
please test #395 on windows |
Author
|
Added 2 more changes: 2: dash.cpp: ignore additional restart-wallet clicks. On windows you could easily click on a repair-wallet button fast enough to trigger more than 1 wallet-restart. Not good. 3: locally removed my own fix for #395, you were faster :-) From my point of view we can merge this now to have more testers using it. |
|
Looks good 👍 |
knst
pushed a commit
to knst/dash
that referenced
this pull request
Sep 26, 2024
d54d949 qt: Fix regression in "Encrypt Wallet" menu item (Hennadii Stepanov) Pull request description: Fix dashpay#392. Adding a new item to the `m_wallet_selector` must follow the establishment of a connection between the `WalletView::encryptionStatusChanged` signal and the `BitcoinGUI::updateWalletStatus` slot. This was a regression introduced in bitcoin@20e2e24 (dashpay#29). --- An _encrypted_ wallet being auto-loaded at the GUI startup: - on master (eaf09bd)  - with this PR  ACKs for top commit: achow101: ACK d54d949 jarolrod: ACK d54d949 Tree-SHA512: 669615ec8e1517c2f4cdf59bd11a7c85be793ba0dda112361cf95e6c2f0636215fed331d26a86dc9b779a49defae1b248232f98dab449584376c111c288e87bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: https://dashtalk.org/threads/enhanced-darkcoin-wallet-ui.1705/page-24#post-58114
My wallet does not crash on Linux at all, and on Windows only about one out of 50 tries if I'm lucky, so it's really hard to test if this works reliably. Found out that almost all crashes are side effects of using BOOST, though, but it's used all over the place so we won't change that.
In theory, QApplication inherits quit() from QCoreApplication so it shouldn't make any difference, but since "Reset Options" uses QApplication::quit() to stop the wallet I thought I would give it a try.
So far (about 80 tries, even in the middle of reindexing) it looks good, however since the blockchain is stuck I can't test this while mining.
I'd appreciate others testing this while mining/mixing.