merge bitcoin#14209, #13878, #14192, #17086: logging and filesystem updates#4199
Merged
Conversation
…byte to utf-8 on Windows
Member
|
Build fails. Please fix |
Collaborator
Author
|
Build fail due to test failure, not reproducible on macOS |
Member
|
I am unable to reproduce these build failures locally. Build works and tests pass fully |
PastaPastaPasta
previously approved these changes
Jun 22, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK, however we need to figure out why CI isn't happy... Unit tests are happy locally. @UdjinM6 hopefully you have an idea?
UdjinM6
requested changes
Jun 23, 2021
d48f664 tests: Fix fs_tests for unknown locales (Daki Carnhof) Pull request description: Fix by removing "L" as suggested by meeDamian in bitcoin#14948 (comment) ``` # all in .../bitcoin/src/test $ uname -m x86_64 $ export LC_ALL=randomnonexistentlocale $ ./test_bitcoin Running 369 test cases... unknown location(0): fatal error: in "fs_tests/fsbridge_fstream": boost::system::system_error: boost::filesystem::path codecvt to string: error test/fs_tests.cpp(13): last checkpoint: "fsbridge_fstream" test entry *** 1 failure is detected in the test module "Bitcoin Core Test Suite" ``` After the patch is applied, the same test under the same conditions runs fine. ``` $ export LC_ALL=randomnonexistentlocale $ ./test_bitcoin Running 369 test cases... *** No errors detected ``` Co-Authored-By: bugs@meedamian.com ACKs for top commit: laanwj: ACK d48f664 Tree-SHA512: a9910252b8ce6a05cab5530874549c2999ca2c28e835fc18aa8e5468fb417bd7d245864ec71d9233dd53e02940a9f0691b247430257f27eb0d7c20745d1c846d
kwvg
changed the title
Collaborator
Author
|
Title has been updated to include Udjin's backport, thanks for figuring it out! |
UdjinM6
approved these changes
Jun 24, 2021
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
LGTM, utACK (assuming CI is going to be happy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclosure:
Includes patches 6f5f2e6, 49e69be and backport bitcoin#17086 (144bf39) by UdjinM6