Skip to content

More of 13743: refactor: Replace boost::bind with std::bind#4385

Merged
UdjinM6 merged 1 commit into
dashpay:developfrom
UdjinM6:fix_linter_15225
Sep 2, 2021
Merged

More of 13743: refactor: Replace boost::bind with std::bind#4385
UdjinM6 merged 1 commit into
dashpay:developfrom
UdjinM6:fix_linter_15225

Conversation

@UdjinM6
Copy link
Copy Markdown

@UdjinM6 UdjinM6 commented Sep 2, 2021

Fixes

Use of boost::bind detected. Use std::bind instead.
src/qt/walletmodel.cpp:    m_handler_can_get_addrs_changed = m_wallet->handleCanGetAddressesChanged(boost::bind(NotifyCanGetAddressesChanged, this));
^---- failure generated from test/lint/lint-cpp.sh

https://gitlab.com/dashpay/dash/-/jobs/1554982691#L53

Sneaked in via 15225 baa76aa#diff-3c5f55f5118243d479461d5445315d9d27772fde1f1d86d828f26d113d1ba8acR506 (#4359)

@UdjinM6 UdjinM6 added this to the 18 milestone Sep 2, 2021
Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

Ya know, it'd be very nice if before merging any PR, we had the ability to rebase it, so that an up to date CI got ran... If only there was a way we could do that.

@UdjinM6 UdjinM6 merged commit c445f38 into dashpay:develop Sep 2, 2021
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Dec 1, 2023
gades pushed a commit to piratecash/pirate that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants