refactor: remove redundant filename prefixes for Dash-specific logic#4475
Merged
Conversation
UdjinM6
requested changes
Oct 1, 2021
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
should re-apply this https://github.com/dashpay/dash/compare/d663b93d90ca6a10dccf2a90d2ffc4249d5af23d..c8bb383e53ada33982005dc58c9838b9bafe52ac#diff-b877bc8a3ab0aea3cfb3348d0a2cd3d4587aafaac8b7918f0671a03f4924031aR10 in governance/governance.h (recent force-push broke it) + see UdjinM6@8f5f5b2
PastaPastaPasta
approved these changes
Oct 1, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
I'm not really a fan of this change, I somewhat prefer more verbose naming, and I HATE that there is wallet/wallet.h and interfaces/wallet.h as I end up in the wrong file in my ide all the time due to it... But, I guess it's probably fine, so
utACK for squash merge
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
…ashpay#4475) * refactor: coinjoin/coinjoin-*[cpp/h] --> coinjoin/*.[cpp/h] * refactor: governance/governance-*[cpp/h] --> governance/*.[cpp/h] * refactor: masternode/masternode-*[cpp/h] --> masternode/*.[cpp/h] * fix linter Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
May 8, 2022
…ashpay#4475) * refactor: coinjoin/coinjoin-*[cpp/h] --> coinjoin/*.[cpp/h] * refactor: governance/governance-*[cpp/h] --> governance/*.[cpp/h] * refactor: masternode/masternode-*[cpp/h] --> masternode/*.[cpp/h] * fix linter Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the pattern established by #4197 (refactoring
util*.[cpp/h]) and #1502 (refactoringrpc*.[cpp/h]), changes have been made in the format specified by the commit message formasternode,coinjoinandgovernanceDeviations
coinjoin-client-options.*has been renamed tooptions.*activemasternode.*has been renamed tonode.*Why now?
This pull request in one in a series of pull requests meant to do some move-only refactoring and revert some rebrandings in preparation for accommodating alternative build systems
Why not now?
The changes are move-only and don't involve any logic changes but could potentially cause inconvenience towards maintainers of parallel pull requests
Additional Notes
llmq/quorum*has not been touched as it's unsure whether to organize them asllmq/quorum/*.[cpp/h]orllmq/*.[cpp/h]