Revert "Merge #16404: qa: Test ZMQ notification after chain reorg"#4646
Merged
Conversation
…org" This reverts commit cf43f40.
Member
|
conflicts with #4642 (investigating action failure) |
PastaPastaPasta
approved these changes
Jan 2, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge (even though this will break my backport script...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
16404 backported via #4610 broke zmq test and it's annoying to have CI fail all the time. I can't find any way to fix it (related backports aren't linear it seems and partial fixes I picked did not help). Proposing to revert it for now. If anyone has a better idea how to fix CI, I'll gladly close this one :)