llmq: Clean old DKG contributions up#4763
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
can this be done on a new thread? and preferably without locking cs_main (or at least not as much as you are)?
Member
There was a problem hiding this comment.
Please use this as opposed to c-style casting
Suggested change
| LogPrint(BCLog::LLMQ, "CDKGSessionManager::%s -- found %lld entries for llmq type %d\n", __func__, cnt_all, (uint8_t)params.type); | |
| LogPrint(BCLog::LLMQ, "CDKGSessionManager::%s -- found %lld entries for llmq type %d\n", __func__, cnt_all, uint8_t(params.type)); |
Member
|
DNM until after #4752 is merged |
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
approved these changes
Apr 18, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
Member
|
@UdjinM6 is this milestone correct? |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 16, 2023
* llmq: Clean old DKG contributions up * apply review suggestions and a bit more * use scheduler
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
* llmq: Clean old DKG contributions up * apply review suggestions and a bit more * use scheduler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.