Skip to content

fix!: llmqTypeInstantSend deactivation prevention if used for other purposes#4848

Merged
UdjinM6 merged 1 commit into
dashpay:developfrom
ogabrielides:llmq_type_deactivation_fix
May 26, 2022
Merged

fix!: llmqTypeInstantSend deactivation prevention if used for other purposes#4848
UdjinM6 merged 1 commit into
dashpay:developfrom
ogabrielides:llmq_type_deactivation_fix

Conversation

@ogabrielides
Copy link
Copy Markdown

@ogabrielides ogabrielides commented May 25, 2022

Protection for devnets and testnet since default chain parameters:

Devnet chain params:

consensus.llmqTypeChainLocks = Consensus::LLMQType::LLMQ_50_60;
consensus.llmqTypeInstantSend = Consensus::LLMQType::LLMQ_50_60;
consensus.llmqTypeDIP0024InstantSend = Consensus::LLMQType::LLMQ_60_75;
consensus.llmqTypePlatform = Consensus::LLMQType::LLMQ_100_67;
consensus.llmqTypeMnhf = Consensus::LLMQType::LLMQ_50_60;

Testnet chain params:

consensus.llmqTypeChainLocks = Consensus::LLMQType::LLMQ_50_60;
consensus.llmqTypeInstantSend = Consensus::LLMQType::LLMQ_50_60;
consensus.llmqTypeDIP0024InstantSend = Consensus::LLMQType::LLMQ_60_75;
consensus.llmqTypePlatform = Consensus::LLMQType::LLMQ_100_67;
consensus.llmqTypeMnhf = Consensus::LLMQType::LLMQ_50_60;

We must not disable llmqTypeInstantSend once DIP24 is active (and has quorums formed) when it is shared for other purposes.

Note: This problem does not affect mainet.
Mainent chain params:

consensus.llmqTypeChainLocks = Consensus::LLMQType::LLMQ_400_60;
consensus.llmqTypeInstantSend = Consensus::LLMQType::LLMQ_50_60;
consensus.llmqTypeDIP0024InstantSend = Consensus::LLMQType::LLMQ_60_75;
consensus.llmqTypePlatform = Consensus::LLMQType::LLMQ_100_67;
consensus.llmqTypeMnhf = Consensus::LLMQType::LLMQ_400_85;

PastaPastaPasta
PastaPastaPasta approved these changes May 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK for squash merge

@PastaPastaPasta PastaPastaPasta added this to the 18 milestone May 25, 2022
@ogabrielides
Copy link
Copy Markdown
Author

ogabrielides commented May 25, 2022

@PastaPastaPasta Need to merge this to v18 branch

UdjinM6
UdjinM6 approved these changes May 25, 2022
View reviewed changes
Copy link
Copy Markdown

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👍

utACK

@ogabrielides
Copy link
Copy Markdown
Author

ogabrielides commented May 26, 2022 •
edited
Loading

@PastaPastaPasta @UdjinM6 You both approved but you did not merge. (I don't have access to merge)

@UdjinM6 UdjinM6 merged commit acb1dd6 into dashpay:develop May 26, 2022
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request May 29, 2022
@ogabrielides @PastaPastaPasta
fix!: llmqTypeInstantSend deactivation prevention if used for other p…
145a974 
…urposes (dashpay#4848)
@ogabrielides ogabrielides deleted the llmq_type_deactivation_fix branch May 31, 2022 14:36
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Nov 16, 2023
@ogabrielides @gades
fix!: llmqTypeInstantSend deactivation prevention if used for other p…
a3f2066 
…urposes (dashpay#4848)
gades pushed a commit to piratecash/pirate that referenced this pull request Dec 9, 2023
@ogabrielides @gades
fix!: llmqTypeInstantSend deactivation prevention if used for other p…
1636dc8 
…urposes (dashpay#4848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@ogabrielides @UdjinM6 @PastaPastaPasta