Skip to content

fix!: Adjusted keepOldConnections value for llmq_devnet#4851

Merged
UdjinM6 merged 1 commit into
dashpay:developfrom
ogabrielides:llmq_devnet_keepoldconnections_adjustement
May 27, 2022
Merged

fix!: Adjusted keepOldConnections value for llmq_devnet#4851
UdjinM6 merged 1 commit into
dashpay:developfrom
ogabrielides:llmq_devnet_keepoldconnections_adjustement

Conversation

@ogabrielides
Copy link
Copy Markdown

@ogabrielides ogabrielides commented May 27, 2022

As mentioned in llmq/params.h:

// Used for intra-quorum communication. This is the number of quorums for which we should keep old connections. This
// should be at least one more then the active quorums set.
int keepOldConnections;

With rotation we increased signingActiveQuorumCount to 4 for llmq_devnet but we never adjusted keepOldConnections

@UdjinM6 UdjinM6 modified the milestones: 18.1, 18 May 27, 2022
PastaPastaPasta
PastaPastaPasta approved these changes May 27, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

UdjinM6
UdjinM6 approved these changes May 27, 2022
View reviewed changes
Copy link
Copy Markdown

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 145fee3 into dashpay:develop May 27, 2022
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request May 29, 2022
@ogabrielides @PastaPastaPasta
Adjusted keepOldConnections value for llmq_devnet (dashpay#4851)
24ba5ce
@ogabrielides ogabrielides deleted the llmq_devnet_keepoldconnections_adjustement branch May 31, 2022 14:36
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Nov 16, 2023
@ogabrielides @gades
Adjusted keepOldConnections value for llmq_devnet (dashpay#4851)
a5001be
gades pushed a commit to piratecash/pirate that referenced this pull request Dec 9, 2023
@ogabrielides @gades
Adjusted keepOldConnections value for llmq_devnet (dashpay#4851)
7f9d739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@ogabrielides @UdjinM6 @PastaPastaPasta