Skip to content

fix(qt): Disable "Show address QR code" menu items/buttons when no qrencode support was compiled in #4854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UdjinM6 merged 1 commit into from
May 29, 2022
Merged

fix(qt): Disable "Show address QR code" menu items/buttons when no qrencode support was compiled in #4854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/qt/addressbookpage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ AddressBookPage::AddressBookPage(Mode _mode, Tabs _tab, QWidget* parent) :
ui->setupUi(this);

ui->showAddressQRCode->setIcon(QIcon());
#ifndef USE_QRCODE
ui->showAddressQRCode->setEnabled(false);
#endif

switch(mode)
{
Expand Down Expand Up @@ -110,6 +113,9 @@ AddressBookPage::AddressBookPage(Mode _mode, Tabs _tab, QWidget* parent) :
QAction *editAction = new QAction(tr("&Edit"), this);
QAction *showAddressQRCodeAction = new QAction(tr("&Show address QR code"), this);
deleteAction = new QAction(ui->deleteAddress->text(), this);
#ifndef USE_QRCODE
showAddressQRCodeAction->setEnabled(false);
#endif

// Build context menu
contextMenu = new QMenu(this);
Expand Down Expand Up @@ -269,13 +275,17 @@ void AddressBookPage::selectionChanged()
break;
}
ui->copyAddress->setEnabled(true);
#ifdef USE_QRCODE
ui->showAddressQRCode->setEnabled(true);
#endif
}
else
{
ui->deleteAddress->setEnabled(false);
ui->copyAddress->setEnabled(false);
#ifdef USE_QRCODE
ui->showAddressQRCode->setEnabled(false);
#endif
}
}

Expand Down
3 changes: 3 additions & 0 deletions src/qt/transactionview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ transactionView(nullptr), abandonAction(nullptr), columnResizingFixer(nullptr)
QAction *editLabelAction = new QAction(tr("Edit address label"), this);
QAction *showDetailsAction = new QAction(tr("Show transaction details"), this);
QAction *showAddressQRCodeAction = new QAction(tr("Show address QR code"), this);
#ifndef USE_QRCODE
showAddressQRCodeAction->setEnabled(false);
#endif

contextMenu = new QMenu(this);
contextMenu->setObjectName("contextMenu");
Expand Down