backport: bitcoin#18867, #19247, #19222, #18363, #18190, #18393, partial #18047, #18314, #19143 (fuzzing harness backports: part 3)#4886
Merged
Conversation
|
This pull request has conflicts, please rebase. |
|
This pull request has conflicts, please rebase. |
kwvg
force-pushed
the
fuzz3
branch
4 times, most recently
from
764e2c7 to
7788006
Compare
PastaPastaPasta
previously approved these changes
Jul 13, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
utACK for merging via merge commit
Collaborator
@PastaPastaPasta Thanks for reviewing. Your response was a little vague though. My only question is, could you let us know if you will utACK this for merging via a merge commit? |
UdjinM6
requested changes
Jul 13, 2022
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Can't compile:
In file included from test/fuzz/addition_overflow.cpp:7:
./test/fuzz/util.h:265:13: error: no matching function for call to 'AdditionOverflow'
if (AdditionOverflow((uint64_t)fuzzed_file->m_offset, random_bytes.size())) {
^~~~~~~~~~~~~~~~
./test/fuzz/util.h:131:20: note: candidate template ignored: deduced conflicting types for parameter 'T' ('unsigned long long' vs. 'unsigned long')
[[nodiscard]] bool AdditionOverflow(const T i, const T j) noexcept
^
./test/fuzz/util.h:276:13: error: no matching function for call to 'AdditionOverflow'
if (AdditionOverflow(fuzzed_file->m_offset, n)) {
^~~~~~~~~~~~~~~~
./test/fuzz/util.h:131:20: note: candidate template ignored: deduced conflicting types for parameter 'T' ('long long' vs. 'long')
[[nodiscard]] bool AdditionOverflow(const T i, const T j) noexcept
^
2 errors generated.
dropping 60aa00a590 helps
…e/CSubNet related functions (netaddress.h)
…a (utxo_snapshot). Increase fuzzing coverage
…File, LoadExternalBlockFile and other FILE* consumers
…ilarity AdditionOverflow is a template function that expects both inputs to explicitly be of the same type
…evhttp and related functions
…mbRiceEncode/GolombRiceDecode)
…in MultiplicationOverflow(...) fuzzing harness
…}SHA{1,256,512}, CRIPEMD160, CSipHasher, etc.
…binary per message type for optimal results when using coverage-guided fuzzing
PastaPastaPasta
approved these changes
Jul 17, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on